Skip to content

HBASE-23051 Remove unneeded Mockito.mock invocations - #641

Merged
petersomogyi merged 2 commits into
apache:masterfrom
petersomogyi:HBASE-23051
Sep 19, 2019
Merged

HBASE-23051 Remove unneeded Mockito.mock invocations#641
petersomogyi merged 2 commits into
apache:masterfrom
petersomogyi:HBASE-23051

Conversation

@petersomogyi

Copy link
Copy Markdown
Contributor

No description provided.

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec1m 7sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
💚mvninstall6m 8smaster passed
💚compile0m 59smaster passed
💚checkstyle1m 28smaster passed
💚shadedjars5m 10sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 39smaster passed
💙spotbugs4m 31sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 29smaster passed
_ Patch Compile Tests _
💚mvninstall5m 36sthe patch passed
💚compile1m 0sthe patch passed
💚javac1m 0sthe patch passed
💔checkstyle1m 30shbase-server: The patch generated 1 new + 7 unchanged - 0 fixed = 8 total (was 7)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars5m 1spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck17m 24sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 35sthe patch passed
💚findbugs4m 33sthe patch passed
_ Other Tests _
💔unit232m 27shbase-server in the patch failed.
💚asflicense0m 36sThe patch does not generate ASF License warnings.
295m 36s
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-641/1/artifact/out/Dockerfile
GITHUB PR#641
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux ca5a83de5b3b 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-641/out/precommit/personality/provided.sh
git revisionmaster / a0e8723
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-641/1/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-641/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-641/1/testReport/
Max. process+thread count5181 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-641/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
💙reexec0m 33sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
💚mvninstall5m 58smaster passed
💚compile0m 59smaster passed
💚checkstyle1m 32smaster passed
💚shadedjars5m 2sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 39smaster passed
💙spotbugs4m 35sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 33smaster passed
_ Patch Compile Tests _
💚mvninstall5m 29sthe patch passed
💚compile0m 57sthe patch passed
💚javac0m 57sthe patch passed
💚checkstyle1m 27sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars5m 3spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck17m 41sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 35sthe patch passed
💚findbugs4m 47sthe patch passed
_ Other Tests _
💚unit157m 51shbase-server in the patch passed.
💚asflicense0m 25sThe patch does not generate ASF License warnings.
220m 55s
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-641/2/artifact/out/Dockerfile
GITHUB PR#641
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 0dcf375b2661 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-641/out/precommit/personality/provided.sh
git revisionmaster / 1655360
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-641/2/testReport/
Max. process+thread count4490 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-641/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@petersomogyi
petersomogyi merged commit 1fec3d1 into apache:masterSep 19, 2019
asfgit pushed a commit that referenced this pull request Sep 19, 2019
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Sep 19, 2019
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Sep 19, 2019
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
@petersomogyi
petersomogyi deleted the HBASE-23051 branch September 23, 2019 07:19
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
(cherry picked from commit 64a68c5)
Change-Id: Ie47bc90556ffd6d1d9fa9e0bf44467056d02b222
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@petersomogyi@Apache-HBase@saintstack@Apache9