Skip to content

HBASE-28621 PrefixFilter should use SEEK_NEXT_USING_HINT - #6424

Merged
stoty merged 1 commit into
apache:branch-2from
PDavid:HBASE-28621-PrefixFilter-SEEK_NEXT_USING_HINT-branch-2
Nov 6, 2024
Merged

HBASE-28621 PrefixFilter should use SEEK_NEXT_USING_HINT#6424
stoty merged 1 commit into
apache:branch-2from
PDavid:HBASE-28621-PrefixFilter-SEEK_NEXT_USING_HINT-branch-2

Conversation

@PDavid

@PDavidPDavid commented Oct 31, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

This is the backport of #6361 to branch-2.

@PDavidPDavid mentioned this pull request Oct 31, 2024
Merged
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@PDavid
PDavid marked this pull request as ready for review October 31, 2024 12:25
@PDavid
PDavidforce-pushed the HBASE-28621-PrefixFilter-SEEK_NEXT_USING_HINT-branch-2 branch from 8060ca1 to f7f25c5CompareOctober 31, 2024 13:38
@Apache-HBase

This comment has been minimized.

Sign in to view
@PDavid
PDavidforce-pushed the HBASE-28621-PrefixFilter-SEEK_NEXT_USING_HINT-branch-2 branch from f7f25c5 to 52a288dCompareOctober 31, 2024 15:48
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@stoty

stoty commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

The errors are unrelated.

@PDavid
PDavidforce-pushed the HBASE-28621-PrefixFilter-SEEK_NEXT_USING_HINT-branch-2 branch from 52a288d to ee84469CompareNovember 4, 2024 09:59
@Apache-HBase

This comment has been minimized.

Sign in to view
@PDavid
PDavidforce-pushed the HBASE-28621-PrefixFilter-SEEK_NEXT_USING_HINT-branch-2 branch from ee84469 to 07047b6CompareNovember 5, 2024 08:00
@PDavid
PDavidforce-pushed the HBASE-28621-PrefixFilter-SEEK_NEXT_USING_HINT-branch-2 branch from 07047b6 to a8cd79dCompareNovember 5, 2024 08:01
@Apache-HBase

Apache-HBase commented Nov 5, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec8m 20sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall4m 25sbranch-2 passed
+1 💚compile5m 0sbranch-2 passed
+1 💚checkstyle1m 8sbranch-2 passed
+1 💚spotbugs2m 53sbranch-2 passed
+1 💚spotless0m 54sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall5m 58sthe patch passed
+1 💚compile4m 30sthe patch passed
+1 💚javac4m 30sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 19shbase-client: The patch generated 0 new + 0 unchanged - 5 fixed = 0 total (was 5)
+1 💚checkstyle0m 45shbase-server: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚spotbugs3m 12sthe patch passed
+1 💚hadoopcheck22m 51sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless0m 50spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 22sThe patch does not generate ASF License warnings.
64m 33s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6424
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux dc4cacb34fb1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a8cd79d
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count78 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 5, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 14sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 36sbranch-2 passed
+1 💚compile1m 52sbranch-2 passed
+1 💚javadoc1m 4sbranch-2 passed
+1 💚shadedjars7m 55sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall3m 56sthe patch passed
+1 💚compile1m 46sthe patch passed
+1 💚javac1m 46sthe patch passed
+1 💚javadoc1m 8sthe patch passed
+1 💚shadedjars7m 38spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit9m 7shbase-client in the patch passed.
+1 💚unit295m 6shbase-server in the patch passed.
341m 13s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6424
Optional Testsjavac javadoc unit compile shadedjars
unameLinux b3c1519c0fc2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a8cd79d
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/testReport/
Max. process+thread count4345 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 5, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 58sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall4m 16sbranch-2 passed
+1 💚compile2m 9sbranch-2 passed
+1 💚javadoc1m 17sbranch-2 passed
+1 💚shadedjars7m 35sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 6sthe patch passed
+1 💚compile2m 1sthe patch passed
+1 💚javac2m 1sthe patch passed
+1 💚javadoc1m 1sthe patch passed
+1 💚shadedjars7m 53spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit7m 45shbase-client in the patch passed.
-1 ❌unit285m 5s/patch-unit-hbase-server.txthbase-server in the patch failed.
330m 18s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6424
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 8cd71615e9ff 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a8cd79d
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/testReport/
Max. process+thread count4141 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 5, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec16m 34sDocker mode activated.
-0 ⚠️yetus0m 11sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep1m 50sMaven dependency ordering for branch
+1 💚mvninstall5m 20sbranch-2 passed
+1 💚compile1m 15sbranch-2 passed
+1 💚javadoc1m 3sbranch-2 passed
+1 💚shadedjars6m 53sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall5m 31sthe patch passed
+1 💚compile1m 9sthe patch passed
+1 💚javac1m 9sthe patch passed
+1 💚javadoc0m 48sthe patch passed
+1 💚shadedjars6m 40spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit8m 28shbase-client in the patch passed.
-1 ❌unit502m 43s/patch-unit-hbase-server.txthbase-server in the patch failed.
577m 14s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6424
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 578a53e217bb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a8cd79d
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/testReport/
Max. process+thread count3968 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6424/5/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@stoty
stoty merged commit 0aee886 into apache:branch-2Nov 6, 2024
stoty pushed a commit that referenced this pull request Nov 6, 2024
@PDavidDávid Paksy@stoty
HBASE-28621PrefixFilter should use SEEK_NEXT_USING_HINT (#6424)
8c6247f
Co-authored-by: Dávid Paksy <paksyd@cloudera.com>
Signed-off-by: Istvan Toth <stoty@apache.org>
(cherry picked from commit 0aee886)
stoty pushed a commit that referenced this pull request Nov 6, 2024
@PDavidDávid Paksy@stoty
HBASE-28621PrefixFilter should use SEEK_NEXT_USING_HINT (#6424)
815aa30
Co-authored-by: Dávid Paksy <paksyd@cloudera.com>
Signed-off-by: Istvan Toth <stoty@apache.org>
(cherry picked from commit 0aee886)
@PDavid
PDavid deleted the HBASE-28621-PrefixFilter-SEEK_NEXT_USING_HINT-branch-2 branch November 6, 2024 09:57
sanjeet006py pushed a commit to sanjeet006py/hbase that referenced this pull request Sep 26, 2025
@PDavidDávid Paksytok_sfci135 tok_sfci135
HBASE-28621 PrefixFilter should use SEEK_NEXT_USING_HINT (apache#6424)
3906c68
Co-authored-by: Dávid Paksy <paksyd@cloudera.com>
Signed-off-by: Istvan Toth <stoty@apache.org>
(cherry picked from commit 0aee886)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PDavid@Apache-HBase@stoty