Skip to content

HBASE-28564 [addendum] Refactor direct interactions of Reference file creations to SFT interface - #6427

Merged
petersomogyi merged 1 commit into
apache:branch-2from
petersomogyi:HBASE-28564-branch-2
Nov 4, 2024
Merged

HBASE-28564 [addendum] Refactor direct interactions of Reference file creations to SFT interface#6427
petersomogyi merged 1 commit into
apache:branch-2from
petersomogyi:HBASE-28564-branch-2

Conversation

@petersomogyi

@petersomogyipetersomogyi commented Nov 3, 2024

Copy link
Copy Markdown
Contributor

spotless fix

@petersomogyipetersomogyi mentioned this pull request Nov 3, 2024
Merged
@Apache-HBase

Apache-HBase commented Nov 3, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+1 💚mvninstall3m 12sbranch-2 passed
+1 💚compile2m 57sbranch-2 passed
+1 💚checkstyle0m 38sbranch-2 passed
+1 💚spotbugs1m 33sbranch-2 passed
-1 ❌spotless0m 40sbranch has 23 errors when running spotless:check, run spotless:apply to fix.
_ Patch Compile Tests _
+1 💚mvninstall3m 4sthe patch passed
+1 💚compile2m 54sthe patch passed
+1 💚javac2m 54sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 36sthe patch passed
+1 💚spotbugs1m 40sthe patch passed
+1 💚hadoopcheck16m 22sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
36m 54s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6427/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6427
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 50215313fa08 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 2a4a02a
Default JavaEclipse Adoptium-11.0.23+9
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6427/1/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count78 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6427/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 3, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 47sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 59sbranch-2 passed
+1 💚compile0m 51sbranch-2 passed
+1 💚javadoc0m 26sbranch-2 passed
+1 💚shadedjars5m 47sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 53sthe patch passed
+1 💚compile0m 53sthe patch passed
+1 💚javac0m 53sthe patch passed
+1 💚javadoc0m 25sthe patch passed
+1 💚shadedjars5m 41spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit203m 59shbase-server in the patch passed.
229m 29s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6427/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6427
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 022e6bc96e06 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 2a4a02a
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6427/1/testReport/
Max. process+thread count4439 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6427/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 3, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 51sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 2sbranch-2 passed
+1 💚compile0m 53sbranch-2 passed
+1 💚javadoc0m 29sbranch-2 passed
+1 💚shadedjars5m 37sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 56sthe patch passed
+1 💚compile0m 52sthe patch passed
+1 💚javac0m 52sthe patch passed
+1 💚javadoc0m 26sthe patch passed
+1 💚shadedjars5m 40spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit227m 50shbase-server in the patch passed.
253m 18s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6427/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6427
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 383f6c3ff49e 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 2a4a02a
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6427/1/testReport/
Max. process+thread count4172 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6427/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 3, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec2m 9sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 48sbranch-2 passed
+1 💚compile0m 53sbranch-2 passed
+1 💚javadoc0m 36sbranch-2 passed
+1 💚shadedjars5m 53sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 40sthe patch passed
+1 💚compile0m 58sthe patch passed
+1 💚javac0m 58sthe patch passed
+1 💚javadoc0m 28sthe patch passed
+1 💚shadedjars5m 52spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit232m 13shbase-server in the patch passed.
261m 4s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6427/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6427
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 759495a4fd77 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 2a4a02a
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6427/1/testReport/
Max. process+thread count4405 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6427/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

PDavid
PDavid approved these changes Nov 4, 2024
View reviewed changes

@PDavidPDavid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! 👍

@petersomogyi
petersomogyi merged commit b873092 into apache:branch-2Nov 4, 2024
@petersomogyi
petersomogyi deleted the HBASE-28564-branch-2 branch November 6, 2024 11:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PDavidPDavidPDavid approved these changes
@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petersomogyi@Apache-HBase@PDavid@Apache9