Skip to content

HBASE-28921 Avoid bundling hbase-webapps folder in default jars - #6431

Merged
NihalJain merged 1 commit into
apache:branch-2.6from
NihalJain:HBASE-28921_v2_branch-2.6
Nov 6, 2024
Merged

HBASE-28921 Avoid bundling hbase-webapps folder in default jars#6431
NihalJain merged 1 commit into
apache:branch-2.6from
NihalJain:HBASE-28921_v2_branch-2.6

Conversation

@NihalJain

@NihalJainNihalJain commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

@NihalJain
HBASE-28921 Avoid bundling hbase-webapps folder in default jars (apac…
315118c
…he#6388)
We are bundling all webapp resources in hbase-server, hbase-thrift, hbase-rest and transitively to hbase-shaded-mapreduce jar. This can be an issue, say if any of the Js projects used by hbase are vulnerable, security scan tools like sonatype start flagging the jars too as vulnerable since they contain vulnerable code.
With this JIRA, we want to avoid bundling static webapp resources in our jars as these are available during runtime via hbase-webapps directory bundled in our assembly.
But, we still need this for our minicluster based tests which expects it to be present in test classpath. Hence, we are copying hbase-webapps to hbase-server tests jar, which contains class SingleProcessHBaseCluster responsible for hbase minicluster creation. This class eventually needs hbase-webapps in classpath during HttpServer initialisation and hence we are adding hbase-webapps to hbase-server test resources.
Signed-off-by: Istvan Toth <stoty@apache.org>
(cherry picked from commit 16c51d8)
@NihalJainNihalJain added the backport This PR is a back port of some issue or issues already committed to master label Nov 4, 2024
@Apache-HBase

Apache-HBase commented Nov 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 49sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall5m 5sbranch-2.6 passed
+1 💚compile7m 23sbranch-2.6 passed
+1 💚spotless1m 25sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall4m 34sthe patch passed
+1 💚compile5m 56sthe patch passed
+1 💚javac5m 56sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 1sNo new issues.
+1 💚hadoopcheck21m 16sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless1m 18spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 55sThe patch does not generate ASF License warnings.
51m 36s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6431/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6431
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
unameLinux 965879e17446 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 315118c
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6431/1/console
versionsgit=2.34.1 maven=3.9.8 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 46sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 9sbranch-2.6 passed
+1 💚compile2m 8sbranch-2.6 passed
+1 💚javadoc1m 16sbranch-2.6 passed
+1 💚shadedjars6m 32sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall2m 50sthe patch passed
+1 💚compile1m 28sthe patch passed
+1 💚javac1m 28sthe patch passed
+1 💚javadoc0m 53sthe patch passed
+1 💚shadedjars5m 46spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit215m 22shbase-server in the patch passed.
+1 💚unit6m 47shbase-thrift in the patch passed.
+1 💚unit3m 48shbase-rest in the patch passed.
255m 28s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6431/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6431
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2cef074e13e1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 315118c
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6431/1/testReport/
Max. process+thread count4256 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6431/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 43sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for branch
+1 💚mvninstall2m 26sbranch-2.6 passed
+1 💚compile1m 27sbranch-2.6 passed
+1 💚javadoc1m 4sbranch-2.6 passed
+1 💚shadedjars4m 47sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 21sthe patch passed
+1 💚compile1m 26sthe patch passed
+1 💚javac1m 26sthe patch passed
+1 💚javadoc1m 5sthe patch passed
+1 💚shadedjars4m 44spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit225m 49shbase-server in the patch passed.
+1 💚unit7m 57shbase-thrift in the patch passed.
+1 💚unit4m 16shbase-rest in the patch passed.
263m 12s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6431/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6431
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ed90be13b164 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 315118c
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6431/1/testReport/
Max. process+thread count4312 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6431/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 59sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 44sbranch-2.6 passed
+1 💚compile2m 32sbranch-2.6 passed
+1 💚javadoc1m 19sbranch-2.6 passed
+1 💚shadedjars8m 31sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall4m 6sthe patch passed
+1 💚compile2m 44sthe patch passed
+1 💚javac2m 44sthe patch passed
+1 💚javadoc1m 33sthe patch passed
+1 💚shadedjars7m 16spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit283m 37shbase-server in the patch passed.
+1 💚unit26m 4shbase-thrift in the patch passed.
+1 💚unit5m 0shbase-rest in the patch passed.
356m 54s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6431/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6431
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2719a38c45d0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 315118c
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6431/1/testReport/
Max. process+thread count4268 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6431/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain
NihalJain merged commit c46eca1 into apache:branch-2.6Nov 6, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NihalJain@Apache-HBase