Skip to content

HBASE-28921 Avoid bundling hbase-webapps folder in default jars - #6432

Merged
NihalJain merged 1 commit into
apache:branch-2.5from
NihalJain:HBASE-28921_v2_branch-2.5
Nov 6, 2024
Merged

HBASE-28921 Avoid bundling hbase-webapps folder in default jars#6432
NihalJain merged 1 commit into
apache:branch-2.5from
NihalJain:HBASE-28921_v2_branch-2.5

Conversation

@NihalJain

@NihalJainNihalJain commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

@NihalJain
HBASE-28921 Avoid bundling hbase-webapps folder in default jars (apac…
7a3ef19
…he#6388)
We are bundling all webapp resources in hbase-server, hbase-thrift, hbase-rest and transitively to hbase-shaded-mapreduce jar. This can be an issue, say if any of the Js projects used by hbase are vulnerable, security scan tools like sonatype start flagging the jars too as vulnerable since they contain vulnerable code.
With this JIRA, we want to avoid bundling static webapp resources in our jars as these are available during runtime via hbase-webapps directory bundled in our assembly.
But, we still need this for our minicluster based tests which expects it to be present in test classpath. Hence, we are copying hbase-webapps to hbase-server tests jar, which contains class SingleProcessHBaseCluster responsible for hbase minicluster creation. This class eventually needs hbase-webapps in classpath during HttpServer initialisation and hence we are adding hbase-webapps to hbase-server test resources.
Signed-off-by: Istvan Toth <stoty@apache.org>
(cherry picked from commit 16c51d8)
@NihalJainNihalJain added the backport This PR is a back port of some issue or issues already committed to master label Nov 4, 2024
@Apache-HBase

Apache-HBase commented Nov 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 55sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall3m 2sbranch-2.5 passed
+1 💚compile3m 53sbranch-2.5 passed
+1 💚spotless0m 47sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 55sthe patch passed
+1 💚compile3m 51sthe patch passed
+1 💚javac3m 51sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck22m 43sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 34sThe patch does not generate ASF License warnings.
42m 42s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6432/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6432
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
unameLinux 66ac3e3fbab1 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 7a3ef19
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count73 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6432/1/console
versionsgit=2.34.1 maven=3.9.8 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 46sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 8sMaven dependency ordering for branch
+1 💚mvninstall2m 25sbranch-2.5 passed
+1 💚compile1m 26sbranch-2.5 passed
+1 💚javadoc1m 4sbranch-2.5 passed
+1 💚shadedjars4m 43sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 22sthe patch passed
+1 💚compile1m 25sthe patch passed
+1 💚javac1m 25sthe patch passed
+1 💚javadoc1m 4sthe patch passed
+1 💚shadedjars4m 43spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit210m 52shbase-server in the patch passed.
+1 💚unit6m 44shbase-thrift in the patch passed.
+1 💚unit4m 38shbase-rest in the patch passed.
247m 17s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6432/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6432
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d3aa7b82010c 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 7a3ef19
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6432/1/testReport/
Max. process+thread count4324 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6432/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 43sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall2m 59sbranch-2.5 passed
+1 💚compile1m 37sbranch-2.5 passed
+1 💚javadoc0m 56sbranch-2.5 passed
+1 💚shadedjars5m 26sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 48sthe patch passed
+1 💚compile1m 44sthe patch passed
+1 💚javac1m 44sthe patch passed
+1 💚javadoc1m 25sthe patch passed
+1 💚shadedjars6m 30spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit248m 28shbase-server in the patch passed.
+1 💚unit8m 37shbase-thrift in the patch passed.
+1 💚unit4m 17shbase-rest in the patch passed.
291m 12s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6432/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6432
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d88f4c5a54ec 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 7a3ef19
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6432/1/testReport/
Max. process+thread count3880 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6432/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 23sbranch-2.5 passed
+1 💚compile2m 24sbranch-2.5 passed
+1 💚javadoc1m 21sbranch-2.5 passed
+1 💚shadedjars7m 38sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall4m 10sthe patch passed
+1 💚compile2m 15sthe patch passed
+1 💚javac2m 15sthe patch passed
+1 💚javadoc1m 15sthe patch passed
+1 💚shadedjars6m 51spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit294m 19shbase-server in the patch passed.
+1 💚unit7m 41shbase-thrift in the patch passed.
+1 💚unit7m 57shbase-rest in the patch passed.
346m 56s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6432/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6432
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7ccae07541ed 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 7a3ef19
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6432/1/testReport/
Max. process+thread count4662 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6432/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain
NihalJain merged commit 8173cca into apache:branch-2.5Nov 6, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NihalJain@Apache-HBase