Skip to content

HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper - #6433

Merged
NihalJain merged 1 commit into
apache:branch-2.6from
NihalJain:HBASE-28070_branch-2.6
Nov 7, 2024
Merged

HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper#6433
NihalJain merged 1 commit into
apache:branch-2.6from
NihalJain:HBASE-28070_branch-2.6

Conversation

@NihalJain

@NihalJainNihalJain commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

@NihalJain
HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper (a…
4c9356c
…pache#6218) (apache#5607)
- Also handle changes required for hadoop-2 assembly
Signed-off-by: Istvan Toth <stoty@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit b6394b1)
(cherry picked from commit 2537690)
@NihalJainNihalJain added the backport This PR is a back port of some issue or issues already committed to master label Nov 4, 2024
@NihalJain

NihalJain commented Nov 4, 2024

Copy link
Copy Markdown
ContributorAuthor

Verified following on branch-2.6

  • Built code and ran hbase-shell unit tests locally
  • Started hbase master in standalone, did basic shell sanity
  • Started hbase-rest in standalone, did basic rest sanity
  • Started hbase-thrift in standalone, ran thrift examples

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

Apache-HBase commented Nov 6, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 15sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall4m 32sbranch-2.6 passed
+1 💚compile8m 39sbranch-2.6 passed
+1 💚spotless0m 56sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall3m 27sthe patch passed
+1 💚compile8m 11sthe patch passed
+1 💚javac8m 11sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck19m 47sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense1m 20sThe patch does not generate ASF License warnings.
51m 41s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6433
Optional Testsdupname asflicense javac codespell detsecrets xmllint spotless hadoopcheck compile
unameLinux 671ac231d74f 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 4c9356c
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count77 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/console
versionsgit=2.34.1 maven=3.9.8 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 6, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 57sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 21sbranch-2.6 passed
+1 💚compile2m 56sbranch-2.6 passed
+1 💚javadoc4m 10sbranch-2.6 passed
+1 💚shadedjars7m 14sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall3m 51sthe patch passed
+1 💚compile2m 57sthe patch passed
+1 💚javac2m 57sthe patch passed
+1 💚javadoc4m 9sthe patch passed
+1 💚shadedjars6m 3spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit250m 39s/patch-unit-root.txtroot in the patch failed.
294m 18s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6433
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a341a1f09a4e 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 4c9356c
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/testReport/
Max. process+thread count4883 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 6, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall2m 32sbranch-2.6 passed
+1 💚compile1m 42sbranch-2.6 passed
+1 💚javadoc2m 54sbranch-2.6 passed
+1 💚shadedjars5m 14sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 19sthe patch passed
+1 💚compile1m 45sthe patch passed
+1 💚javac1m 45sthe patch passed
-0 ⚠️javadoc1m 30s/results-javadoc-javadoc-root.txtroot generated 10 new + 90 unchanged - 10 fixed = 100 total (was 100)
+1 💚shadedjars5m 11spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit406m 39sroot in the patch passed.
439m 16s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6433
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d773d49b0258 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 4c9356c
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/testReport/
Max. process+thread count8038 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 6, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 25sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 43sMaven dependency ordering for branch
+1 💚mvninstall4m 56sbranch-2.6 passed
+1 💚compile2m 48sbranch-2.6 passed
+1 💚javadoc5m 7sbranch-2.6 passed
+1 💚shadedjars7m 48sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall3m 12sthe patch passed
+1 💚compile2m 23sthe patch passed
+1 💚javac2m 23sthe patch passed
+1 💚javadoc3m 21sthe patch passed
+1 💚shadedjars6m 47spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit476m 55s/patch-unit-root.txtroot in the patch failed.
530m 20s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6433
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 725c6ad338f2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 4c9356c
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/testReport/
Max. process+thread count4812 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6433/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain

NihalJain commented Nov 7, 2024

Copy link
Copy Markdown
ContributorAuthor

Failure are unrelated and do not fail consistently with this change!

@NihalJain
NihalJain merged commit 432e548 into apache:branch-2.6Nov 7, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NihalJain@Apache-HBase