Skip to content

HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper - #6434

Merged
NihalJain merged 1 commit into
apache:branch-2.5from
NihalJain:HBASE-28070_branch-2.5
Nov 7, 2024
Merged

HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper#6434
NihalJain merged 1 commit into
apache:branch-2.5from
NihalJain:HBASE-28070_branch-2.5

Conversation

@NihalJain

@NihalJainNihalJain commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

@NihalJain
HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper (a…
1e65255
…pache#6218) (apache#5607)
- Also handle changes required for hadoop-2 assembly
Signed-off-by: Istvan Toth <stoty@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit b6394b1)
(cherry picked from commit 2537690)
@NihalJainNihalJain added the backport This PR is a back port of some issue or issues already committed to master label Nov 4, 2024
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@NihalJain

NihalJain commented Nov 4, 2024

Copy link
Copy Markdown
ContributorAuthor

Verified following on branch-2.5

  • Built code and ran hbase-shell unit tests locally
  • Started hbase master in standalone, did basic shell sanity
  • Started hbase-rest in standalone, did basic rest sanity
  • Started hbase-thrift in standalone, ran thrift examples

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

Apache-HBase commented Nov 6, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 50sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall2m 47sbranch-2.5 passed
+1 💚compile5m 3sbranch-2.5 passed
+1 💚spotless0m 44sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall2m 42sthe patch passed
+1 💚compile5m 7sthe patch passed
+1 💚javac5m 7sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 2sNo new issues.
+1 💚hadoopcheck19m 15sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.
+1 💚spotless0m 45spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense1m 7sThe patch does not generate ASF License warnings.
40m 55s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6434
Optional Testsdupname asflicense javac codespell detsecrets xmllint spotless hadoopcheck compile
unameLinux 9d8afdb5c8a2 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 1e65255
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count74 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/console
versionsgit=2.34.1 maven=3.9.8 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 7, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 4sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall3m 59sbranch-2.5 passed
+1 💚compile3m 2sbranch-2.5 passed
+1 💚javadoc5m 12sbranch-2.5 passed
+1 💚shadedjars6m 49sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 45sthe patch passed
+1 💚compile2m 9sthe patch passed
+1 💚javac2m 9sthe patch passed
+1 💚javadoc4m 39sthe patch passed
+1 💚shadedjars6m 9spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit250m 37s/patch-unit-root.txtroot in the patch failed.
292m 59s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6434
Optional Testsjavac javadoc unit shadedjars compile
unameLinux dbd873d45752 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 1e65255
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/testReport/
Max. process+thread count4716 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 7, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 52sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall3m 17sbranch-2.5 passed
+1 💚compile2m 23sbranch-2.5 passed
+1 💚javadoc3m 42sbranch-2.5 passed
+1 💚shadedjars5m 58sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall3m 31sthe patch passed
+1 💚compile2m 34sthe patch passed
+1 💚javac2m 34sthe patch passed
+1 💚javadoc3m 48sthe patch passed
+1 💚shadedjars6m 20spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit295m 50sroot in the patch passed.
335m 31s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6434
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 294ad3a38344 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 1e65255
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/testReport/
Max. process+thread count7516 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 7, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 56sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall3m 14sbranch-2.5 passed
+1 💚compile2m 9sbranch-2.5 passed
+1 💚javadoc3m 50sbranch-2.5 passed
+1 💚shadedjars5m 48sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall2m 53sthe patch passed
+1 💚compile2m 13sthe patch passed
+1 💚javac2m 13sthe patch passed
+1 💚javadoc3m 52sthe patch passed
+1 💚shadedjars5m 31spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit407m 57sroot in the patch passed.
446m 27s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6434
Optional Testsjavac javadoc unit shadedjars compile
unameLinux cbedecb14f43 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 1e65255
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/testReport/
Max. process+thread count6630 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain

NihalJain commented Nov 7, 2024

Copy link
Copy Markdown
ContributorAuthor

Failure are unrelated and do not fail consistently with this change!

@NihalJain
NihalJain merged commit 4bb5f94 into apache:branch-2.5Nov 7, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NihalJain@Apache-HBase