HBASE-28972 Limit the number of retries in FanOutOneBlockAsyncDFSOutp… by Apache9 · Pull Request #6453 · apache/hbase

Apache9 · 2024-11-08T14:56:43Z

…utHelper.completeFile

stoty · 2024-11-11T06:00:01Z

- HdfsFileStatus stat) {
- for (int retry = 0;; retry++) {
+ HdfsFileStatus stat) throws IOException {
+ int maxRetries = client.getConf().getBlockWriteLocateFollowingInitialDelayMs();


The method name refers to milliseconds, which makes this sound we're using a temporal value for the number of retries.
Is this really the config option we want here ? Is the Hadoop getter misnamed ?

Oh, should be a typo, there is a retry number config.
Let me fix.

…utHelper.completeFile

stoty

+1 LGTM (pending tests)

Apache-HBase · 2024-11-11T07:51:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 38s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 55s		master passed
+1 💚	compile	7m 36s		master passed
+1 💚	checkstyle	1m 8s		master passed
+1 💚	spotbugs	7m 28s		master passed
+1 💚	spotless	0m 42s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 46s		the patch passed
+1 💚	compile	7m 37s		the patch passed
+1 💚	javac	7m 37s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 10s		the patch passed
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	7m 39s		the patch passed
+1 💚	hadoopcheck	10m 42s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 20s		The patch does not generate ASF License warnings.
		60m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6453/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6453
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint
uname	Linux d9e2d585b098 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5875c93`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	191 (vs. ulimit of 30000)
modules	C: hbase-asyncfs . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6453/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-11T12:22:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 42s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 8s		master passed
+1 💚	compile	2m 7s		master passed
+1 💚	javadoc	2m 21s		master passed
+1 💚	shadedjars	5m 23s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 5s		the patch passed
+1 💚	compile	2m 9s		the patch passed
+1 💚	javac	2m 9s		the patch passed
+1 💚	javadoc	2m 20s		the patch passed
+1 💚	shadedjars	5m 25s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	298m 6s	/patch-unit-root.txt	root in the patch failed.
		331m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6453/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6453
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 010177dbf731 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5875c93`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6453/3/testReport/
Max. process+thread count	8087 (vs. ulimit of 30000)
modules	C: hbase-asyncfs . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6453/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

…utHelper.completeFile (#6453) Signed-off-by: Istvan Toth <stoty@apache.org> (cherry picked from commit 05bd810)

Apache9 self-assigned this Nov 8, 2024

This comment has been minimized.
Sign in to view

Apache9 requested a review from stoty November 11, 2024 02:16

stoty reviewed Nov 11, 2024
View reviewed changes

Apache9 added 2 commits November 11, 2024 14:36

HBASE-28972 Limit the number of retries in FanOutOneBlockAsyncDFSOutp…
4c148bd
…utHelper.completeFile

trigger test
5875c93

Apache9 force-pushed the HBASE-28972 branch from 69ea0a4 to 5875c93Compare November 11, 2024 06:37

stoty approved these changes Nov 11, 2024
View reviewed changes

Apache9 merged commit 05bd810 into apache:masterNov 11, 2024

Apache9 added a commit that referenced this pull request Nov 11, 2024
HBASE-28972Limit the number of retries in FanOutOneBlockAsyncDFSOutp…
9f9cb59
…utHelper.completeFile (#6453) Signed-off-by: Istvan Toth <stoty@apache.org> (cherry picked from commit 05bd810)

Apache9 added a commit that referenced this pull request Nov 11, 2024
HBASE-28972Limit the number of retries in FanOutOneBlockAsyncDFSOutp…
81d2445
…utHelper.completeFile (#6453) Signed-off-by: Istvan Toth <stoty@apache.org> (cherry picked from commit 05bd810)

Apache9 added a commit that referenced this pull request Nov 11, 2024
HBASE-28972Limit the number of retries in FanOutOneBlockAsyncDFSOutp…
8119b0e
…utHelper.completeFile (#6453) Signed-off-by: Istvan Toth <stoty@apache.org> (cherry picked from commit 05bd810)

Apache9 added a commit that referenced this pull request Nov 11, 2024
HBASE-28972Limit the number of retries in FanOutOneBlockAsyncDFSOutp…
20184b5
…utHelper.completeFile (#6453) Signed-off-by: Istvan Toth <stoty@apache.org> (cherry picked from commit 05bd810)

Navigation Menu

Uh oh!

HBASE-28972 Limit the number of retries in FanOutOneBlockAsyncDFSOutp… - #6453

HBASE-28972 Limit the number of retries in FanOutOneBlockAsyncDFSOutp…#6453
Apache9 merged 2 commits into
apache:masterfrom
Apache9:HBASE-28972

Apache9 commented Nov 8, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

stotyNov 11, 2024

Uh oh!

Apache9Nov 11, 2024

Uh oh!

stoty left a comment

Uh oh!

Apache-HBase commented Nov 11, 2024

Uh oh!

Apache-HBase commented Nov 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Apache9 commented Nov 8, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

stotyNov 11, 2024

Choose a reason for hiding this comment

Uh oh!

Apache9Nov 11, 2024

Choose a reason for hiding this comment

Uh oh!

stoty left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Nov 11, 2024

Uh oh!

Apache-HBase commented Nov 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants