HBASE-28634 Fix FuzzyRowFilter may not return data on reverse scans by PDavid · Pull Request #6482 · apache/hbase

PDavid · 2024-11-20T08:54:52Z

This is the backport of #6457 to branch-2

Changes:

Reproduced the issue with a mini cluster test.
Corrected reverse unit tests in TestFuzzyRowFilter as some expectations were not correct.
Fixed hint returned by FuzzyRowFilter.getNextForFuzzyRule() in the reverse case:
- Before we only trimmed the trailing zeros from the hint in the forward scan case. From now on we also do this in the reverse case.
  - Also extracted PrefixFilter.increaseLastNonMaxByte() method to PrivateCellUtil so that it can be reused in FuzzyRowFilter.
- When the hint should contain a 0xFF. As a start, when we have a reverse scan, we not only need trailing 0xff's instead of trailing 0x00's, but it seems we always need 0xff's instead of the 0x00's.
Made some small improvements to FuzzyRowFilter which IntelliJ IDEA suggested (final fields, simplifications).

Changes: - Reproduced the issue with a mini cluster test. - Corrected reverse unit tests in TestFuzzyRowFilter as some expectations were not correct. - Fixed hint returned by FuzzyRowFilter.getNextForFuzzyRule() in the reverse case: - Before we only trimmed the trailing zeros from the hint in the forward scan case. From now on we also do this in the reverse case. - Also extracted PrefixFilter.increaseLastNonMaxByte() method to PrivateCellUtil so that it can be reused in FuzzyRowFilter. - When the hint should contain a 0xFF. As a start, when we have a reverse scan, we not only need trailing 0xff's instead of trailing 0x00's, but it seems we always need 0xff's instead of the 0x00's. - Made some small improvements to FuzzyRowFilter which IntelliJ IDEA suggested (final fields, simplifications).

Apache-HBase · 2024-11-20T13:06:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 0s		Docker mode activated.
-1 ❌	docker	0m 8s		Docker failed to build run-specific yetus/hbase:tp-16084}.

Subsystem	Report/Notes
GITHUB PR	#6482
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6482/2/console
versions	git=2.25.1
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-20T13:49:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 49s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 57s		branch-2 passed
+1 💚	compile	4m 18s		branch-2 passed
+1 💚	checkstyle	1m 15s		branch-2 passed
+1 💚	spotbugs	2m 58s		branch-2 passed
+1 💚	spotless	0m 46s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 0s		the patch passed
+1 💚	compile	4m 16s		the patch passed
+1 💚	javac	4m 16s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 11s		the patch passed
+1 💚	spotbugs	3m 22s		the patch passed
+1 💚	hadoopcheck	15m 0s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚	spotless	0m 45s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 32s		The patch does not generate ASF License warnings.
		43m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6482/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6482
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux b8bbd94db195 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `c563552`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6482/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-20T14:00:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 44s		branch-2 passed
+1 💚	compile	1m 58s		branch-2 passed
+1 💚	javadoc	1m 14s		branch-2 passed
+1 💚	shadedjars	6m 38s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 16s		the patch passed
+1 💚	compile	2m 5s		the patch passed
+1 💚	javac	2m 5s		the patch passed
+1 💚	javadoc	1m 18s		the patch passed
+1 💚	shadedjars	6m 12s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	2m 13s		hbase-common in the patch passed.
+1 💚	unit	8m 17s		hbase-client in the patch passed.
-1 ❌	unit	12m 29s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		54m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6482/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6482
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 0df62c57c32e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `c563552`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6482/2/testReport/
Max. process+thread count	1825 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6482/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-20T17:29:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 47s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 27s		branch-2 passed
+1 💚	compile	1m 22s		branch-2 passed
+1 💚	javadoc	0m 58s		branch-2 passed
+1 💚	shadedjars	4m 45s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 22s		the patch passed
+1 💚	compile	1m 23s		the patch passed
+1 💚	javac	1m 23s		the patch passed
+1 💚	javadoc	0m 59s		the patch passed
+1 💚	shadedjars	4m 47s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	2m 3s		hbase-common in the patch passed.
+1 💚	unit	8m 3s		hbase-client in the patch passed.
-1 ❌	unit	227m 57s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		263m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6482/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6482
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux c0c8232f3aa0 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `c563552`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6482/2/testReport/
Max. process+thread count	4186 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6482/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

PDavid · 2024-11-25T07:10:12Z

Sorry, I closed this by accident 😅

…6482) Signed-off-by: Istvan Toth <stoty@apache.org> (cherry picked from commit 20e510f)

…pache#6482) Signed-off-by: Istvan Toth <stoty@apache.org>

…pache#6482) Signed-off-by: Istvan Toth <stoty@apache.org> (cherry picked from commit 20e510f)

PDavid mentioned this pull request Nov 20, 2024
HBASE-28634 Fix FuzzyRowFilter may not return data on reverse scans #6457
Merged

This comment has been minimized.
Sign in to view

PDavid force-pushed the HBASE-28634-FuzzyRowFilter-reverse-no-data-branch-2 branch from 01cff22 to c563552Compare November 20, 2024 12:58

PDavid marked this pull request as ready for review November 22, 2024 08:26

PDavid closed this Nov 25, 2024

PDavid deleted the HBASE-28634-FuzzyRowFilter-reverse-no-data-branch-2 branch November 25, 2024 07:09

PDavid restored the HBASE-28634-FuzzyRowFilter-reverse-no-data-branch-2 branch November 25, 2024 07:09

PDavid reopened this Nov 25, 2024

stoty merged commit 20e510f into apache:branch-2Nov 25, 2024

PDavid deleted the HBASE-28634-FuzzyRowFilter-reverse-no-data-branch-2 branch November 25, 2024 09:03

stoty pushed a commit that referenced this pull request Nov 25, 2024
HBASE-28634Fix FuzzyRowFilter may not return data on reverse scans (#…
3ab466e
…6482) Signed-off-by: Istvan Toth <stoty@apache.org> (cherry picked from commit 20e510f)

stoty pushed a commit that referenced this pull request Nov 25, 2024
HBASE-28634Fix FuzzyRowFilter may not return data on reverse scans (#…
af90898
…6482) Signed-off-by: Istvan Toth <stoty@apache.org> (cherry picked from commit 20e510f)

mokai87 pushed a commit to mokai87/hbase that referenced this pull request Aug 7, 2025
HBASE-28634 Fix FuzzyRowFilter may not return data on reverse scans (a…
21cfcb5
…pache#6482) Signed-off-by: Istvan Toth <stoty@apache.org>

sanjeet006py pushed a commit to sanjeet006py/hbase that referenced this pull request Sep 26, 2025
HBASE-28634 Fix FuzzyRowFilter may not return data on reverse scans (a…
5166c8f
…pache#6482) Signed-off-by: Istvan Toth <stoty@apache.org> (cherry picked from commit 20e510f)

Navigation Menu

Uh oh!

HBASE-28634 Fix FuzzyRowFilter may not return data on reverse scans - #6482

HBASE-28634 Fix FuzzyRowFilter may not return data on reverse scans#6482
stoty merged 1 commit into
apache:branch-2from
PDavid:HBASE-28634-FuzzyRowFilter-reverse-no-data-branch-2

PDavid commented Nov 20, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Nov 20, 2024

Uh oh!

Apache-HBase commented Nov 20, 2024

Uh oh!

Apache-HBase commented Nov 20, 2024

Uh oh!

Apache-HBase commented Nov 20, 2024

Uh oh!

PDavid commented Nov 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

PDavid commented Nov 20, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Nov 20, 2024

Uh oh!

Apache-HBase commented Nov 20, 2024

Uh oh!

Apache-HBase commented Nov 20, 2024

Uh oh!

Apache-HBase commented Nov 20, 2024

Uh oh!

PDavid commented Nov 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants