Skip to content

Hbase-22027 - #649

Merged
saintstack merged 1 commit into
apache:branch-2from
srdo:HBASE-22027-2.3
Sep 21, 2019
Merged

Hbase-22027#649
saintstack merged 1 commit into
apache:branch-2from
srdo:HBASE-22027-2.3

Conversation

@srdo

@srdosrdo commented Sep 20, 2019

Copy link
Copy Markdown
Contributor

…tTokenUtil, and move ClientTokenUtil to hbase-client

This is a backport of #361 to 2.x

The following changes were made to the diff from that PR:

  • There is no obtainToken(AsyncConnection) on TokenUtil, so removed that variant from ClientTokenUtil.
  • Made obtainToken(Connection) public, as it is used in SecureBulkLoadManager.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 40sDocker mode activated.
_ Prechecks _
💚dupname0m 1sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 4 new or modified test files.
_ branch-2 Compile Tests _
💙mvndep0m 16sMaven dependency ordering for branch
💚mvninstall5m 15sbranch-2 passed
💚compile1m 22sbranch-2 passed
💚checkstyle1m 54sbranch-2 passed
💚shadedjars4m 15sbranch has no errors when building our shaded downstream artifacts.
💚javadoc1m 0sbranch-2 passed
💙spotbugs3m 9sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 22sbranch-2 passed
_ Patch Compile Tests _
💙mvndep0m 15sMaven dependency ordering for patch
💚mvninstall4m 50sthe patch passed
💚compile1m 24sthe patch passed
💚javac1m 24sthe patch passed
💔checkstyle0m 36shbase-client: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
💚checkstyle1m 16shbase-server: The patch generated 0 new + 5 unchanged - 4 fixed = 5 total (was 9)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 9spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck15m 7sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 59sthe patch passed
💚findbugs5m 29sthe patch passed
_ Other Tests _
💚unit2m 41shbase-client in the patch passed.
💚unit166m 27shbase-server in the patch passed.
💚asflicense0m 56sThe patch does not generate ASF License warnings.
229m 50s
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-649/1/artifact/out/Dockerfile
GITHUB PR#649
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 2f0253900861 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-649/out/precommit/personality/provided.sh
git revisionbranch-2 / 63593d6
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-649/1/artifact/out/diff-checkstyle-hbase-client.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-649/1/testReport/
Max. process+thread count4891 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-649/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

…tTokenUtil, and move ClientTokenUtil to hbase-client
@saintstack
saintstack merged commit 047bbfd into apache:branch-2Sep 21, 2019
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
💙reexec0m 38sDocker mode activated.
_ Prechecks _
💚dupname0m 1sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 4 new or modified test files.
_ branch-2 Compile Tests _
💙mvndep0m 14sMaven dependency ordering for branch
💚mvninstall5m 25sbranch-2 passed
💚compile1m 26sbranch-2 passed
💚checkstyle1m 56sbranch-2 passed
💚shadedjars4m 12sbranch has no errors when building our shaded downstream artifacts.
💚javadoc1m 1sbranch-2 passed
💙spotbugs3m 30sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 43sbranch-2 passed
_ Patch Compile Tests _
💙mvndep0m 16sMaven dependency ordering for patch
💚mvninstall5m 57sthe patch passed
💚compile1m 28sthe patch passed
💚javac1m 28sthe patch passed
💚checkstyle0m 38sThe patch passed checkstyle in hbase-client
💚checkstyle1m 23shbase-server: The patch generated 0 new + 5 unchanged - 4 fixed = 5 total (was 9)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars5m 18spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck18m 13sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc1m 4sthe patch passed
💚findbugs5m 24sthe patch passed
_ Other Tests _
💚unit2m 35shbase-client in the patch passed.
💚unit161m 52shbase-server in the patch passed.
💚asflicense1m 4sThe patch does not generate ASF License warnings.
232m 37s
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-649/2/artifact/out/Dockerfile
GITHUB PR#649
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 09ca19c685fb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-649/out/precommit/personality/provided.sh
git revisionbranch-2 / f1d3b54
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-649/2/testReport/
Max. process+thread count4278 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-649/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
…tTokenUtil, and move ClientTokenUtil to hbase-client (apache#649)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@srdo@Apache-HBase@saintstack