Skip to content

HBASE-20663 Make sure coprocessor upgrade anchor ID is not duplicated in HBase book - #6493

Merged
Apache9 merged 2 commits into
apache:masterfrom
PDavid:HBASE-20663-book-coproc-upgrade-dupl-anchor
Dec 8, 2024
Merged

HBASE-20663 Make sure coprocessor upgrade anchor ID is not duplicated in HBase book#6493
Apache9 merged 2 commits into
apache:masterfrom
PDavid:HBASE-20663-book-coproc-upgrade-dupl-anchor

Conversation

@PDavid

@PDavidPDavid commented Nov 25, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

  • Renamed the anchor ID under "Changes of Note!" section.
  • Added a link from this section to the other "Upgrading Coprocessors to 2.0" section.
  • Fixed the anchor ID of "BucketCache Deploy Modes". This way a broken link is now fixed.

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@PDavid
PDavid marked this pull request as ready for review November 25, 2024 10:09
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@NihalJain

NihalJain commented Nov 29, 2024

Copy link
Copy Markdown
Contributor

+1, LGTM

stoty
stoty suggested changes Dec 5, 2024
View reviewed changes
Comment threadsrc/main/asciidoc/_chapters/upgrading.adoc
@PDavid
PDavidforce-pushed the HBASE-20663-book-coproc-upgrade-dupl-anchor branch from 4ace639 to 2549609CompareDecember 5, 2024 08:00
@Apache-HBase

This comment has been minimized.

Sign in to view
@PDavid
HBASE-20663 Made sure coprocessor upgrade anchor ID is not duplicated…
2cc34df
… in HBase book
- Renamed the anchor ID under "Changes of Note!" section.
- Added a link from this section to the other "Upgrading Coprocessors to 2.0" section.
- Also fixed the grammar in one of the sentences of the "Coprocessor APIs have changed in HBase 2.0+" section.
@PDavid
HBASE-20663 Fixed bc.deploy.modes broken anchor ID
fc1da60
Fixed the anchor ID of "BucketCache Deploy Modes". This way a broken link is now fixed.
@PDavid
PDavidforce-pushed the HBASE-20663-book-coproc-upgrade-dupl-anchor branch from 2549609 to fc1da60CompareDecember 5, 2024 08:12
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

Apache-HBase commented Dec 5, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 25sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
1m 10s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6493/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6493
Optional Tests
unameLinux e66a0cebc56d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / fc1da60
Max. process+thread count40 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6493/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 5, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall2m 37smaster passed
+0 🆗refguide1m 54sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotless0m 40sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 37sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+0 🆗refguide1m 52spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotless0m 40spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
12m 23s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6493/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6493
Optional Testsdupname asflicense codespell detsecrets refguide spotless
unameLinux ac868098622d 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / fc1da60
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-6493/4/yetus-general-check/output/branch-site/book.html
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-6493/4/yetus-general-check/output/patch-site/book.html
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6493/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@PDavid
PDavid requested a review from stotyDecember 5, 2024 14:19
stoty
stoty approved these changes Dec 6, 2024
View reviewed changes

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@Apache9Apache9 changed the title HBASE-20663 Made sure coprocessor upgrade anchor ID is not duplicated in HBase bookHBASE-20663 Make sure coprocessor upgrade anchor ID is not duplicated in HBase bookDec 8, 2024
@Apache9
Apache9 merged commit 1bdbb8b into apache:masterDec 8, 2024
@PDavid
PDavid deleted the HBASE-20663-book-coproc-upgrade-dupl-anchor branch December 9, 2024 07:04
gvprathyusha6 pushed a commit to gvprathyusha6/hbase that referenced this pull request Dec 19, 2024
@PDavidPrathyusha Garre
HBASE-20663 Make sure coprocessor upgrade anchor ID is not duplicated…
70f150f
… in HBase book (apache#6493)
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Istvan Toth <stoty@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NihalJainNihalJainNihalJain approved these changes
@Apache9Apache9Apache9 approved these changes
+1 more reviewer
@stotystotystoty approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PDavid@Apache-HBase@NihalJain@stoty@Apache9