Skip to content

HBASE-28627 REST ScannerModel doesn't support includeStartRow/include… - #6494

Merged
stoty merged 1 commit into
apache:branch-2from
chandrasekhar-188k:br_HBASE-28627_branch-2
Feb 18, 2025
Merged

HBASE-28627 REST ScannerModel doesn't support includeStartRow/include…#6494
stoty merged 1 commit into
apache:branch-2from
chandrasekhar-188k:br_HBASE-28627_branch-2

Conversation

@chandrasekhar-188k

@chandrasekhar-188kchandrasekhar-188k commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@chandrasekhar-188kchandrasekhar-188k mentioned this pull request Nov 26, 2024
Merged
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

Apache-HBase commented Jan 19, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 55sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 4sbranch-2 passed
+1 💚compile0m 20sbranch-2 passed
+1 💚javadoc0m 15sbranch-2 passed
+1 💚shadedjars6m 6sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 1sthe patch passed
+1 💚compile0m 20sthe patch passed
+1 💚javac0m 20sthe patch passed
+1 💚javadoc0m 14sthe patch passed
+1 💚shadedjars6m 5spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit3m 34shbase-rest in the patch passed.
25m 59s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6494
Optional Testsjavac javadoc unit compile shadedjars
unameLinux a0316614e186 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 31848a3
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/testReport/
Max. process+thread count1882 (vs. ulimit of 30000)
modulesC: hbase-rest U: hbase-rest
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 19, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec2m 23sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 36sbranch-2 passed
+1 💚compile0m 32sbranch-2 passed
+1 💚javadoc0m 21sbranch-2 passed
+1 💚shadedjars5m 58sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 15sthe patch passed
+1 💚compile0m 30sthe patch passed
+1 💚javac0m 30sthe patch passed
+1 💚javadoc0m 24sthe patch passed
+1 💚shadedjars5m 55spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit4m 33shbase-rest in the patch passed.
29m 38s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6494
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 2d1479538ea6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 31848a3
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/testReport/
Max. process+thread count1795 (vs. ulimit of 30000)
modulesC: hbase-rest U: hbase-rest
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 19, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec2m 22sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 31sbranch-2 passed
+1 💚compile0m 34sbranch-2 passed
+1 💚javadoc0m 20sbranch-2 passed
+1 💚shadedjars7m 4sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 59sthe patch passed
+1 💚compile0m 25sthe patch passed
+1 💚javac0m 25sthe patch passed
+1 💚javadoc0m 18sthe patch passed
+1 💚shadedjars7m 23spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit4m 17shbase-rest in the patch passed.
32m 26s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6494
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 898517a057de 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 31848a3
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/testReport/
Max. process+thread count1766 (vs. ulimit of 30000)
modulesC: hbase-rest U: hbase-rest
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 19, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗buf0m 0sbuf was not available.
+0 🆗buf0m 0sbuf was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+1 💚mvninstall3m 44sbranch-2 passed
+1 💚compile0m 46sbranch-2 passed
+1 💚checkstyle0m 16sbranch-2 passed
+1 💚spotbugs0m 49sbranch-2 passed
+1 💚spotless0m 47sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 10sthe patch passed
+1 💚compile0m 38sthe patch passed
+1 💚cc0m 38sthe patch passed
+1 💚javac0m 39sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 13s/results-checkstyle-hbase-rest.txthbase-rest: The patch generated 2 new + 23 unchanged - 0 fixed = 25 total (was 23)
+1 💚spotbugs0m 54sthe patch passed
+1 💚hadoopcheck17m 31sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚hbaseprotoc0m 19sthe patch passed
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
33m 15s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6494
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
unameLinux 4b6d5f5b3492 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 31848a3
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-rest U: hbase-rest
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6494/6/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@chandrasekhar-188k

chandrasekhar-188k commented Feb 18, 2025

Copy link
Copy Markdown
ContributorAuthor

@stoty
pls help to review this PR.

@stoty

stoty commented Feb 18, 2025

Copy link
Copy Markdown
Contributor

This is the same as the master patch, but you've fixed it to apply it cleanly to branch-2 ?

Is that correct @chandrasekhar-188k ?

@stoty

stoty commented Feb 18, 2025

Copy link
Copy Markdown
Contributor

I can see this already includes HE_EQUALS_USE_HASHCODE.

stoty
stoty approved these changes Feb 18, 2025
View reviewed changes

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@stoty
stoty merged commit e7b48e4 into apache:branch-2Feb 18, 2025
stoty pushed a commit that referenced this pull request Feb 18, 2025
@chandrasekhar-188k@stoty
HBASE-28627REST ScannerModel doesn't support includeStartRow/include…
e383a61
…StopRow (#6494)
includes HBASE-29125 and JSON addendum
Signed-off-by: Istvan Toth <stoty@apache.org>
(cherry picked from commit e7b48e4)
stoty pushed a commit that referenced this pull request Feb 18, 2025
@chandrasekhar-188k@stoty
HBASE-28627REST ScannerModel doesn't support includeStartRow/include…
ea3c019
…StopRow (#6494)
includes HBASE-29125 and JSON addendum
Signed-off-by: Istvan Toth <stoty@apache.org>
(cherry picked from commit e7b48e4)
mokai87 pushed a commit to mokai87/hbase that referenced this pull request Aug 7, 2025
@chandrasekhar-188k@mokai87
HBASE-28627 REST ScannerModel doesn't support includeStartRow/include…
4ee2c8d
…StopRow (apache#6494)
includes HBASE-29125 and JSON addendum
Signed-off-by: Istvan Toth <stoty@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@stotystotystoty approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chandrasekhar-188k@Apache-HBase@stoty