Skip to content

HBASE-29004 Optimize unnecessary type castings in Scan and Get setter methods - #6500

Merged
Apache9 merged 1 commit into
apache:masterfrom
chandrasekhar-188k:br_HBASE-29004
Jan 18, 2025
Merged

HBASE-29004 Optimize unnecessary type castings in Scan and Get setter methods#6500
Apache9 merged 1 commit into
apache:masterfrom
chandrasekhar-188k:br_HBASE-29004

Conversation

@chandrasekhar-188k

Copy link
Copy Markdown
Contributor

… methods

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 0smaster passed
+1 💚compile0m 20smaster passed
+1 💚javadoc0m 17smaster passed
+1 💚shadedjars5m 35sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 49sthe patch passed
+1 💚compile0m 19sthe patch passed
+1 💚javac0m 19sthe patch passed
+1 💚javadoc0m 15sthe patch passed
+1 💚shadedjars5m 37spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit1m 35shbase-client in the patch passed.
21m 21s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6500/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6500
Optional Testsjavac javadoc unit compile shadedjars
unameLinux c65feef58eb4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 247873c
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6500/2/testReport/
Max. process+thread count323 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6500/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 39sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall2m 49smaster passed
+1 💚compile0m 44smaster passed
+1 💚checkstyle0m 16smaster passed
+1 💚spotbugs0m 41smaster passed
+1 💚spotless0m 41sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 35sthe patch passed
+1 💚compile0m 43sthe patch passed
+1 💚javac0m 43sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 16sthe patch passed
+1 💚spotbugs0m 46sthe patch passed
+1 💚hadoopcheck9m 26sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 40spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
26m 29s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6500/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6500
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux b76030f99377 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 247873c
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6500/2/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@pankaj72981pankaj72981 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@Apache9

Copy link
Copy Markdown
Contributor

Please open PRs for other branches?

We may have different methods in Scan and Get in other branches.

Thanks.

@chandrasekhar-188k

Copy link
Copy Markdown
ContributorAuthor

Please open PRs for other branches?

We may have different methods in Scan and Get in other branches.

Thanks.

ok

@chandrasekhar-188k

Copy link
Copy Markdown
ContributorAuthor

Please open PRs for other branches?
We may have different methods in Scan and Get in other branches.
Thanks.

ok

I have raised backport PRs for other branches, Please review

@Apache9
Apache9 merged commit 6f8db78 into apache:masterJan 18, 2025
mnpoonia pushed a commit to mnpoonia/hbase that referenced this pull request Jan 24, 2025
… methods. (apache#6500)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
HBASE-28836 Parallize the file archival to improve the split times
mnpoonia pushed a commit to mnpoonia/hbase that referenced this pull request Jan 24, 2025
… methods. (apache#6500)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
HBASE-28836 Parallize the file archival to improve the split times
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@chandrasekhar-188k@Apache-HBase@Apache9@pankaj72981