Skip to content

HBASE-28970 Get asyncfs working with custom SASL mechanisms - #6507

Merged
stoty merged 3 commits into
apache:masterfrom
stoty:HBASE-28970
Jan 9, 2025
Merged

HBASE-28970 Get asyncfs working with custom SASL mechanisms#6507
stoty merged 3 commits into
apache:masterfrom
stoty:HBASE-28970

Conversation

@stoty

@stotystoty commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@stoty
stoty marked this pull request as draft December 2, 2024 21:27
@stoty

stoty commented Dec 2, 2024

Copy link
Copy Markdown
ContributorAuthor

This should be good, but I'm waiting for the Hadoop side fixes before landing this one.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 41sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 34smaster passed
+1 💚compile0m 15smaster passed
+1 💚javadoc0m 13smaster passed
+1 💚shadedjars4m 52sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 38sthe patch passed
+1 💚compile0m 17sthe patch passed
+1 💚javac0m 17sthe patch passed
+1 💚javadoc0m 13sthe patch passed
+1 💚shadedjars4m 49spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit1m 21shbase-asyncfs in the patch passed.
18m 43s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6507/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6507
Optional Testsjavac javadoc unit compile shadedjars
unameLinux e2c3549551f0 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 56a7d83
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6507/3/testReport/
Max. process+thread count652 (vs. ulimit of 30000)
modulesC: hbase-asyncfs U: hbase-asyncfs
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6507/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall2m 51smaster passed
+1 💚compile0m 19smaster passed
+1 💚checkstyle0m 7smaster passed
+1 💚spotbugs0m 21smaster passed
+1 💚spotless0m 41sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 50sthe patch passed
+1 💚compile0m 19sthe patch passed
+1 💚javac0m 19sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 8sthe patch passed
+1 💚spotbugs0m 29sthe patch passed
+1 💚hadoopcheck10m 40sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 41spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 8sThe patch does not generate ASF License warnings.
26m 45s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6507/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6507
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux dffd481fbb01 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 56a7d83
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-asyncfs U: hbase-asyncfs
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6507/3/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@stoty
stoty marked this pull request as ready for review December 9, 2024 14:38
@stoty

stoty commented Dec 9, 2024

Copy link
Copy Markdown
ContributorAuthor

The standard HBase SASL code already works like this.

@anmolnaranmolnar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question.

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any real use cases?

IIRC we have done the same fix in hbase's own rpc implementation, but I can not recall the details...

@stoty

stoty commented Jan 9, 2025

Copy link
Copy Markdown
ContributorAuthor

I'm not sure about the HBase implementation, but I plan to review it for this issue soon.

As for the real world use case, this has come up when running Hadoop+HBase with the SCRAM mechanism lifted from Kafka.
(The patches necessary for working with SCRAM are only present in Hadoop HEAD)

@stotystoty left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to submit my pending responses to Andor

@stoty
stoty merged commit 9036d88 into apache:masterJan 9, 2025
stoty added a commit that referenced this pull request Jan 9, 2025
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 9036d88)
stoty added a commit to stoty/hbase that referenced this pull request Jan 9, 2025
ragarkar pushed a commit to ragarkar/hbase that referenced this pull request Jan 13, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@stoty@Apache-HBase@Apache9@anmolnar