HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 by PDavid · Pull Request #6527 · apache/hbase

PDavid · 2024-12-10T12:05:57Z

This is the backport of #6490 for branch-3.

As these are not present anymore in v4.

Reason: to make sure that they are the same size (this under thrift was smaller).

This is the latest non-vulnerable version.

- Navbars now require a container within (to drastically simplify spacing requirements and CSS required). - The .active class can no longer be applied to .nav-items, it must be applied directly on .nav-links.

Data attributes for all Bootstrap JavaScript plugins are now namespaced to help distinguish Bootstrap functionality from third parties and your own code. For example, we use data-bs-toggle instead of data-toggle.

Breaking change in Bootstrap 5: Dropped form-specific layout classes for our grid system. Use our grid and utilities instead of .form-group, .form-row, or .form-inline.

to make the UI coloring look similar to what we had before.

to make sure the current active navbar link is highlighted appropriately.

(used by the "Regions in Transition" section on master status page) so that the paginator links are styled and displayed properly.

Before the tab content has its own bottom border and table row also had its own bottom border. This resulted in having two lines in all table boundaries. Fix is to remove the bottom border of the table row.

Make sure background color is visible in tables (Tasks) where alert class is used.

So that buttons and textfields are displayed properly. Also removes unneeded inline styles.

Apache-HBase · 2024-12-11T15:04:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	jshint	0m 0s		jshint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-3 Compile Tests _
+0 🆗	mvndep	0m 7s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 42s		branch-3 passed
+1 💚	compile	7m 16s		branch-3 passed
+1 💚	checkstyle	1m 2s		branch-3 passed
+1 💚	spotbugs	10m 34s		branch-3 passed
+1 💚	spotless	0m 39s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 35s		the patch passed
+1 💚	compile	7m 16s		the patch passed
+1 💚	javac	7m 16s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 3s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	spotbugs	11m 0s		the patch passed
+1 💚	hadoopcheck	9m 29s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 39s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 59s		The patch does not generate ASF License warnings.
		63m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6527/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6527
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless jshint shellcheck shelldocs
uname	Linux e475e2b53475 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-3 / `9f2e650`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	191 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6527/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-11T22:46:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 54s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-3 Compile Tests _
+0 🆗	mvndep	0m 9s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 45s		branch-3 passed
+1 💚	compile	1m 51s		branch-3 passed
+1 💚	javadoc	3m 30s		branch-3 passed
+1 💚	shadedjars	4m 51s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 38s		the patch passed
+1 💚	compile	1m 55s		the patch passed
+1 💚	javac	1m 55s		the patch passed
+1 💚	javadoc	3m 34s		the patch passed
+1 💚	shadedjars	4m 47s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	471m 28s	/patch-unit-root.txt	root in the patch failed.
		507m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6527/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6527
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 330f9f5ba5b8 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-3 / `9f2e650`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6527/2/testReport/
Max. process+thread count	5563 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6527/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

NihalJain

Clean backport of master! Thanks @PDavid !

PDavid added 18 commits December 10, 2024 12:52

HBASE-28832 Removed bootstrap-theme.min.css and Glyphicons icon font
ad3e27a
As these are not present anymore in v4.

HBASE-28832 Upgrade to Bootstrap 4
1b74adc

HBASE-28832 Migrated Log Level forms
309ae85

HBASE-28832 Migrated REST web UI pages
c107c32

HBASE-28832 Migrated canary status page navbar
3b5a5f2

HBASE-28832 Migrated Thrift UI pages
6690c77

HBASE-28832 Replaced hbase_logo_small.png with hbase-server one
1e220ec
Reason: to make sure that they are the same size (this under thrift was smaller).

HBASE-28832 Upgraded Bootstrap to 5.3.3
1bda17d
This is the latest non-vulnerable version.

HBASE-28832 Migrated navbars
942d72e
- Navbars now require a container within (to drastically simplify spacing requirements and CSS required). - The .active class can no longer be applied to .nav-items, it must be applied directly on .nav-links.

HBASE-28832 Migrated data attributes
91a11c3
Data attributes for all Bootstrap JavaScript plugins are now namespaced to help distinguish Bootstrap functionality from third parties and your own code. For example, we use data-bs-toggle instead of data-toggle.

HBASE-28832 Migrated inline forms - Log levels, table.jsp
385495b
Breaking change in Bootstrap 5: Dropped form-specific layout classes for our grid system. Use our grid and utilities instead of .form-group, .form-row, or .form-inline.

HBASE-28832 Fixed checkstyle warnings
ae47e78

HBASE-28832 Preserve original HBase UI colors
e35b7bf
to make the UI coloring look similar to what we had before.

HBASE-28832 Restore active navbar link background-color
c186ef2
to make sure the current active navbar link is highlighted appropriately.

HBASE-28832 Migrated pagination in jqSpager.js
fc69ef7
(used by the "Regions in Transition" section on master status page) so that the paginator links are styled and displayed properly.

HBASE-28832 Avoid double bottom borders with tables in tab contents
57b7c30
Before the tab content has its own bottom border and table row also had its own bottom border. This resulted in having two lines in all table boundaries. Fix is to remove the bottom border of the table row.

HBASE-28832 Fixed Tasks table row background colors were not visible
22e7440
Make sure background color is visible in tables (Tasks) where alert class is used.

HBASE-28832 Added missing favicon for Thrift UI
86220da

This comment has been minimized.
Sign in to view

PDavid marked this pull request as ready for review December 10, 2024 14:17

PDavid mentioned this pull request Dec 10, 2024
HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6490
Merged

PDavid added 2 commits December 11, 2024 14:45

HBASE-28832 Fixed unstyled pager link in jqSpager.js
1e94cde

HBASE-28832 Styled Actions forms on Table Details page
9f2e650
So that buttons and textfields are displayed properly. Also removes unneeded inline styles.

NihalJain approved these changes Dec 24, 2024
View reviewed changes

NihalJain merged commit 5977f8e into apache:branch-3Dec 24, 2024

PDavid deleted the HBASE-28832-bootstrap-upgrade-5-branch-3 branch February 28, 2025 13:55

Navigation Menu

Uh oh!

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 - #6527

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3#6527
NihalJain merged 20 commits into
apache:branch-3from
PDavid:HBASE-28832-bootstrap-upgrade-5-branch-3

PDavid commented Dec 10, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Dec 11, 2024

Uh oh!

Apache-HBase commented Dec 11, 2024

Uh oh!

NihalJain left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

PDavid commented Dec 10, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Dec 11, 2024

Uh oh!

Apache-HBase commented Dec 11, 2024

Uh oh!

NihalJain left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants