Skip to content

Backport "HBASE-28600 Enable setting blockcache on-heap sizes in bytes (#6422)" to branch-2 - #6544

Merged
apurtell merged 2 commits into
apache:branch-2from
jinhyukify:HBASE-28600-branch-2
Jan 14, 2025
Merged

Backport "HBASE-28600 Enable setting blockcache on-heap sizes in bytes (#6422)" to branch-2#6544
apurtell merged 2 commits into
apache:branch-2from
jinhyukify:HBASE-28600-branch-2

Conversation

@jinhyukify

@jinhyukifyjinhyukify commented Dec 15, 2024

Copy link
Copy Markdown
Contributor

Tested same result and logs in this comment

I introduced the StorageSize and StorageUnit classes from Hadoop 3.x in b20c42c
Another approach could have been implementing similar methods in our Size class we are already using to parse storage sizes.
However, since Hadoop 3 already provides a nice way to parse storage sizes, I thought it's also okay to backport these related classes to HBase 2.x and use them directly.

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@ndimiduk

ndimiduk commented Dec 20, 2024

Copy link
Copy Markdown
Member

Ah okay. Yeah, faire enough. Thanks @jinhyukify . Let me re-run the build bot.

@Apache-HBase

Apache-HBase commented Dec 20, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 59sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall4m 26sbranch-2 passed
+1 💚compile4m 14sbranch-2 passed
+1 💚checkstyle0m 56sbranch-2 passed
+1 💚spotbugs2m 19sbranch-2 passed
+1 💚spotless0m 48sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 15sthe patch passed
+1 💚compile4m 23sthe patch passed
-0 ⚠️javac0m 47s/results-compile-javac-hbase-common.txthbase-common generated 1 new + 95 unchanged - 0 fixed = 96 total (was 95)
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 56sthe patch passed
+1 💚xmllint0m 0sNo new issues.
+1 💚spotbugs2m 31sthe patch passed
+1 💚hadoopcheck23m 37sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless1m 18spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 34sThe patch does not generate ASF License warnings.
53m 44s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6544/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6544
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint
unameLinux a6fb0cb8f6c9 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / c1bdeb8
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count76 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6544/2/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 20, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 41sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall2m 10sbranch-2 passed
+1 💚compile0m 55sbranch-2 passed
+1 💚javadoc0m 39sbranch-2 passed
+1 💚shadedjars4m 20sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 7sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚javadoc0m 40sthe patch passed
+1 💚shadedjars4m 17spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit1m 49shbase-common in the patch passed.
+1 💚unit200m 55shbase-server in the patch passed.
225m 1s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6544/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6544
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 45c2ee4fbecb 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / c1bdeb8
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6544/2/testReport/
Max. process+thread count3809 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6544/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 20, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 42sMaven dependency ordering for branch
+1 💚mvninstall3m 35sbranch-2 passed
+1 💚compile1m 12sbranch-2 passed
+1 💚javadoc0m 41sbranch-2 passed
+1 💚shadedjars6m 27sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 8sthe patch passed
+1 💚compile1m 7sthe patch passed
+1 💚javac1m 7sthe patch passed
+1 💚javadoc0m 40sthe patch passed
+1 💚shadedjars6m 24spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit2m 19shbase-common in the patch passed.
+1 💚unit193m 29shbase-server in the patch passed.
225m 23s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6544/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6544
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 6a00684d5be1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / c1bdeb8
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6544/2/testReport/
Max. process+thread count4235 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6544/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 20, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 59sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for branch
+1 💚mvninstall4m 24sbranch-2 passed
+1 💚compile1m 43sbranch-2 passed
+1 💚javadoc0m 54sbranch-2 passed
+1 💚shadedjars6m 15sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 7sthe patch passed
+1 💚compile1m 42sthe patch passed
+1 💚javac1m 42sthe patch passed
+1 💚javadoc0m 56sthe patch passed
+1 💚shadedjars6m 19spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit2m 27shbase-common in the patch passed.
+1 💚unit190m 47shbase-server in the patch passed.
225m 31s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6544/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6544
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 61771806552c 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / c1bdeb8
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6544/2/testReport/
Max. process+thread count4465 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6544/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
apurtell merged commit c816083 into apache:branch-2Jan 14, 2025
mokai87 pushed a commit to mokai87/hbase that referenced this pull request Aug 7, 2025
@jinhyukify@mokai87
Backport "HBASE-28600 Enable setting blockcache on-heap sizes in bytes (
bd1fc1f
apache#6422)" to branch-2 (apache#6544)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apurtellapurtellapurtell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jinhyukify@Apache-HBase@ndimiduk@apurtell