Skip to content

Backport" HBASE-28600 Enable setting blockcache on-heap sizes in bytes (#6422)" to branch-2.6 - #6545

Merged
apurtell merged 2 commits into
apache:branch-2.6from
jinhyukify:HBASE-28600-branch-2.6
Jan 14, 2025
Merged

Backport" HBASE-28600 Enable setting blockcache on-heap sizes in bytes (#6422)" to branch-2.6#6545
apurtell merged 2 commits into
apache:branch-2.6from
jinhyukify:HBASE-28600-branch-2.6

Conversation

@jinhyukify

Copy link
Copy Markdown
Contributor

Tested same result and logs in this comment

I introduced the StorageSize and StorageUnit classes from Hadoop 3.x in 82eeb50
Another approach could have been implementing similar methods in our Size class we are already using to parse storage sizes.
However, since Hadoop 3 already provides a nice way to parse storage sizes, I thought it's also okay to backport these related classes to HBase 2.x and use them directly.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 52sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 16sbranch-2.6 passed
+1 💚compile3m 33sbranch-2.6 passed
+1 💚checkstyle0m 53sbranch-2.6 passed
+1 💚spotbugs2m 7sbranch-2.6 passed
+1 💚spotless0m 46sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 2sthe patch passed
+1 💚compile3m 30sthe patch passed
-0 ⚠️javac0m 34s/results-compile-javac-hbase-common.txthbase-common generated 1 new + 95 unchanged - 0 fixed = 96 total (was 95)
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 51sthe patch passed
+1 💚xmllint0m 0sNo new issues.
+1 💚spotbugs2m 17sthe patch passed
+1 💚hadoopcheck16m 29sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 18sThe patch does not generate ASF License warnings.
41m 3s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6545/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6545
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint
unameLinux 1914b09f24f1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 76354fc
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6545/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 40sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 57sbranch-2.6 passed
+1 💚compile1m 0sbranch-2.6 passed
+1 💚javadoc0m 40sbranch-2.6 passed
+1 💚shadedjars5m 35sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 48sthe patch passed
+1 💚compile1m 1sthe patch passed
+1 💚javac1m 1sthe patch passed
+1 💚javadoc0m 37sthe patch passed
+1 💚shadedjars5m 34spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit2m 11shbase-common in the patch passed.
+1 💚unit180m 44shbase-server in the patch passed.
208m 17s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6545/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6545
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 7e366db3e0da 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 76354fc
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6545/1/testReport/
Max. process+thread count4138 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6545/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 45sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall3m 5sbranch-2.6 passed
+1 💚compile1m 12sbranch-2.6 passed
+1 💚javadoc0m 44sbranch-2.6 passed
+1 💚shadedjars6m 38sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall3m 11sthe patch passed
+1 💚compile1m 15sthe patch passed
+1 💚javac1m 15sthe patch passed
+1 💚javadoc0m 44sthe patch passed
+1 💚shadedjars5m 50spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit2m 12shbase-common in the patch passed.
+1 💚unit182m 28shbase-server in the patch passed.
213m 16s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6545/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6545
Optional Testsjavac javadoc unit compile shadedjars
unameLinux e7c33706e9e7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 76354fc
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6545/1/testReport/
Max. process+thread count4396 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6545/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 58sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 51sbranch-2.6 passed
+1 💚compile0m 56sbranch-2.6 passed
+1 💚javadoc0m 40sbranch-2.6 passed
+1 💚shadedjars4m 32sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 15sthe patch passed
+1 💚compile0m 57sthe patch passed
+1 💚javac0m 57sthe patch passed
+1 💚javadoc0m 38sthe patch passed
+1 💚shadedjars4m 36spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit2m 30shbase-common in the patch passed.
+1 💚unit199m 52shbase-server in the patch passed.
225m 51s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6545/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6545
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 98db96fff528 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 76354fc
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6545/1/testReport/
Max. process+thread count4056 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6545/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
apurtell merged commit 41a9867 into apache:branch-2.6Jan 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jinhyukify@Apache-HBase@apurtell