Skip to content

HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value - #6556

Merged
Apache9 merged 1 commit into
apache:masterfrom
aristanetworks:processRS_fix
Feb 14, 2025
Merged

HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value#6556
Apache9 merged 1 commit into
apache:masterfrom
aristanetworks:processRS_fix

Conversation

@aaronbee

@aaronbeeaaronbee commented Dec 20, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
guluo2016
guluo2016 reviewed Dec 23, 2024
View reviewed changes
Comment threadhbase-server/src/main/resources/hbase-webapps/regionserver/processRS.jsp Outdated
<td><%= (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseWarnThresholdExceeded")
+ (long)JSONMetricUtil.getValueFromMBean(rsMetrics, "pauseInfoThresholdExceeded") %></td>
<td><%= pauseWarnThresholdExceeded != null && pauseInfoThresholdExceeded != null ?
(long)pauseWarnThresholdExceeded + (long)pauseInfoThresholdExceeded : -1 %></td>

@guluo2016guluo2016Dec 23, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to display 0 if it's null? I'm not sure, maybe we can hear other people's opinions?

<th>JvmPauseMonitor Count </th> , Can you also remove this space in line65?

@aaronbeeaaronbeeDec 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to replace with whatever is preferred. How about the string "unknown"?

@aaronbeeaaronbeeDec 23, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the value to 0 when the metrics are null. And fixed the spacing on line 65.

@guluo2016guluo2016Dec 24, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no more questions. let's wait for others to review.

@Apache-HBase

Apache-HBase commented Dec 23, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 49smaster passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 6sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚spotless1m 3spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
11m 5s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6556
Optional Testsdupname asflicense javac codespell detsecrets spotless
unameLinux 9cc67021bfce 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7cabaf1
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 23, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 29sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 18smaster passed
+1 💚javadoc0m 28smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 1sthe patch passed
+1 💚javadoc0m 26sthe patch passed
_ Other Tests _
+1 💚unit183m 13shbase-server in the patch passed.
195m 19s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6556
Optional Testsjavac javadoc unit
unameLinux 4d6bd5276e33 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7cabaf1
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/2/testReport/
Max. process+thread count5031 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6556/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit c9f7dad into apache:masterFeb 14, 2025
Apache9 pushed a commit that referenced this pull request Feb 14, 2025
@aaronbee@Apache9
HBASE-29038Fix NPE in processRS.jsp due to missing MBean value (#6556)
6aa9adc
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit c9f7dad)
Apache9 pushed a commit that referenced this pull request Feb 14, 2025
@aaronbee@Apache9
HBASE-29038Fix NPE in processRS.jsp due to missing MBean value (#6556)
195998a
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit c9f7dad)
Apache9 pushed a commit that referenced this pull request Feb 14, 2025
@aaronbee@Apache9
HBASE-29038Fix NPE in processRS.jsp due to missing MBean value (#6556)
7b892a2
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit c9f7dad)
Apache9 pushed a commit that referenced this pull request Feb 14, 2025
@aaronbee@Apache9
HBASE-29038Fix NPE in processRS.jsp due to missing MBean value (#6556)
cceaaf3
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit c9f7dad)
@aaronbee
aaronbee deleted the processRS_fix branch February 18, 2025 17:34
mokai87 pushed a commit to mokai87/hbase that referenced this pull request Aug 7, 2025
@aaronbee@mokai87
HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value (apac…
5eeaebc
…he#6556)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit c9f7dad)
sanjeet006py pushed a commit to sanjeet006py/hbase that referenced this pull request Sep 26, 2025
@aaronbeetok_sfci135 tok_sfci135
HBASE-29038 Fix NPE in processRS.jsp due to missing MBean value (apac…
a17801c
…he#6556)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit c9f7dad)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guluo2016guluo2016guluo2016 left review comments
@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aaronbee@Apache-HBase@Apache9@guluo2016