Skip to content

HBASE-29040 Fix description of "sampleRate" of PerformanceEvaluation - #6558

Merged
Apache9 merged 3 commits into
apache:masterfrom
junegunn:HBASE-29040
Jan 13, 2025
Merged

HBASE-29040 Fix description of "sampleRate" of PerformanceEvaluation#6558
Apache9 merged 3 commits into
apache:masterfrom
junegunn:HBASE-29040

Conversation

@junegunn

Copy link
Copy Markdown
Member

The option applies to all tests since HBASE-10788.

this.status = status;
this.testName = this.getClass().getSimpleName();
everyN = (int) (opts.totalRows / (opts.totalRows * opts.sampleRate));
everyN = (int) (1 / opts.sampleRate);

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated to the problem described, but I thought why not.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 58smaster passed
+1 💚compile0m 17smaster passed
+1 💚javadoc0m 12smaster passed
+1 💚shadedjars5m 37sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️patch5m 45sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 💚mvninstall2m 51sthe patch passed
+1 💚compile0m 16sthe patch passed
+1 💚javac0m 16sthe patch passed
+1 💚javadoc0m 12sthe patch passed
+1 💚shadedjars5m 35spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit4m 35shbase-diagnostics in the patch passed.
23m 55s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6558/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6558
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 06940c8e71c2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0d62987
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6558/3/testReport/
Max. process+thread count2659 (vs. ulimit of 30000)
modulesC: hbase-diagnostics U: hbase-diagnostics
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6558/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall3m 13smaster passed
+1 💚compile0m 28smaster passed
+1 💚checkstyle0m 9smaster passed
+1 💚spotbugs0m 29smaster passed
+1 💚spotless0m 47sbranch has no errors when running spotless:check.
-0 ⚠️patch0m 54sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 💚mvninstall2m 58sthe patch passed
+1 💚compile0m 24sthe patch passed
+1 💚javac0m 24sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 8sthe patch passed
+1 💚spotbugs0m 32sthe patch passed
+1 💚hadoopcheck11m 36sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
30m 5s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6558/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6558
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 382b9d86118f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0d62987
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count82 (vs. ulimit of 30000)
modulesC: hbase-diagnostics U: hbase-diagnostics
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6558/3/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

this.status = status;
this.testName = this.getClass().getSimpleName();
everyN = (long) (opts.totalRows / (opts.totalRows * opts.sampleRate));
everyN = (long) (1 / opts.sampleRate);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether (long) (1 / 1.0) will give us the correct result? Could it be 0?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, we don't have to worry about it because 1.0 (1 / 20) has a finite binary representation (unlike numbers like 0.1 or 0.2), so (1 / 1.0) will not yield any arithmetic error.

irb(main):001> [0].pack('G').bytes.map { "%08b" % it }.join
=> "0000000000000000000000000000000000000000000000000000000000000000"
irb(main):002> [1].pack('G').bytes.map { "%08b" % it }.join
=> "0011111111110000000000000000000000000000000000000000000000000000"
irb(main):003> [0.1].pack('G').bytes.map { "%08b" % it }.join
=> "0011111110111001100110011001100110011001100110011001100110011010"
irb(main):004> [0.2].pack('G').bytes.map { "%08b" % it }.join
=> "0011111111001001100110011001100110011001100110011001100110011010"

https://en.wikipedia.org/wiki/Double-precision_floating-point_format#Double-precision_examples

@Apache9
Apache9 merged commit 670deaa into apache:masterJan 13, 2025
Apache9 pushed a commit that referenced this pull request Jan 13, 2025
…6558)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 670deaa)
Apache9 pushed a commit that referenced this pull request Jan 13, 2025
…6558)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 670deaa)
Apache9 pushed a commit that referenced this pull request Jan 13, 2025
…6558)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 670deaa)
Apache9 pushed a commit that referenced this pull request Jan 13, 2025
…6558)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 670deaa)
mokai87 pushed a commit to mokai87/hbase that referenced this pull request Aug 7, 2025
…pache#6558)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 670deaa)
sanjeet006py pushed a commit to sanjeet006py/hbase that referenced this pull request Sep 26, 2025
…pache#6558)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 670deaa)
sanjeet006py pushed a commit to sanjeet006py/hbase that referenced this pull request Sep 26, 2025
…luation (apache#6558)"
This reverts commit 4b725dd4b096a803297618874d97d75906f07607.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@junegunn@Apache-HBase@Apache9