Skip to content

HBASE-28983 Static resources are not loaded on REST web UI pages in dev mode - #6582

Merged
NihalJain merged 1 commit into
apache:branch-3from
PDavid:HBASE-28983-rest-ui-resources-missing-branch-3
Feb 20, 2025
Merged

HBASE-28983 Static resources are not loaded on REST web UI pages in dev mode#6582
NihalJain merged 1 commit into
apache:branch-3from
PDavid:HBASE-28983-rest-ui-resources-missing-branch-3

Conversation

@PDavid

Copy link
Copy Markdown
Contributor

This way the hbase-webapps/static source directory (which holds JS, CSS, image files) is not duplicated anymore. It is only present under hbase-server. This directory is then coped by maven-resources-plugin to the target directory of the REST and Thrift projects.

For this deleted the static directory below the Thrift project.

(cherry picked from commit b445217)

@PDavid

Copy link
Copy Markdown
ContributorAuthor

This is the backport of #6491 to branch-3.

@PDavid

Copy link
Copy Markdown
ContributorAuthor

Tested this the same way: #6491 (comment)

@PDavid
PDavid marked this pull request as ready for review January 8, 2025 08:03
@NihalJainNihalJain added the backport This PR is a back port of some issue or issues already committed to master label Jan 9, 2025
…ev mode
This way the `hbase-webapps/static` source directory (which holds JS, CSS, image files) is not duplicated anymore. It is only present under `hbase-server`. This directory is then coped by maven-resources-plugin to the target directory of the REST and Thrift projects.
For this deleted the static directory below the Thrift project.
(cherry picked from commit b445217)
@PDavid
PDavidforce-pushed the HBASE-28983-rest-ui-resources-missing-branch-3 branch from a4e9417 to c8f4bacCompareJanuary 10, 2025 07:09
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 44sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗jshint0m 0sjshint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-3 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 22sbranch-3 passed
+1 💚compile1m 31sbranch-3 passed
+1 💚spotless0m 53sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall3m 45sthe patch passed
+1 💚compile1m 59sthe patch passed
+1 💚javac1m 59sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck13m 49sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 45spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 17sThe patch does not generate ASF License warnings.
38m 11s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6582/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6582
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile jshint
unameLinux 706ef8259d70 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / c8f4bac
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count90 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6582/2/console
versionsgit=2.34.1 maven=3.9.8 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-3 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 36sbranch-3 passed
+1 💚compile1m 21sbranch-3 passed
+1 💚javadoc1m 1sbranch-3 passed
+1 💚shadedjars7m 34sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for patch
+1 💚mvninstall4m 34sthe patch passed
+1 💚compile1m 32sthe patch passed
+1 💚javac1m 32sthe patch passed
+1 💚javadoc1m 4sthe patch passed
+1 💚shadedjars6m 30spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit6m 50shbase-thrift in the patch passed.
+1 💚unit4m 22shbase-rest in the patch passed.
40m 54s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6582/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6582
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 822ee5ff238b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / c8f4bac
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6582/2/testReport/
Max. process+thread count1729 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6582/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain
NihalJain merged commit bf9895b into apache:branch-3Feb 20, 2025
@PDavid
PDavid deleted the HBASE-28983-rest-ui-resources-missing-branch-3 branch February 20, 2025 08:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@PDavid@Apache-HBase@NihalJain