Skip to content

HBASE-23090 Update start-hbase.sh and stop-hbase.sh - #665

Closed
tdia2082 wants to merge 3 commits into
apache:masterfrom
tdia2082:patch-1
Closed

HBASE-23090 Update start-hbase.sh and stop-hbase.sh#665
tdia2082 wants to merge 3 commits into
apache:masterfrom
tdia2082:patch-1

Conversation

@tdia2082

Copy link
Copy Markdown

removed extra '=' sign which gave an error: "55: [: false: unexpected operator"

removed extra '=' sign which gave an error: "55: [: false: unexpected operator"
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
💙reexec1m 10sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💙shelldocs0m 0sShelldocs was not available.
💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
💚shellcheck0m 0sThere were no new shellcheck issues.
💚whitespace0m 0sThe patch has no whitespace issues.
_ Other Tests _
💚asflicense0m 17sThe patch does not generate ASF License warnings.
2m 41s
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-665/1/artifact/out/Dockerfile
GITHUB PR#665
Optional Testsdupname asflicense shellcheck shelldocs
unameLinux 925ce572ad76 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-665/out/precommit/personality/provided.sh
git revisionmaster / 3250a80
Max. process+thread count47 (vs. ulimit of 10000)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-665/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani

Copy link
Copy Markdown
Contributor

Thanks for the PR @Tikiri16
Could you please specify the relevant Jira here?

@tdia2082tdia2082 changed the title Update start-hbase.shHBASE-23090 Update start-hbase.shSep 28, 2019

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally this change should not be required. Did you try with ./start-hbase.sh or sh start-hbase.sh?

@tdia2082tdia2082 changed the title HBASE-23090 Update start-hbase.shHBASE-23090 Update start-hbase.sh and stop-hbase.shOct 7, 2019
@tdia2082

Copy link
Copy Markdown
Author

Yes, I tried using ./ but, it still showed that error.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 36sDocker mode activated.
_ Prechecks _
💚dupname0m 1sNo case conflicting files found.
💙shelldocs0m 1sShelldocs was not available.
💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
💔shellcheck0m 1sThe patch generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21)
💔whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
_ Other Tests _
💚asflicense0m 18sThe patch does not generate ASF License warnings.
2m 7s
SubsystemReport/Notes
DockerClient=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-665/2/artifact/out/Dockerfile
GITHUB PR#665
Optional Testsdupname asflicense shellcheck shelldocs
unameLinux 6f393cc0a559 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-665/out/precommit/personality/provided.sh
git revisionmaster / 1366c4d
shellcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-665/2/artifact/out/diff-patch-shellcheck.txt
whitespacehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-665/2/artifact/out/whitespace-eol.txt
Max. process+thread count51 (vs. ulimit of 10000)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-665/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@busbey

Copy link
Copy Markdown
Contributor

Just confirmed both of these scripts work as-is using HBase 2.2.1 on Ubuntu 18 with Bash 4.4.20(1). Something is incorrect in your environment, please bring the issue up on the user@hbase mailing list.

@busbeybusbey closed this Oct 10, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tdia2082@Apache-HBase@virajjasani@busbey