HBASE-29155 Use Java 8-compatible instanceOf syntax in ReplicaKey

[PDavid]

The website build failed with the following error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.0:site (default-site) on project hbase: Error generating maven-checkstyle-plugin:3.1.0:checkstyle-aggregate report: Failed during checkstyle configuration: Exception was thrown while processing hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/replicas/ReplicaKey.java: IllegalStateException occurred while parsing file hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/replicas/ReplicaKey.java. hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/replicas/ReplicaKey.java:43:35: expecting RPAREN, found 'other' -> [Help 1]

Checkstyle is not able to parse ReplicaKey.java (because of instanceOf pattern match syntax).

We have a rule to not use Java11+ grammar on branch-3 as long as we still need to support Java 8 on branch-2.x.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 16s		master passed
+1 💚	compile	0m 30s		master passed
-0 ⚠️	checkstyle	0m 9s	/buildtool-branch-checkstyle-hbase-balancer.txt	The patch fails to run checkstyle in hbase-balancer
+1 💚	spotbugs	0m 29s		master passed
+1 💚	spotless	0m 51s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 18s		the patch passed
+1 💚	compile	0m 26s		the patch passed
+1 💚	javac	0m 26s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 9s		the patch passed
+1 💚	spotbugs	0m 29s		the patch passed
+1 💚	hadoopcheck	11m 43s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 10s		The patch does not generate ASF License warnings.
		30m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6729/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6729
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 66a8d4e6cbcd 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / eb67f23
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-balancer U: hbase-balancer
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6729/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 43s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	4m 1s		master passed
+1 💚	compile	0m 24s		master passed
+1 💚	javadoc	0m 16s		master passed
+1 💚	shadedjars	7m 58s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 56s		the patch passed
+1 💚	compile	0m 15s		the patch passed
+1 💚	javac	0m 15s		the patch passed
+1 💚	javadoc	0m 11s		the patch passed
+1 💚	shadedjars	9m 0s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	6m 35s		hbase-balancer in the patch passed.
		34m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6729/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6729
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 515db758f4ae 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / eb67f23
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6729/1/testReport/
Max. process+thread count	265 (vs. ulimit of 30000)
modules	C: hbase-balancer U: hbase-balancer
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6729/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[rmdmattingly]

Apologies here, thank you for the fix @PDavid

[rmdmattingly]

In case it helps, I had a similar thought in https://github.com/apache/hbase/pull/6722/files#diff-bfb1a20f8f7f716aaaf4eb55d2450ad337bb2ce157f51f13c135b3eab3175463L43 and I anticipate shipping that change today

[PDavid]

In case it helps, I had a similar thought in #6722 (files) and I anticipate shipping that change today

Nice, thanks @rmdmattingly. Please feel free to ship it. Then I'll close this PR. 😄

[PDavid]

https://github.com/apache/hbase/pull/6722/files#diff-bfb1a20f8f7f716aaaf4eb55d2450ad337bb2ce157f51f13c135b3eab3175463L43 fixed the issue, so closing this PR.