Uh oh!
There was an error while loading. Please reload this page.
HBASE-29115 Fix website cannot load some resources because of CSP (addendum: remove unneeded TODO) - #6764
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
PDavid
commented
Mar 7, 2025
ContributorAuthor
PR build failed because of tests but these test failures are unrelated. |
PDavid
marked this pull request as ready for review
March 7, 2025 08:28
stoty
commented
Mar 7, 2025
Contributor
The commit message should be the same as the original patch with (addendum) or (addendum: remove unneeded TODO) tacked to the end, @PDavid . |
…dendum: remove unneeded TODO)
PDavidforce-pushed
the
HBASE-29115-remove-todo
branch
from
March 7, 2025 08:55
f2693fb to
1da1b99ComparePDavid
commented
Mar 7, 2025
ContributorAuthor
Forgot to remove this TODO in #6668. I already checked and the static resources (JS, CSS, fonts) are not bundled in the HBase assembly tarballs, just forgot to remove the TODO. 🤦♂️ |
Apache-HBase
commented
Mar 7, 2025
🎊 +1 overall
This message was automatically generated. |
petersomogyi
approved these changes
Mar 10, 2025
petersomogyi
commented
Mar 10, 2025
Contributor
CI build likely failed due to the previous Yetus issue. Should be irrelevant in this comment removal. |
PDavid
commented
Mar 10, 2025
ContributorAuthor
Many thanks for the reviews @stoty and @petersomogyi! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.