Skip to content

HBASE-29115 Fix website cannot load some resources because of CSP (addendum: remove unneeded TODO) - #6764

Merged
petersomogyi merged 1 commit into
apache:masterfrom
PDavid:HBASE-29115-remove-todo
Mar 10, 2025
Merged

HBASE-29115 Fix website cannot load some resources because of CSP (addendum: remove unneeded TODO)#6764
petersomogyi merged 1 commit into
apache:masterfrom
PDavid:HBASE-29115-remove-todo

Conversation

@PDavid

@PDavidPDavid commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid

Copy link
Copy Markdown
ContributorAuthor

PR build failed because of tests but these test failures are unrelated.

@PDavid
PDavid marked this pull request as ready for review March 7, 2025 08:28
@stoty

stoty commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

The commit message should be the same as the original patch with (addendum) or (addendum: remove unneeded TODO) tacked to the end, @PDavid .

@PDavidPDavid changed the title [ADDENDUM] HBASE-29115 Remove unneeded TODOHBASE-29115 Fix website cannot load some resources because of CSP (addendum: remove unneeded TODO)Mar 7, 2025
@PDavid
PDavidforce-pushed the HBASE-29115-remove-todo branch from f2693fb to 1da1b99CompareMarch 7, 2025 08:55
@PDavid

Copy link
Copy Markdown
ContributorAuthor

Forgot to remove this TODO in #6668.

I already checked and the static resources (JS, CSS, fonts) are not bundled in the HBase assembly tarballs, just forgot to remove the TODO. 🤦‍♂️

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 28sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 1scodespell was not available.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 3smaster passed
+1 💚compile8m 26smaster passed
+1 💚spotless0m 47sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 55sthe patch passed
+1 💚compile11m 12sthe patch passed
+1 💚javac11m 12sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck13m 51sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless1m 4spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
51m 18s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6764/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6764
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
unameLinux 4b498ea8e5bb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1da1b99
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count191 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6764/2/console
versionsgit=2.34.1 maven=3.9.8 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@petersomogyi

Copy link
Copy Markdown
Contributor

CI build likely failed due to the previous Yetus issue. Should be irrelevant in this comment removal.

@petersomogyi
petersomogyi merged commit 756e22e into apache:masterMar 10, 2025
@PDavid
PDavid deleted the HBASE-29115-remove-todo branch March 10, 2025 13:43
@PDavid

Copy link
Copy Markdown
ContributorAuthor

Many thanks for the reviews @stoty and @petersomogyi! 🙏

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@PDavid@Apache-HBase@stoty@petersomogyi