HBASE-29207 The backup system table should be considered a system table by rmdmattingly · Pull Request #6842 · apache/hbase

rmdmattingly · 2025-03-21T18:43:13Z

Some might argue that this table should be named system:backup instead of backup:system, but c'est la vie

NihalJain · 2025-03-22T04:18:06Z

+ } else if (Bytes.equals(NamespaceDescriptor.BACKUP_NAMESPACE_NAME, namespace)) {
+ this.namespace = NamespaceDescriptor.BACKUP_NAMESPACE_NAME;


What if user has configured a custom table name as in https://github.com/apache/hbase/blob/master/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java#L1194 ?

I’m not sure, to be honest. If we were back in time I’d recommend not supporting that feature at all. Do you have any ideas?

rmdmattingly · 2025-03-22T16:44:46Z

Wow, I see now why this wasn’t listed as a system table initially. We take snapshots of the backups table periodically, and you cannot take snapshots of system tables. Test failures caught this disconnect of intentions.

I’ll think a bit about this, but I wonder if we should make an exception for allowing backup system table snapshots.

ndimiduk · 2025-03-22T20:35:47Z

you cannot take snapshots of system tables

Wait you can't take a snapshot of meta? I feel like this is something I've done before. Maybe I was just taking a "dump"/export...

rmdmattingly · 2025-03-22T20:48:21Z

According to the precondition tripped by those tests, one cannot

ndimiduk

Some might argue that this table should be named system:backup instead of backup:system, but c'est la vie

Yes this is quite unfortunate.

Apache-HBase · 2025-04-23T15:56:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 32s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 30s		master passed
+1 💚	compile	2m 36s		master passed
+1 💚	checkstyle	0m 48s		master passed
+1 💚	spotbugs	2m 1s		master passed
+1 💚	spotless	0m 52s		branch has no errors when running spotless:check.
-0 ⚠️	patch	1m 11s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 1s		the patch passed
+1 💚	compile	2m 27s		the patch passed
+1 💚	javac	2m 27s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 53s		the patch passed
+1 💚	spotbugs	2m 35s		the patch passed
+1 💚	hadoopcheck	16m 7s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	1m 14s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		50m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6842/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6842
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux eb57bb751544 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d4b438e`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-backup U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6842/4/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-04-23T16:51:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 44s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 25s		Maven dependency ordering for branch
+1 💚	mvninstall	8m 27s		master passed
+1 💚	compile	3m 12s		master passed
+1 💚	javadoc	2m 50s		master passed
+1 💚	shadedjars	13m 18s		branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	patch	14m 37s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 39s		Maven dependency ordering for patch
+1 💚	mvninstall	8m 25s		the patch passed
+1 💚	compile	3m 4s		the patch passed
+1 💚	javac	3m 4s		the patch passed
+1 💚	javadoc	2m 40s		the patch passed
+1 💚	shadedjars	12m 57s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	7m 5s		hbase-common in the patch passed.
+1 💚	unit	5m 14s		hbase-client in the patch passed.
-1 ❌	unit	32m 40s	/patch-unit-hbase-backup.txt	hbase-backup in the patch failed.
		105m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6842/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6842
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 97560db65fee 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d4b438e`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6842/4/testReport/
Max. process+thread count	3539 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-backup U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6842/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

…le (#6842) Co-authored-by: Ray Mattingly <rmattingly@hubspot.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org>

…le (#6842) (#6928) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org> Co-authored-by: Ray Mattingly <rmattingly@hubspot.com>

…le (#6842) (#6929) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org> Co-authored-by: Ray Mattingly <rmattingly@hubspot.com>

…le (#6842) (#6930) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org> Co-authored-by: Ray Mattingly <rmattingly@hubspot.com>

…le (apache#6842) (apache#6929) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org> Co-authored-by: Ray Mattingly <rmattingly@hubspot.com>

rmdmattingly requested a review from ndimiduk March 21, 2025 18:45

This comment has been minimized.
Sign in to view

NihalJain approved these changes Mar 22, 2025
View reviewed changes

NihalJain reviewed Mar 22, 2025
View reviewed changes

rmdmattingly force-pushed the HBASE-29207 branch from 709e203 to 8f08296Compare March 22, 2025 15:45

This comment has been minimized.
Sign in to view

HBASE-29207 The backup system table should be considered a system table
2eaa884

rmdmattingly force-pushed the HBASE-29207 branch from 8f08296 to 2eaa884Compare March 22, 2025 16:58

This comment has been minimized.
Sign in to view

Kota-SH approved these changes Apr 17, 2025
View reviewed changes

ndimiduk approved these changes Apr 23, 2025
View reviewed changes

Merge branch 'master' into HBASE-29207
d4b438e

rmdmattingly merged commit dcb406f into apache:masterApr 23, 2025

rmdmattingly deleted the HBASE-29207 branch April 23, 2025 19:45

rmdmattingly mentioned this pull request Apr 23, 2025
Backport "HBASE-29207 The backup system table should be considered a system tab…" to branch-3 #6928
Merged

rmdmattingly mentioned this pull request Apr 23, 2025
Backport "HBASE-29207 The backup system table should be considered a system tab…" to branch-2 #6929
Merged

rmdmattingly mentioned this pull request Apr 23, 2025
Backport "HBASE-29207 The backup system table should be considered a system tab…" to branch-2.6 #6930
Merged

Navigation Menu

Uh oh!

HBASE-29207 The backup system table should be considered a system table - #6842

HBASE-29207 The backup system table should be considered a system table#6842
rmdmattingly merged 2 commits into
apache:masterfrom
HubSpot:HBASE-29207

rmdmattingly commented Mar 21, 2025•
edited
Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

NihalJainMar 22, 2025

Uh oh!

rmdmattinglyMar 22, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rmdmattingly commented Mar 22, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

ndimiduk commented Mar 22, 2025

Uh oh!

rmdmattingly commented Mar 22, 2025

Uh oh!

ndimiduk left a comment

Uh oh!

Apache-HBase commented Apr 23, 2025

Uh oh!

Apache-HBase commented Apr 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		} else if (Bytes.equals(NamespaceDescriptor.BACKUP_NAMESPACE_NAME, namespace)) {
		this.namespace = NamespaceDescriptor.BACKUP_NAMESPACE_NAME;

Uh oh!

Conversation

rmdmattingly commented Mar 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

NihalJainMar 22, 2025

Choose a reason for hiding this comment

Uh oh!

rmdmattinglyMar 22, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

rmdmattingly commented Mar 22, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

ndimiduk commented Mar 22, 2025

Uh oh!

rmdmattingly commented Mar 22, 2025

Uh oh!

ndimiduk left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Apr 23, 2025

Uh oh!

Apache-HBase commented Apr 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rmdmattingly commented Mar 21, 2025•
edited
Loading