Skip to content

HBASE-28983 Static resources are not loaded on REST web UI pages in dev mode - #6849

Merged
NihalJain merged 1 commit into
apache:branch-2.6from
PDavid:HBASE-28983-rest-ui-resources-missing-branch-2.6
Mar 25, 2025
Merged

HBASE-28983 Static resources are not loaded on REST web UI pages in dev mode#6849
NihalJain merged 1 commit into
apache:branch-2.6from
PDavid:HBASE-28983-rest-ui-resources-missing-branch-2.6

Conversation

@PDavid

Copy link
Copy Markdown
Contributor

This way the hbase-webapps/static source directory (which holds JS, CSS, image files) is not duplicated anymore. It is only present under hbase-server. This directory is then coped by maven-resources-plugin to the target directory of the REST and Thrift projects.

For this deleted the static directory below the Thrift project.

Signed-off-by: Nihal Jain nihaljain@apache.org
Reviewed-by: Andrew Purtell apurtell@apache.org
(cherry picked from commit 4e40bd5)

…ev mode (apache#6491)
This way the `hbase-webapps/static` source directory (which holds JS, CSS, image files) is not duplicated anymore. It is only present under `hbase-server`. This directory is then coped by maven-resources-plugin to the target directory of the REST and Thrift projects.
For this deleted the static directory below the Thrift project.
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Reviewed-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit 4e40bd5)
@PDavid

PDavid commented Mar 24, 2025

Copy link
Copy Markdown
ContributorAuthor

This is a backport of #6491 to branch-2.6.

Since the Bootstrap upgrade backport is now merged to branch-2.6, we can backport #6491 to branch-2.6.

I cherry-picked the commit from master (it applied cleanly).

@PDavidPDavid changed the title HBASE-28983 Static resources are not loaded on REST web UI pages in dev mode (#6491)HBASE-28983 Static resources are not loaded on REST web UI pages in dev modeMar 24, 2025
@PDavid

Copy link
Copy Markdown
ContributorAuthor

I tested this locally by starting HBase in standalone mode (mvn clean install -DskipTests -Dhadoop.profile=3.0 && bin/start-hbase.sh) then starting REST server (bin/hbase rest start -p 8080):

image

Thrift Server started with bin/hbase thrift start -p 8081:

image

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 49sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗jshint0m 0sjshint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 19sbranch-2.6 passed
+1 💚compile1m 12sbranch-2.6 passed
+1 💚spotless0m 48sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 11sthe patch passed
+1 💚compile1m 12sthe patch passed
+1 💚javac1m 12sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck17m 14sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless0m 49spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 18sThe patch does not generate ASF License warnings.
30m 58s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6849/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6849
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile jshint
unameLinux 40acbd7863d2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 0e54aa3
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6849/1/console
versionsgit=2.34.1 maven=3.9.8 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 34sbranch-2.6 passed
+1 💚compile0m 39sbranch-2.6 passed
+1 💚javadoc0m 37sbranch-2.6 passed
+1 💚shadedjars5m 18sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 25sthe patch passed
+1 💚compile0m 40sthe patch passed
+1 💚javac0m 40sthe patch passed
+1 💚javadoc0m 35sthe patch passed
+1 💚shadedjars5m 18spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit6m 42shbase-thrift in the patch passed.
+1 💚unit4m 8shbase-rest in the patch passed.
31m 24s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6849/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6849
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7fafbdf01909 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 0e54aa3
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6849/1/testReport/
Max. process+thread count1842 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6849/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 46sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 15sbranch-2.6 passed
+1 💚compile0m 46sbranch-2.6 passed
+1 💚javadoc0m 32sbranch-2.6 passed
+1 💚shadedjars6m 28sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall3m 12sthe patch passed
+1 💚compile0m 47sthe patch passed
+1 💚javac0m 47sthe patch passed
+1 💚javadoc0m 31sthe patch passed
+1 💚shadedjars6m 24spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit6m 51shbase-thrift in the patch passed.
+1 💚unit4m 2shbase-rest in the patch passed.
35m 12s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6849/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6849
Optional Testsjavac javadoc unit shadedjars compile
unameLinux db8b9dd4fa54 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 0e54aa3
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6849/1/testReport/
Max. process+thread count1757 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6849/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec7m 55sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall4m 6sbranch-2.6 passed
+1 💚compile1m 5sbranch-2.6 passed
+1 💚javadoc0m 53sbranch-2.6 passed
+1 💚shadedjars8m 10sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall4m 56sthe patch passed
+1 💚compile1m 1sthe patch passed
+1 💚javac1m 1sthe patch passed
+1 💚javadoc0m 38sthe patch passed
+1 💚shadedjars7m 49spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit6m 48shbase-thrift in the patch passed.
+1 💚unit4m 36shbase-rest in the patch passed.
50m 21s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6849/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6849
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3c772d05a6e8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 0e54aa3
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6849/1/testReport/
Max. process+thread count1816 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6849/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@PDavid
PDavid marked this pull request as ready for review March 25, 2025 07:58
@NihalJain
NihalJain merged commit 1f31d89 into apache:branch-2.6Mar 25, 2025
@PDavid
PDavid deleted the HBASE-28983-rest-ui-resources-missing-branch-2.6 branch March 25, 2025 16:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@PDavid@Apache-HBase@NihalJain