HBASE-28983 Static resources are not loaded on REST web UI pages in dev mode by PDavid · Pull Request #6855 · apache/hbase

PDavid · 2025-03-25T08:12:01Z

This way the hbase-webapps/static source directory (which holds JS, CSS, image files) is not duplicated anymore. It is only present under hbase-server. This directory is then coped by maven-resources-plugin to the target directory of the REST and Thrift projects.

For this deleted the static directory below the Thrift project.

Signed-off-by: Nihal Jain nihaljain@apache.org
Reviewed-by: Andrew Purtell apurtell@apache.org
(cherry picked from commit 4e40bd5)

…ev mode (apache#6491) This way the `hbase-webapps/static` source directory (which holds JS, CSS, image files) is not duplicated anymore. It is only present under `hbase-server`. This directory is then coped by maven-resources-plugin to the target directory of the REST and Thrift projects. For this deleted the static directory below the Thrift project. Signed-off-by: Nihal Jain <nihaljain@apache.org> Reviewed-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit 4e40bd5)

PDavid · 2025-03-25T08:12:42Z

This is a backport of #6491 to branch-2.5.

Now that the Bootstrap upgrade is merged we can backport this fix.

I cherry-picked the commit from master (it applied cleanly).

PDavid · 2025-03-25T08:53:38Z

I tested this locally by starting HBase in standalone mode (mvn clean install -DskipTests -Dhadoop.profile=3.0 && bin/start-hbase.sh) then starting REST server (bin/hbase rest start -p 8080):

Thrift Server started with bin/hbase thrift start -p 8081:

Apache-HBase · 2025-03-25T15:04:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 44s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	jshint	0m 0s		jshint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 13s		branch-2.5 passed
+1 💚	compile	1m 16s		branch-2.5 passed
+1 💚	spotless	0m 48s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 34s		the patch passed
+1 💚	compile	1m 40s		the patch passed
+1 💚	javac	1m 40s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	hadoopcheck	25m 28s		Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 18s		The patch does not generate ASF License warnings.
		41m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6855/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6855
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile jshint
uname	Linux 2f3e2d56ee43 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `b8e3a30`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-thrift hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6855/1/console
versions	git=2.34.1 maven=3.9.8 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-03-25T15:09:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 53s		Docker mode activated.
-0 ⚠️	yetus	0m 7s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 44s		branch-2.5 passed
+1 💚	compile	1m 8s		branch-2.5 passed
+1 💚	javadoc	0m 41s		branch-2.5 passed
+1 💚	shadedjars	7m 9s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 29s		the patch passed
+1 💚	compile	0m 52s		the patch passed
+1 💚	javac	0m 52s		the patch passed
+1 💚	javadoc	0m 42s		the patch passed
+1 💚	shadedjars	6m 58s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	6m 44s		hbase-thrift in the patch passed.
+1 💚	unit	4m 22s		hbase-rest in the patch passed.
		39m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6855/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6855
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1c357d150096 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `b8e3a30`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6855/1/testReport/
Max. process+thread count	1740 (vs. ulimit of 30000)
modules	C: hbase-thrift hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6855/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-03-25T15:17:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	7m 23s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 19s		branch-2.5 passed
+1 💚	compile	0m 56s		branch-2.5 passed
+1 💚	javadoc	0m 53s		branch-2.5 passed
+1 💚	shadedjars	6m 48s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 12s		the patch passed
+1 💚	compile	1m 4s		the patch passed
+1 💚	javac	1m 4s		the patch passed
+1 💚	javadoc	0m 52s		the patch passed
+1 💚	shadedjars	6m 24s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	8m 9s		hbase-thrift in the patch passed.
+1 💚	unit	5m 57s		hbase-rest in the patch passed.
		48m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6855/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6855
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 919b62a0974c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `b8e3a30`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6855/1/testReport/
Max. process+thread count	1713 (vs. ulimit of 30000)
modules	C: hbase-thrift hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6855/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-03-25T15:21:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 1s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 1s		branch-2.5 passed
+1 💚	compile	1m 3s		branch-2.5 passed
+1 💚	javadoc	0m 38s		branch-2.5 passed
+1 💚	shadedjars	7m 28s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 3s		the patch passed
+1 💚	compile	1m 1s		the patch passed
+1 💚	javac	1m 1s		the patch passed
+1 💚	javadoc	0m 41s		the patch passed
+1 💚	shadedjars	7m 18s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	6m 35s		hbase-thrift in the patch passed.
+1 💚	unit	4m 10s		hbase-rest in the patch passed.
		40m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6855/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6855
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 42b23ae308b3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `b8e3a30`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6855/1/testReport/
Max. process+thread count	1771 (vs. ulimit of 30000)
modules	C: hbase-thrift hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6855/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2025-03-25T16:05:49Z

Will merge this in next half hour!

PDavid marked this pull request as ready for review March 25, 2025 15:47

NihalJain approved these changes Mar 25, 2025
View reviewed changes

NihalJain merged commit 6b8f4f0 into apache:branch-2.5Mar 25, 2025

PDavid deleted the HBASE-28983-rest-ui-resources-missing-branch-2.5 branch March 25, 2025 16:39

Navigation Menu

Uh oh!

HBASE-28983 Static resources are not loaded on REST web UI pages in dev mode - #6855

HBASE-28983 Static resources are not loaded on REST web UI pages in dev mode#6855
NihalJain merged 1 commit into
apache:branch-2.5from
PDavid:HBASE-28983-rest-ui-resources-missing-branch-2.5

PDavid commented Mar 25, 2025

Uh oh!

PDavid commented Mar 25, 2025

Uh oh!

PDavid commented Mar 25, 2025

Uh oh!

Apache-HBase commented Mar 25, 2025

Uh oh!

Apache-HBase commented Mar 25, 2025

Uh oh!

Apache-HBase commented Mar 25, 2025

Uh oh!

Apache-HBase commented Mar 25, 2025

Uh oh!

NihalJain commented Mar 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

PDavid commented Mar 25, 2025

Uh oh!

PDavid commented Mar 25, 2025

Uh oh!

PDavid commented Mar 25, 2025

Uh oh!

Apache-HBase commented Mar 25, 2025

Uh oh!

Apache-HBase commented Mar 25, 2025

Uh oh!

Apache-HBase commented Mar 25, 2025

Uh oh!

Apache-HBase commented Mar 25, 2025

Uh oh!

NihalJain commented Mar 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants