HBASE-29218: Reduce calls to Configuration#get() in decompression path by charlesconnell · Pull Request #6857 · apache/hbase

charlesconnell · 2025-03-26T01:28:38Z

Use of the org.apache.hadoop.conf.Configuration class to look up values is not super fast. It's fine most of the time, but in a very hot code path, it takes up noticeable CPU time.

ByteBuffDecompressor's are pooled and reused to avoid garbage collection churn. This means that sometimes their settings are not right for the block they're being asked to decompress. To handle this, before every decompression action, we call ByteBuffDecompressor#reinit(Configuration), so it can pull settings from the Configuration in preparation for the decompression it's about to do. The Configuration#get() inside reinit() happens once per block, even though the settings it deals with are consistent across an entire table.

Because the settings used by a ByteBuffDecompressor don't actually change within a table, we can pull the settings it needs from a Configuration when opening the HFile, and then not check again.

… to Configuration.get()

charlesconnell · 2025-04-15T14:20:32Z

I've added a commit to switch uses of the Caffeine cache back to Guava, in modules that leak into the client. I should have considered that using an un-shaded Caffeine would pollute client classpaths.

ndimiduk

Some questions / nits. Otherwise looks good to me.

ndimiduk · 2025-04-17T10:57:25Z

 <groupId>org.apache.commons</groupId>
 <artifactId>commons-crypto</artifactId>
 </dependency>
- <dependency>


Thanks for fixing this.

ndimiduk · 2025-04-17T11:04:01Z

 public static final String ZSTD_DICTIONARY_KEY = "hbase.io.compress.zstd.dictionary";

+ private static final Cache<String, Pair<ZstdDictDecompress, Integer>> DECOMPRESS_DICT_CACHE =
+ CacheBuilder.newBuilder().maximumSize(100).expireAfterAccess(10, TimeUnit.MINUTES).build();


Should the details of this cache be user-configurable?

My preference is for less low-value configuration options. But, I'm happy to do it either way, what do you prefer?

Nope, I'm fine with leaving them as hard-coded for now. Just asking the question to prompt the discussion.

ndimiduk · 2025-04-17T12:13:39Z

Oh sorry. Please also address the checkstyle nits. Thanks @charlesconnell !

Apache-HBase · 2025-04-17T21:59:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 46s		master passed
+1 💚	compile	5m 6s		master passed
+1 💚	checkstyle	1m 19s		master passed
+1 💚	spotbugs	3m 26s		master passed
+1 💚	spotless	1m 9s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 45s		the patch passed
+1 💚	compile	5m 27s		the patch passed
+1 💚	javac	5m 27s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 42s		the patch passed
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	4m 33s		the patch passed
+1 💚	hadoopcheck	16m 20s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 56s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		61m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6857/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6857
JIRA Issue	HBASE-29218
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
uname	Linux af3550b1c32f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `835b934`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-compression/hbase-compression-zstd U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6857/5/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-04-18T05:26:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	5m 49s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	1m 3s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 51s		master passed
+1 💚	compile	1m 40s		master passed
+1 💚	javadoc	1m 6s		master passed
+1 💚	shadedjars	6m 19s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 57s		the patch passed
+1 💚	compile	1m 35s		the patch passed
+1 💚	javac	1m 35s		the patch passed
+1 💚	javadoc	0m 56s		the patch passed
+1 💚	shadedjars	6m 18s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	3m 13s		hbase-common in the patch passed.
-1 ❌	unit	398m 20s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
+1 💚	unit	9m 20s		hbase-compression-zstd in the patch passed.
		459m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6857/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6857
JIRA Issue	HBASE-29218
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d9c61612bc3a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `835b934`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6857/5/testReport/
Max. process+thread count	4329 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-compression/hbase-compression-zstd U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6857/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

apache#6857) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

#6857) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

#6857) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>

apache#6857) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>

#6857) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>

apache#6857) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>

HBASE-29218: Pass around an HFileDecompressionContext to reduce calls…
81585cf
… to Configuration.get()

This comment has been minimized.
Sign in to view

charlesconnell marked this pull request as ready for review March 26, 2025 16:28

charlesconnell force-pushed the HBASE-29218/hfile-decompressing-context branch 2 times, most recently from d424ae6 to e8f9f96Compare April 15, 2025 14:11

Switch back to Guava cache
99f82e4

charlesconnell force-pushed the HBASE-29218/hfile-decompressing-context branch from e8f9f96 to 99f82e4Compare April 15, 2025 14:17

This comment has been minimized.
Sign in to view

ndimiduk approved these changes Apr 17, 2025
View reviewed changes

PR feedback
7f184f4

checkstyle
835b934

This comment has been minimized.
Sign in to view

ndimiduk changed the title ~~HBASE-29218: Pass around an HFileDecompressionContext to reduce calls to Configuration.get()~~HBASE-29218: Reduce calls to Configuration#get() in decompression pathApr 24, 2025

ndimiduk merged commit 763093a into apache:masterApr 24, 2025

ndimiduk deleted the HBASE-29218/hfile-decompressing-context branch April 24, 2025 09:13

ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Apr 24, 2025
HBASE-29218: Reduce calls to Configuration#get() in decompression path (
03437d3
apache#6857) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Apr 24, 2025
HBASE-29218: Reduce calls to Configuration#get() in decompression path (
1de0f23
apache#6857) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

ndimiduk pushed a commit that referenced this pull request Apr 24, 2025
HBASE-29218: Reduce calls to Configuration#get() in decompression path (
cffce16
#6857) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

ndimiduk added a commit that referenced this pull request Apr 25, 2025
HBASE-29218: Reduce calls to Configuration#get() in decompression path (
934a26d
#6857) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Apr 25, 2025
HBASE-29218: Reduce calls to Configuration#get() in decompression path (
fd4cfbe
apache#6857) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Apr 25, 2025
HBASE-29218: Reduce calls to Configuration#get() in decompression path (
57a7696
apache#6857) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>

ndimiduk added a commit that referenced this pull request Apr 26, 2025
HBASE-29218: Reduce calls to Configuration#get() in decompression path (
5c4e752
#6857) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>

ndimiduk added a commit that referenced this pull request Apr 26, 2025
HBASE-29218: Reduce calls to Configuration#get() in decompression path (
18dac45
#6857) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>

mokai87 pushed a commit to mokai87/hbase that referenced this pull request Aug 7, 2025
HBASE-29218: Reduce calls to Configuration#get() in decompression path (
42f2bf9
apache#6857) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>

Uh oh!

Conversation

charlesconnell commented Mar 26, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

charlesconnell commented Apr 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ndimiduk left a comment

Choose a reason for hiding this comment

Uh oh!

ndimidukApr 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ndimidukApr 17, 2025

Choose a reason for hiding this comment

Uh oh!

charlesconnellApr 17, 2025

Choose a reason for hiding this comment

Uh oh!

ndimidukApr 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ndimiduk commented Apr 17, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Apr 17, 2025

Uh oh!

Apache-HBase commented Apr 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

charlesconnell commented Apr 15, 2025•
edited
Loading