Skip to content

HBASE-23116: Fix a couple of load balancer logging nits. - #687

Merged
wchevreuil merged 1 commit into
apache:masterfrom
bharathv:HBASE-23116
Oct 4, 2019
Merged

HBASE-23116: Fix a couple of load balancer logging nits.#687
wchevreuil merged 1 commit into
apache:masterfrom
bharathv:HBASE-23116

Conversation

@bharathv

@bharathvbharathv commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

Fixes a typo and adds table name to the logging context when
StochasticLoadBalancer is configured "per table". Added some
test coverage with per-table balancer enabled and manually
verified the logs to make sure the table name is formatted
correctly.

virajjasani
virajjasani reviewed Oct 4, 2019
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java Outdated
Comment thread...server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java Outdated
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java Outdated
virajjasani
virajjasani reviewed Oct 4, 2019
View reviewed changes
Comment thread...server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
Comment thread...server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java Outdated
@Apache-HBase

Apache-HBase commented Oct 4, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 37sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
💚mvninstall7m 12smaster passed
💚compile1m 0smaster passed
💚checkstyle1m 29smaster passed
💚shadedjars4m 49sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 41smaster passed
💙spotbugs4m 39sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 35smaster passed
_ Patch Compile Tests _
💚mvninstall6m 31sthe patch passed
💚compile1m 10sthe patch passed
💚javac1m 10sthe patch passed
💔checkstyle1m 34shbase-server: The patch generated 2 new + 170 unchanged - 0 fixed = 172 total (was 170)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars5m 39spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck19m 25sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 39sthe patch passed
💚findbugs4m 58sthe patch passed
_ Other Tests _
💔unit168m 40shbase-server in the patch failed.
💚asflicense0m 34sThe patch does not generate ASF License warnings.
237m 19s
ReasonTests
Failed junit testshadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-687/1/artifact/out/Dockerfile
GITHUB PR#687
JIRA IssueHBASE-23116
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 977c3daa96bb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-687/out/precommit/personality/provided.sh
git revisionmaster / 5aa8d3a
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-687/1/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-687/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-687/1/testReport/
Max. process+thread count4480 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-687/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@bharathv
HBASE-23116: Fix a load balancer logging nit.
599cd94
This commit adds table name to the logging context when
StochasticLoadBalancer is configured "per table". Added some
test coverage with per-table balancer enabled and manually
verified the logs to make sure the table name is formatted
correctly.
bharathv
bharathv commented Oct 4, 2019
View reviewed changes

@bharathvbharathv left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the check-style issues but I don't think the test failures are related.

Comment thread...server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java Outdated
@wchevreuil

wchevreuil commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

LGTM, +1. Also ran this previously failed TestSnapshotScannerHDFSAclController and it's passing locally, so it should be unrelated. Will merge this PR.

@wchevreuil
wchevreuil merged commit 06ff478 into apache:masterOct 4, 2019
asfgit pushed a commit that referenced this pull request Oct 4, 2019
Bharath Vissapragada@wchevreuil
HBASE-23116: Fix a load balancer logging nit. (#687)
12852d3
This commit adds table name to the logging context when
StochasticLoadBalancer is configured "per table". Added some
test coverage with per-table balancer enabled and manually
verified the logs to make sure the table name is formatted
correctly.
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.com>
(cherry picked from commit 06ff478)
asfgit pushed a commit that referenced this pull request Oct 4, 2019
Bharath Vissapragada@wchevreuil
HBASE-23116: Fix a load balancer logging nit. (#687)
f89321d
This commit adds table name to the logging context when
StochasticLoadBalancer is configured "per table". Added some
test coverage with per-table balancer enabled and manually
verified the logs to make sure the table name is formatted
correctly.
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.com>
(cherry picked from commit 06ff478)
asfgit pushed a commit that referenced this pull request Oct 4, 2019
Bharath Vissapragada@wchevreuil
HBASE-23116: Fix a load balancer logging nit. (#687)
cb2a9a4
This commit adds table name to the logging context when
StochasticLoadBalancer is configured "per table". Added some
test coverage with per-table balancer enabled and manually
verified the logs to make sure the table name is formatted
correctly.
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.com>
(cherry picked from commit 06ff478)
@bharathv
bharathv deleted the HBASE-23116 branch October 4, 2019 18:43
@apurtell

apurtell commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

There are fix versions for 1.x on the JIRA but no commits to branch-1s. Is there a backport in progress?

@apurtell

apurtell commented Oct 4, 2019

Copy link
Copy Markdown
Contributor

Answering my own question - I am doing the backport now. Trying to get 1.5.0 RC out.

@Apache-HBase

Apache-HBase commented Oct 4, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec1m 10sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
💚mvninstall5m 21smaster passed
💚compile0m 56smaster passed
💚checkstyle1m 21smaster passed
💚shadedjars4m 36sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 37smaster passed
💙spotbugs4m 3sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 1smaster passed
_ Patch Compile Tests _
💚mvninstall4m 58sthe patch passed
💚compile0m 53sthe patch passed
💚javac0m 53sthe patch passed
💚checkstyle1m 19sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 34spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck15m 33sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 37sthe patch passed
💚findbugs4m 25sthe patch passed
_ Other Tests _
💔unit307m 57shbase-server in the patch failed.
💚asflicense0m 38sThe patch does not generate ASF License warnings.
365m 17s
ReasonTests
Failed junit testshadoop.hbase.client.TestSnapshotCloneIndependence
hadoop.hbase.regionserver.TestRegionReplicasWithModifyTable
hadoop.hbase.master.TestSplitWALManager
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestAsyncTableAdminApi
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.client.TestFromClientSideWithCoprocessor
SubsystemReport/Notes
DockerClient=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-687/2/artifact/out/Dockerfile
GITHUB PR#687
JIRA IssueHBASE-23116
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 3210a8a8ed2d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-687/out/precommit/personality/provided.sh
git revisionmaster / 800c35a
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-687/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-687/2/testReport/
Max. process+thread count4782 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-687/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

bharathv added a commit to bharathv/hbase that referenced this pull request Oct 4, 2019
@bharathv
HBASE-23116: Fix a load balancer logging nit. (apache#687)
925cb1e
This commit adds table name to the logging context when
StochasticLoadBalancer is configured "per table". Added some
test coverage with per-table balancer enabled and manually
verified the logs to make sure the table name is formatted
correctly.
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.com>
bharathv added a commit to bharathv/hbase that referenced this pull request Oct 4, 2019
@bharathv
HBASE-23116: Fix a load balancer logging nit. (apache#687)
2bf005d
This commit adds table name to the logging context when
StochasticLoadBalancer is configured "per table".
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.com>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
Bharath Vissapragada@Apache9
HBASE-23116: Fix a load balancer logging nit. (apache#687)
1b620cd
This commit adds table name to the logging context when
StochasticLoadBalancer is configured "per table". Added some
test coverage with per-table balancer enabled and manually
verified the logs to make sure the table name is formatted
correctly.
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.com>
(cherry picked from commit 06ff478)
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
Bharath VissapragadaJenkins
HBASE-23116: Fix a load balancer logging nit. (apache#687)
176d049
This commit adds table name to the logging context when
StochasticLoadBalancer is configured "per table". Added some
test coverage with per-table balancer enabled and manually
verified the logs to make sure the table name is formatted
correctly.
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.com>
(cherry picked from commit 06ff478)
(cherry picked from commit f89321d)
Change-Id: Ieddcb04d5d3effe484eaedb3e2a9d2b677d5d84f
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuilwchevreuilwchevreuil left review comments
@virajjasanivirajjasanivirajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bharathv@Apache-HBase@wchevreuil@apurtell@virajjasani