Skip to content

HBASE-29317 Bump hbase-thirdparty to 4.1.11 (#6993) - #7044

Merged
NihalJain merged 4 commits into
apache:branch-2.5from
NihalJain:test_v_4.1.11_branch-2.5
Jun 2, 2025
Merged

HBASE-29317 Bump hbase-thirdparty to 4.1.11 (#6993) #7044
NihalJain merged 4 commits into
apache:branch-2.5from
NihalJain:test_v_4.1.11_branch-2.5

Conversation

@NihalJain

@NihalJainNihalJain commented May 27, 2025

Copy link
Copy Markdown
Contributor
  • Update allowed_expr to allow org/jspecify/annotation/*.class which is coming from guava due to google/guava@2cc8c5e
  • Bump maven-shade-plugin to 3.6.0 as we see failure META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66 due to FasterXML/jackson-core@7d8dc09
  • Add --should-stop=ifError=FLOW as compilerArgs. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details! But since we do not upgrade to 2.36.0 on branch-2.x we have kept this change just to keep code in sync across branches.
  • Error Prone 2.31.0 is the latest version which supports running on JDK 11

…allow `org/jspecify/annotation/*.class` which is coming from guava due to google/guava@2cc8c5e * Bump maven-shade-plugin to 3.6.0 as we see failure `META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66` due to FasterXML/jackson-core@7d8dc09 * Add `--should-stop=ifError=FLOW` as `compilerArgs`. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details!
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@NihalJain

Copy link
Copy Markdown
ContributorAuthor

Failures do not look related!

@NihalJain

Copy link
Copy Markdown
ContributorAuthor

Failures are not related!

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 49sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall3m 30sbranch-2.5 passed
+1 💚compile6m 4sbranch-2.5 passed
+1 💚spotless0m 48sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for patch
+1 💚mvninstall3m 11sthe patch passed
+1 💚compile6m 3sthe patch passed
-0 ⚠️javac6m 3s/results-compile-javac-root.txtroot generated 13 new + 1143 unchanged - 1 fixed = 1156 total (was 1144)
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚shellcheck0m 1sNo new issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck23m 29sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 47sThe patch does not generate ASF License warnings.
48m 19s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7044/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7044
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile shellcheck shelldocs
unameLinux 07501016fb93 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / ee54b90
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-build-configuration hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7044/6/console
versionsgit=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 47sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 39sMaven dependency ordering for branch
+1 💚mvninstall3m 29sbranch-2.5 passed
+1 💚compile2m 8sbranch-2.5 passed
+1 💚javadoc2m 20sbranch-2.5 passed
+1 💚shadedjars6m 12sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall3m 0sthe patch passed
+1 💚compile2m 9sthe patch passed
+1 💚javac2m 9sthe patch passed
+1 💚javadoc2m 18sthe patch passed
+1 💚shadedjars6m 15spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit307m 24s/patch-unit-root.txtroot in the patch failed.
341m 55s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7044/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7044
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 320bc756ff7c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / ee54b90
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7044/6/testReport/
Max. process+thread count5039 (vs. ulimit of 30000)
modulesC: hbase-build-configuration hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7044/6/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 50sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep1m 3sMaven dependency ordering for branch
+1 💚mvninstall4m 57sbranch-2.5 passed
+1 💚compile2m 51sbranch-2.5 passed
+1 💚javadoc3m 29sbranch-2.5 passed
+1 💚shadedjars8m 0sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for patch
+1 💚mvninstall4m 31sthe patch passed
+1 💚compile2m 30sthe patch passed
+1 💚javac2m 30sthe patch passed
+1 💚javadoc3m 20sthe patch passed
+1 💚shadedjars7m 23spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit347m 20s/patch-unit-root.txtroot in the patch failed.
391m 22s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7044/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#7044
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 5a5012911b4d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / ee54b90
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7044/6/testReport/
Max. process+thread count4952 (vs. ulimit of 30000)
modulesC: hbase-build-configuration hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7044/6/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 45sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall2m 36sbranch-2.5 passed
+1 💚compile1m 43sbranch-2.5 passed
+1 💚javadoc2m 6sbranch-2.5 passed
+1 💚shadedjars5m 22sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall2m 32sthe patch passed
+1 💚compile1m 49sthe patch passed
+1 💚javac1m 49sthe patch passed
-0 ⚠️javadoc1m 32s/results-javadoc-javadoc-root.txtroot generated 10 new + 82 unchanged - 10 fixed = 92 total (was 92)
+1 💚shadedjars5m 27spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit370m 36sroot in the patch passed.
402m 27s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7044/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#7044
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2b58df0ea4b1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / ee54b90
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7044/6/testReport/
Max. process+thread count7713 (vs. ulimit of 30000)
modulesC: hbase-build-configuration hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7044/6/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@NihalJain

Copy link
Copy Markdown
ContributorAuthor

Thanks again @stoty for the review. Failures are random and unrelated, will merge this one too in another 2 hours!

@NihalJain
NihalJain merged commit 43e81f3 into apache:branch-2.5Jun 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@NihalJain@Apache-HBase@stoty