Skip to content

HBASE-23152 Compaction_switch does not work by RegionServer name - #713

Merged
saintstack merged 1 commit into
apache:masterfrom
karthikhw:HBASE-23152
Oct 12, 2019
Merged

HBASE-23152 Compaction_switch does not work by RegionServer name#713
saintstack merged 1 commit into
apache:masterfrom
karthikhw:HBASE-23152

Conversation

@karthikhw

@karthikhwkarthikhw commented Oct 11, 2019

Copy link
Copy Markdown
Contributor

Compaction_switch is used to stop running compaction on regionservers. This switch works good by using "compaction_switch true/false" but rather I want to stop compaction only for particular regionserver. In that case, the switch doesn't work because serverName that we want to stop is not added into CompletableFuture<List<ServerName>>. So we always get empty Future list by using RS name.

https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java#L3156

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec1m 22sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
💙mvndep0m 36sMaven dependency ordering for branch
💚mvninstall6m 17smaster passed
💚compile2m 1smaster passed
💚checkstyle2m 21smaster passed
💚shadedjars5m 21sbranch has no errors when building our shaded downstream artifacts.
💚javadoc1m 27smaster passed
💙spotbugs5m 17sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs6m 39smaster passed
_ Patch Compile Tests _
💙mvndep0m 19sMaven dependency ordering for patch
💚mvninstall5m 46sthe patch passed
💚compile1m 50sthe patch passed
💚javac1m 50sthe patch passed
💚checkstyle2m 18sthe patch passed
💚rubocop0m 4sThere were no new rubocop issues.
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars5m 19spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck18m 10sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc1m 14sthe patch passed
💚findbugs7m 7sthe patch passed
_ Other Tests _
💚unit2m 1shbase-client in the patch passed.
💔unit284m 44shbase-server in the patch failed.
💚unit9m 29shbase-shell in the patch passed.
💚asflicense1m 14sThe patch does not generate ASF License warnings.
373m 18s
ReasonTests
Failed junit testshadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
hadoop.hbase.master.TestMasterShutdown
SubsystemReport/Notes
DockerClient=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-713/1/artifact/out/Dockerfile
GITHUB PR#713
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile rubocop
unameLinux 6df9040452f7 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-713/out/precommit/personality/provided.sh
git revisionmaster / 1aee5f0
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-713/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-713/1/testReport/
Max. process+thread count5084 (vs. ulimit of 10000)
modulesC: hbase-client hbase-server hbase-shell U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-713/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.75.0
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@saintstack
saintstack merged commit c0a09cc into apache:masterOct 12, 2019
asfgit pushed a commit that referenced this pull request Oct 12, 2019
 Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Oct 12, 2019
 Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
…che#713)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
…che#713)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
(cherry picked from commit 5d5cf90)
Change-Id: Idb83721e54fbebda41af9aba963cd14790f20fc0
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@karthikhw@Apache-HBase@Apache9@saintstack