Uh oh!
There was an error while loading. Please reload this page.
HBASE-22940 Fix snapshot NoNode error - #715
Closed
sunhelly wants to merge 1 commit into
Closed
Conversation
Apache-HBase
commented
Oct 12, 2019
🎊 +1 overall
This message was automatically generated. |
wchevreuil
left a comment
Contributor
There was a problem hiding this comment.
Are you sure the error is not due a znode expiration or watcher missing expiration? I'm not sure adding extra RSes as members would sort it, the isSnaphsotDone would be called for members only, right? Can we also have tests that reproduce the condition and assert the proposed fix?
| Procedure proc = coordinator.startProcedure(this.monitor, this.snapshot.getName(), | ||
| this.snapshot.toByteArray(), Lists.newArrayList(regionServers)); | ||
| this.snapshot.toByteArray(), master.getServerManager().getOnlineServersList() | ||
| .stream().map(ServerName::toString).collect(Collectors.toList())); |
Contributor
There was a problem hiding this comment.
Do we really want to specify RSes potentially not having anything to do with the snapshot as an acquiring member?
ContributorAuthor
There was a problem hiding this comment.
The problem is that all the RSes will add themselves to zk as acquired/reached, but Procedure only set those where the table regions on as barriers. So if all barriers reached, snapshot root node will be deleted, but the none barrier RSes may write on it and throw exception.
ContributorAuthor
There was a problem hiding this comment.
the isSnaphsotDone would be called for members only, right?
I don't think so. It's just get the Procedure status.
You can see more details in the issue report.
saintstack
commented
Jan 2, 2020
Contributor
Should this go in @wchevreuil ? |
Apache-HBase
commented
May 22, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 23, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 23, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 23, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 23, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 23, 2020
🎊 +1 overall
This message was automatically generated. |
saintstack
commented
Jun 5, 2020
Contributor
See comment above @wchevreuil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.