Skip to content

HBASE-29579: AssignmentManager is trying to pick up the other cluster's meta table after HbckChore run - #7304

Merged
anmolnar merged 1 commit into
apache:HBASE-29081from
Kota-SH:HBASE-29291-ref-meta
Sep 19, 2025
Merged

HBASE-29579: AssignmentManager is trying to pick up the other cluster's meta table after HbckChore run#7304
anmolnar merged 1 commit into
apache:HBASE-29081from
Kota-SH:HBASE-29291-ref-meta

Conversation

@Kota-SH

Copy link
Copy Markdown
Contributor

@anmolnaranmolnar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add unit tests to TestFSUtils and TestFSTableDescriptors.

@anmolnaranmolnar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need a new test file, because the new tests could be added to existing test files. I'm not sure though, please take a look.

@kgeiszkgeisz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Apache-HBase

This comment has been minimized.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ HBASE-29081 Compile Tests _
+1 💚mvninstall3m 26sHBASE-29081 passed
+1 💚compile3m 37sHBASE-29081 passed
-0 ⚠️checkstyle0m 15s/buildtool-branch-checkstyle-hbase-server.txtThe patch fails to run checkstyle in hbase-server
+1 💚spotbugs1m 39sHBASE-29081 passed
+1 💚spotless0m 51sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 9sthe patch passed
+1 💚compile3m 26sthe patch passed
+1 💚javac3m 26sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 14s/buildtool-patch-checkstyle-hbase-server.txtThe patch fails to run checkstyle in hbase-server
+1 💚spotbugs1m 44sthe patch passed
+1 💚hadoopcheck12m 21sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 46spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
39m 57s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7304/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7304
JIRA IssueHBASE-29579
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux f3e0e9a84a1e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-29081 / 75956d4
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7304/3/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ HBASE-29081 Compile Tests _
+1 💚mvninstall3m 24sHBASE-29081 passed
+1 💚compile1m 0sHBASE-29081 passed
+1 💚javadoc0m 30sHBASE-29081 passed
+1 💚shadedjars6m 18sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 10sthe patch passed
+1 💚compile1m 0sthe patch passed
+1 💚javac1m 0sthe patch passed
+1 💚javadoc0m 28sthe patch passed
+1 💚shadedjars6m 12spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit285m 9s/patch-unit-hbase-server.txthbase-server in the patch failed.
312m 41s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7304/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7304
JIRA IssueHBASE-29579
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 00a18dc006c7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-29081 / 75956d4
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7304/3/testReport/
Max. process+thread count4299 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7304/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@kgeiszkgeisz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New additions LGTM

@anmolnar
anmolnar merged commit 1a0434d into apache:HBASE-29081Sep 19, 2025
1 check failed
@anmolnar

Copy link
Copy Markdown
Contributor

Merged. Thanks @Kota-SH !

anmolnar pushed a commit that referenced this pull request Mar 13, 2026
anmolnar pushed a commit that referenced this pull request Apr 8, 2026
anmolnar pushed a commit that referenced this pull request Apr 10, 2026
kgeisz pushed a commit to kgeisz/hbase that referenced this pull request Apr 29, 2026
anmolnar pushed a commit that referenced this pull request May 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Kota-SH@Apache-HBase@anmolnar@kgeisz