Skip to content

HBASE-23185 Fix high cpu usage because getTable()#put() gets config value every time - #731

Merged
saintstack merged 2 commits into
apache:branch-1from
bitterfox:HBASE-23185-branch-1
Oct 21, 2019
Merged

HBASE-23185 Fix high cpu usage because getTable()#put() gets config value every time#731
saintstack merged 2 commits into
apache:branch-1from
bitterfox:HBASE-23185-branch-1

Conversation

@bitterfox

@bitterfoxbitterfox commented Oct 18, 2019

Copy link
Copy Markdown
Contributor

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 39sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💛test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
💚mvninstall10m 12sbranch-1 passed
💚compile0m 20sbranch-1 passed with JDK v1.8.0_232
💚compile0m 23sbranch-1 passed with JDK v1.7.0_242
💚checkstyle0m 43sbranch-1 passed
💚shadedjars2m 50sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 28sbranch-1 passed with JDK v1.8.0_232
💚javadoc0m 25sbranch-1 passed with JDK v1.7.0_242
💙spotbugs1m 31sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs1m 27sbranch-1 passed
_ Patch Compile Tests _
💚mvninstall1m 57sthe patch passed
💚compile0m 19sthe patch passed with JDK v1.8.0_232
💚javac0m 19sthe patch passed
💚compile0m 23sthe patch passed with JDK v1.7.0_242
💚javac0m 23sthe patch passed
💔checkstyle0m 38shbase-client: The patch generated 7 new + 142 unchanged - 1 fixed = 149 total (was 143)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars2m 48spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck5m 3sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
💚javadoc0m 20sthe patch passed with JDK v1.8.0_232
💚javadoc0m 25sthe patch passed with JDK v1.7.0_242
💚findbugs1m 31sthe patch passed
_ Other Tests _
💚unit2m 38shbase-client in the patch passed.
💚asflicense0m 18sThe patch does not generate ASF License warnings.
37m 28s
SubsystemReport/Notes
DockerClient=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/1/artifact/out/Dockerfile
GITHUB PR#731
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux ba66d440b7da 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-731/out/precommit/personality/provided.sh
git revisionbranch-1 / 425d84d
Default Java1.7.0_242
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/1/artifact/out/diff-checkstyle-hbase-client.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/1/testReport/
Max. process+thread count148 (vs. ulimit of 10000)
modulesC: hbase-client U: hbase-client
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/1/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
💙reexec0m 40sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💛test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
💚mvninstall8m 37sbranch-1 passed
💚compile0m 19sbranch-1 passed with JDK v1.8.0_232
💚compile0m 23sbranch-1 passed with JDK v1.7.0_242
💚checkstyle0m 41sbranch-1 passed
💚shadedjars2m 54sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 26sbranch-1 passed with JDK v1.8.0_232
💚javadoc0m 27sbranch-1 passed with JDK v1.7.0_242
💙spotbugs1m 30sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs1m 28sbranch-1 passed
_ Patch Compile Tests _
💚mvninstall1m 56sthe patch passed
💚compile0m 21sthe patch passed with JDK v1.8.0_232
💚javac0m 21sthe patch passed
💚compile0m 24sthe patch passed with JDK v1.7.0_242
💚javac0m 24sthe patch passed
💚checkstyle0m 36shbase-client: The patch generated 0 new + 142 unchanged - 1 fixed = 142 total (was 143)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars2m 45spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck5m 0sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
💚javadoc0m 20sthe patch passed with JDK v1.8.0_232
💚javadoc0m 27sthe patch passed with JDK v1.7.0_242
💚findbugs1m 30sthe patch passed
_ Other Tests _
💚unit2m 39shbase-client in the patch passed.
💚asflicense0m 17sThe patch does not generate ASF License warnings.
35m 37s
SubsystemReport/Notes
DockerClient=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/2/artifact/out/Dockerfile
GITHUB PR#731
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 64ed37c21f2a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-731/out/precommit/personality/provided.sh
git revisionbranch-1 / 924e0f7
Default Java1.7.0_242
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/2/testReport/
Max. process+thread count148 (vs. ulimit of 10000)
modulesC: hbase-client U: hbase-client
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/2/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@saintstack
saintstack merged commit ce65db3 into apache:branch-1Oct 21, 2019
bitterfox added a commit to bitterfox/hbase that referenced this pull request Oct 22, 2019
bitterfox added a commit to bitterfox/hbase that referenced this pull request Oct 22, 2019
bitterfox added a commit to bitterfox/hbase that referenced this pull request Oct 22, 2019
asfgit pushed a commit that referenced this pull request Oct 26, 2019
…config value every time (#731)"
Causes failure in TestMasterNoCluster and TestCatalogJanitor
This reverts commit ce65db3.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bitterfox@Apache-HBase@saintstack