Skip to content

Backport: "HBASE-29448: Modern backup failures can cause backup system to lock up" - #7317

Open
hgromer wants to merge 1 commit into
apache:branch-2from
hgromer:HBASE-29448-branch-2
Open

Backport: "HBASE-29448: Modern backup failures can cause backup system to lock up"#7317
hgromer wants to merge 1 commit into
apache:branch-2from
hgromer:HBASE-29448-branch-2

Conversation

@hgromer

@hgromerhgromer commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@hgromerhgromer changed the title "HBase Backport: HBASE-29448: Modern backup failures can cause backup system to lock up"Backport: "HBASE-29448: Modern backup failures can cause backup system to lock up"Sep 17, 2025
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@PDavidPDavid mentioned this pull request Sep 18, 2025
Merged
@hgromer
hgromerforce-pushed the HBASE-29448-branch-2 branch 2 times, most recently from 5c6bcd3 to 8187004CompareSeptember 18, 2025 12:33
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
hgromer
hgromer commented Sep 24, 2025
View reviewed changes
Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
listSnapshots().stream().filter(s -> s.getName().equals(snapshotName)).findFirst()
.orElseThrow(() -> new IOException("Snapshot " + snapshotName + " not found"));
TableName tn = snapshot.getTableName();
disableTable(tn);

@hgromerhgromerSep 24, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same behavior as the logic we had in the BackupSystemTable that we're replacing. Does it makse sense to include this behavior? Or should this method do nothing by default?

@Apache-HBase

Apache-HBase commented Sep 24, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 50sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 1scodespell was not available.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+0 🆗buf0m 1sbuf was not available.
+0 🆗buf0m 1sbuf was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 15sbranch-2 passed
+1 💚compile5m 35sbranch-2 passed
+1 💚checkstyle1m 50sbranch-2 passed
+1 💚spotbugs5m 37sbranch-2 passed
+1 💚spotless0m 48sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 2sthe patch passed
+1 💚compile5m 38sthe patch passed
+1 💚cc5m 38sthe patch passed
+1 💚javac5m 38sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle1m 45sthe patch passed
+1 💚spotbugs6m 22sthe patch passed
+1 💚hadoopcheck16m 55sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚hbaseprotoc2m 3sthe patch passed
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 48sThe patch does not generate ASF License warnings.
58m 45s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7317
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
unameLinux 5b330ee0c3a2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6d32ea7
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count82 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 24, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 35sMaven dependency ordering for branch
+1 💚mvninstall3m 32sbranch-2 passed
+1 💚compile2m 34sbranch-2 passed
+1 💚javadoc1m 28sbranch-2 passed
+1 💚shadedjars6m 32sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 10sthe patch passed
+1 💚compile2m 38sthe patch passed
+1 💚javac2m 38sthe patch passed
+1 💚javadoc1m 24sthe patch passed
+1 💚shadedjars6m 26spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 31shbase-protocol-shaded in the patch passed.
+1 💚unit8m 6shbase-client in the patch passed.
+1 💚unit205m 3shbase-server in the patch passed.
+1 💚unit6m 49shbase-thrift in the patch passed.
+1 💚unit10m 37shbase-backup in the patch passed.
265m 40s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7317
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 9f650e840c22 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6d32ea7
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/testReport/
Max. process+thread count3557 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 24, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 49sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 44sMaven dependency ordering for branch
+1 💚mvninstall2m 55sbranch-2 passed
+1 💚compile2m 5sbranch-2 passed
+1 💚javadoc1m 25sbranch-2 passed
+1 💚shadedjars5m 43sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 34sthe patch passed
+1 💚compile2m 6sthe patch passed
+1 💚javac2m 6sthe patch passed
+1 💚javadoc1m 24sthe patch passed
+1 💚shadedjars5m 36spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 25shbase-protocol-shaded in the patch passed.
+1 💚unit7m 54shbase-client in the patch passed.
+1 💚unit217m 57shbase-server in the patch passed.
+1 💚unit7m 23shbase-thrift in the patch passed.
+1 💚unit11m 10shbase-backup in the patch passed.
276m 34s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#7317
Optional Testsjavac javadoc unit compile shadedjars
unameLinux c17ef50a9b06 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6d32ea7
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/testReport/
Max. process+thread count3350 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 24, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 45sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 25sbranch-2 passed
+1 💚compile2m 28sbranch-2 passed
+1 💚javadoc1m 25sbranch-2 passed
+1 💚shadedjars6m 46sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall3m 18sthe patch passed
+1 💚compile2m 30sthe patch passed
+1 💚javac2m 30sthe patch passed
+1 💚javadoc1m 22sthe patch passed
+1 💚shadedjars6m 46spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 32shbase-protocol-shaded in the patch passed.
+1 💚unit8m 7shbase-client in the patch passed.
+1 💚unit215m 58shbase-server in the patch passed.
+1 💚unit7m 2shbase-thrift in the patch passed.
+1 💚unit11m 22shbase-backup in the patch passed.
277m 57s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#7317
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 7fc331655345 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6d32ea7
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/testReport/
Max. process+thread count3625 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7317/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hgromer@Apache-HBase@rmdmattingly