Skip to content

HBASE-28969 Move HFileLink file creations to SFT (#6459) - #7377

Merged
apurtell merged 1 commit into
apache:branch-2.6from
gvprathyusha6:HBASE-28969-2.6
Mar 12, 2026
Merged

HBASE-28969 Move HFileLink file creations to SFT (#6459)#7377
apurtell merged 1 commit into
apache:branch-2.6from
gvprathyusha6:HBASE-28969-2.6

Conversation

@gvprathyusha6

@gvprathyusha6gvprathyusha6 commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

This is a cherry-pick of #6459 on branch2.6.

Post HBASE-28564, HStoreFile creation is SFT aware and Reference file creations are moved to SFT.
Current change refactors all HFileLink file creations to SFT, so as to support Virtual links creation via FSFT in HBASE-27826

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@apurtell

Copy link
Copy Markdown
Contributor

@gvprathyusha6 should this be closed?

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 49sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2.6 Compile Tests _
+1 💚mvninstall3m 6sbranch-2.6 passed
+1 💚compile2m 58sbranch-2.6 passed
+1 💚checkstyle0m 38sbranch-2.6 passed
+1 💚spotbugs1m 32sbranch-2.6 passed
+1 💚spotless0m 44sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 7sthe patch passed
+1 💚compile3m 0sthe patch passed
+1 💚javac3m 0sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 38s/results-checkstyle-hbase-server.txthbase-server: The patch generated 1 new + 47 unchanged - 1 fixed = 48 total (was 48)
+1 💚spotbugs1m 43sthe patch passed
+1 💚hadoopcheck16m 48sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 9sThe patch does not generate ASF License warnings.
37m 58s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7377
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux e8584e28f699 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / afe8e9a
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/3/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@gvprathyusha6

Copy link
Copy Markdown
ContributorAuthor

@gvprathyusha6 should this be closed?

@apurtell this is a cherry-pick of #6459 on branch2.6, marked this as ready for review now.

@gvprathyusha6
gvprathyusha6 marked this pull request as ready for review December 19, 2025 17:56
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 54sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚mvninstall2m 47sbranch-2.6 passed
+1 💚compile0m 41sbranch-2.6 passed
+1 💚javadoc0m 25sbranch-2.6 passed
+1 💚shadedjars5m 32sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 28sthe patch passed
+1 💚compile0m 43sthe patch passed
+1 💚javac0m 43sthe patch passed
-0 ⚠️javadoc0m 25s/results-javadoc-javadoc-hbase-server.txthbase-server generated 2 new + 31 unchanged - 0 fixed = 33 total (was 31)
+1 💚shadedjars5m 31spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit207m 44shbase-server in the patch passed.
231m 44s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#7377
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 90d118b18021 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / afe8e9a
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/3/testReport/
Max. process+thread count3190 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 48sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚mvninstall3m 31sbranch-2.6 passed
+1 💚compile0m 49sbranch-2.6 passed
+1 💚javadoc0m 28sbranch-2.6 passed
+1 💚shadedjars6m 35sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 55sthe patch passed
+1 💚compile0m 51sthe patch passed
+1 💚javac0m 51sthe patch passed
-0 ⚠️javadoc0m 26s/results-javadoc-javadoc-hbase-server.txthbase-server generated 2 new + 95 unchanged - 2 fixed = 97 total (was 97)
+1 💚shadedjars6m 35spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit212m 37s/patch-unit-hbase-server.txthbase-server in the patch failed.
240m 3s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#7377
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 0d659d3fe69d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / afe8e9a
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/3/testReport/
Max. process+thread count3310 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 1sDocker mode activated.
-0 ⚠️yetus0m 8sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚mvninstall4m 8sbranch-2.6 passed
+1 💚compile1m 14sbranch-2.6 passed
+1 💚javadoc0m 37sbranch-2.6 passed
+1 💚shadedjars7m 26sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 48sthe patch passed
+1 💚compile1m 12sthe patch passed
+1 💚javac1m 12sthe patch passed
-0 ⚠️javadoc0m 33s/results-javadoc-javadoc-hbase-server.txthbase-server generated 2 new + 60 unchanged - 0 fixed = 62 total (was 60)
+1 💚shadedjars7m 6spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit239m 8shbase-server in the patch passed.
271m 33s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7377
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 45be985c5e14 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / afe8e9a
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/3/testReport/
Max. process+thread count3075 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Co-authored-by: Prathyusha Garre <pgarre@pgarre-ltmqft8.internal.salesforce.com>
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 34sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2.6 Compile Tests _
+1 💚mvninstall4m 3sbranch-2.6 passed
+1 💚compile2m 49sbranch-2.6 passed
+1 💚checkstyle0m 34sbranch-2.6 passed
+1 💚spotbugs1m 33sbranch-2.6 passed
+1 💚spotless0m 53sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 22sthe patch passed
+1 💚compile2m 53sthe patch passed
+1 💚javac2m 53sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 35s/results-checkstyle-hbase-server.txthbase-server: The patch generated 1 new + 47 unchanged - 1 fixed = 48 total (was 48)
+1 💚spotbugs1m 32sthe patch passed
+1 💚hadoopcheck16m 48sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚spotless0m 51spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
39m 7s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7377
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 971af515ea22 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / b9bdae7
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/4/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 34sDocker mode activated.
-0 ⚠️yetus0m 8sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚mvninstall3m 31sbranch-2.6 passed
+1 💚compile0m 40sbranch-2.6 passed
+1 💚javadoc0m 29sbranch-2.6 passed
+1 💚shadedjars4m 53sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 56sthe patch passed
+1 💚compile0m 47sthe patch passed
+1 💚javac0m 47sthe patch passed
-0 ⚠️javadoc0m 25s/results-javadoc-javadoc-hbase-server.txthbase-server generated 2 new + 31 unchanged - 0 fixed = 33 total (was 31)
+1 💚shadedjars4m 53spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit192m 24shbase-server in the patch passed.
216m 17s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#7377
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 108bcba42e75 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / b9bdae7
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/4/testReport/
Max. process+thread count3339 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚mvninstall3m 38sbranch-2.6 passed
+1 💚compile0m 58sbranch-2.6 passed
+1 💚javadoc0m 29sbranch-2.6 passed
+1 💚shadedjars6m 45sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 8sthe patch passed
+1 💚compile0m 52sthe patch passed
+1 💚javac0m 52sthe patch passed
-0 ⚠️javadoc0m 26s/results-javadoc-javadoc-hbase-server.txthbase-server generated 2 new + 95 unchanged - 2 fixed = 97 total (was 97)
+1 💚shadedjars6m 41spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit212m 38shbase-server in the patch passed.
241m 41s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#7377
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 86b23768ad62 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / b9bdae7
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/4/testReport/
Max. process+thread count3229 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 10sDocker mode activated.
-0 ⚠️yetus0m 8sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚mvninstall5m 35sbranch-2.6 passed
+1 💚compile2m 0sbranch-2.6 passed
+1 💚javadoc1m 10sbranch-2.6 passed
+1 💚shadedjars10m 53sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall4m 59sthe patch passed
+1 💚compile1m 25sthe patch passed
+1 💚javac1m 25sthe patch passed
-0 ⚠️javadoc0m 42s/results-javadoc-javadoc-hbase-server.txthbase-server generated 2 new + 60 unchanged - 0 fixed = 62 total (was 60)
+1 💚shadedjars9m 20spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit215m 13shbase-server in the patch passed.
257m 38s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7377
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 0cdabb78b158 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / b9bdae7
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/4/testReport/
Max. process+thread count3303 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7377/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@apurtell

Copy link
Copy Markdown
Contributor

Will merge this soon if no objection.

@apurtell
apurtell merged commit 4c83f30 into apache:branch-2.6Mar 12, 2026
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@gvprathyusha6@Apache-HBase@apurtell