Skip to content

HBASE-28564 Refactor direct interactions of Reference file creations … - #7382

Merged
apurtell merged 1 commit into
apache:branch-2.6from
gvprathyusha6:HBASE-28564_2.6
Oct 20, 2025
Merged

HBASE-28564 Refactor direct interactions of Reference file creations …#7382
apurtell merged 1 commit into
apache:branch-2.6from
gvprathyusha6:HBASE-28564_2.6

Conversation

@gvprathyusha6

@gvprathyusha6gvprathyusha6 commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

…to SFT interface (#5939)

Signed-off-by: Andrew Purtell apurtell@apache.org

Conflicts:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerRegionReplicaUtil.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/janitor/TestCatalogJanitor.java
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobFileCache.java
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobStoreCompaction.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MockHStoreFile.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionFileSystem.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@gvprathyusha6Prathyusha Garre
HBASE-28564 Refactor direct interactions of Reference file creations …
f00066a
…to SFT interface (apache#5939)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Conflicts:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerRegionReplicaUtil.java
hbase-server/src/test/java/org/apache/hadoop/hbase/master/janitor/TestCatalogJanitor.java
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobFileCache.java
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobStoreCompaction.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MockHStoreFile.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionFileSystem.java
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java
@Apache-HBase

Apache-HBase commented Oct 14, 2025

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2.6 Compile Tests _
+1 💚mvninstall4m 28sbranch-2.6 passed
+1 💚compile4m 9sbranch-2.6 passed
+1 💚checkstyle0m 54sbranch-2.6 passed
+1 💚spotbugs2m 23sbranch-2.6 passed
-1 ❌spotless1m 4sbranch has 21 errors when running spotless:check, run spotless:apply to fix.
_ Patch Compile Tests _
+1 💚mvninstall4m 46sthe patch passed
+1 💚compile4m 9sthe patch passed
-0 ⚠️javac4m 9s/results-compile-javac-hbase-server.txthbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 44s/results-checkstyle-hbase-server.txthbase-server: The patch generated 1 new + 147 unchanged - 1 fixed = 148 total (was 148)
+1 💚spotbugs2m 13sthe patch passed
+1 💚hadoopcheck23m 55sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚spotless0m 56spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
53m 29s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7382/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7382
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux c7fbcd8ac96f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / f00066a
Default JavaEclipse Adoptium-11.0.23+9
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7382/3/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count77 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7382/3/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 14, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 51sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚mvninstall3m 37sbranch-2.6 passed
+1 💚compile0m 57sbranch-2.6 passed
+1 💚javadoc0m 29sbranch-2.6 passed
+1 💚shadedjars6m 31sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 9sthe patch passed
+1 💚compile0m 57sthe patch passed
+1 💚javac0m 57sthe patch passed
-0 ⚠️javadoc0m 27s/results-javadoc-javadoc-hbase-server.txthbase-server generated 6 new + 57 unchanged - 0 fixed = 63 total (was 57)
+1 💚shadedjars6m 25spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit209m 37shbase-server in the patch passed.
237m 55s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7382/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7382
Optional Testsjavac javadoc unit compile shadedjars
unameLinux f59b7c6ef1e1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / f00066a
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7382/3/testReport/
Max. process+thread count3453 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7382/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 14, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 41sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚mvninstall3m 10sbranch-2.6 passed
+1 💚compile0m 53sbranch-2.6 passed
+1 💚javadoc0m 27sbranch-2.6 passed
+1 💚shadedjars6m 51sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 4sthe patch passed
+1 💚compile0m 52sthe patch passed
+1 💚javac0m 52sthe patch passed
-0 ⚠️javadoc0m 27s/results-javadoc-javadoc-hbase-server.txthbase-server generated 5 new + 92 unchanged - 5 fixed = 97 total (was 97)
+1 💚shadedjars7m 0spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit232m 48shbase-server in the patch passed.
261m 54s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7382/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#7382
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 9889c6e5fbf2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / f00066a
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7382/3/testReport/
Max. process+thread count3247 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7382/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 14, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 25sDocker mode activated.
-0 ⚠️yetus0m 8sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚mvninstall4m 44sbranch-2.6 passed
+1 💚compile1m 19sbranch-2.6 passed
+1 💚javadoc0m 44sbranch-2.6 passed
+1 💚shadedjars7m 52sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall24m 36sthe patch passed
+1 💚compile2m 1sthe patch passed
+1 💚javac2m 1sthe patch passed
-0 ⚠️javadoc0m 29s/results-javadoc-javadoc-hbase-server.txthbase-server generated 4 new + 27 unchanged - 0 fixed = 31 total (was 27)
+1 💚shadedjars6m 31spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit228m 22shbase-server in the patch passed.
285m 35s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7382/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#7382
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 53f4bcf82bc0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / f00066a
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7382/3/testReport/
Max. process+thread count3149 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7382/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

apurtell
apurtell approved these changes Oct 14, 2025
View reviewed changes

@apurtellapurtell left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

The backport looks good to me.

The test failure ("Can't get Kerberos realm" in TestSecureNettyRpcServer) seems unrelated. Latest test results look good.

@apurtell
apurtell merged commit 4cad08d into apache:branch-2.6Oct 20, 2025
1 check failed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apurtellapurtellapurtell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gvprathyusha6@Apache-HBase@apurtell