HBASE-23181 Blocked WAL archive: "LogRoller: Failed to schedule flush of XXXX, because it is not online on us"

[saintstack]

… of XXXX, because it is not online on us"

Fix is moving a line in HRegion to close a gap that would allow an old
edit to sneak into the backing SequenceIdAccounting datastructure.
The below line gets moved up before wal.startCacheFlush:

•  flushOpSeqId = getNextSequenceId(wal);
  

We change the LogRoller constructor to remove redundant param. It will
also call the temporary,ugly purge method (To be removed if we've found
fix...). Because of constructor chagne, need to change also
TestFailedAppendAndSync, TestWALLockup, TestAsyncFSWAL &
WALPerformanceEvaluation.java

We add a purge method called when something is wrong to AbstractFSWAL.java
Need to be removed when 'fix' is in place.

SequenceIdAccounting gets a purge method called when we find lagging
records.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
💙	reexec	0m 35s	Docker mode activated.
		_ Prechecks _
💚	dupname	0m 0s	No case conflicting files found.
💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
💚	@author	0m 0s	The patch does not contain any @author tags.
💚	test4tests	0m 0s	The patch appears to include 4 new or modified test files.
		_ branch-2 Compile Tests _
💚	mvninstall	6m 53s	branch-2 passed
💚	compile	1m 12s	branch-2 passed
💚	checkstyle	1m 54s	branch-2 passed
💚	shadedjars	5m 49s	branch has no errors when building our shaded downstream artifacts.
💚	javadoc	0m 52s	branch-2 passed
💙	spotbugs	4m 57s	Used deprecated FindBugs config; considering switching to SpotBugs.
💚	findbugs	4m 54s	branch-2 passed
		_ Patch Compile Tests _
💚	mvninstall	6m 12s	the patch passed
💚	compile	1m 11s	the patch passed
💚	javac	1m 12s	the patch passed
💚	checkstyle	2m 11s	hbase-server: The patch generated 0 new + 320 unchanged - 9 fixed = 320 total (was 329)
💚	whitespace	0m 0s	The patch has no whitespace issues.
💚	shadedjars	5m 35s	patch has no errors when building our shaded downstream artifacts.
💚	hadoopcheck	20m 19s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚	javadoc	0m 36s	the patch passed
💔	findbugs	3m 31s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
💚	unit	166m 8s	hbase-server in the patch passed.
💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		236m 39s

Reason	Tests
FindBugs	module:hbase-server
	Should org.apache.hadoop.hbase.regionserver.LogRoller$NotOnlineException be a static inner class? At LogRoller.java:inner class? At LogRoller.java:[lines 221-223]

Subsystem	Report/Notes
Docker	Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-742/1/artifact/out/Dockerfile
GITHUB PR	#742
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 2fc48ea937f6 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-742/out/precommit/personality/provided.sh
git revision	branch-2 / ee6897b
Default Java	1.8.0_181
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-742/1/artifact/out/new-findbugs-hbase-server.html
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-742/1/testReport/
Max. process+thread count	4269 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-742/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

[Apache9]

We use #753 finally.