Skip to content

Make the keymeta table initialization happen in a predictable manner - #7433

Merged
virajjasani merged 3 commits into
apache:HBASE-29368-key-management-featurefrom
haridsv:fix-keymeta-init-order
Nov 5, 2025
Merged

Make the keymeta table initialization happen in a predictable manner#7433
virajjasani merged 3 commits into
apache:HBASE-29368-key-management-featurefrom
haridsv:fix-keymeta-init-order

Conversation

@haridsv

@haridsvharidsv commented Nov 3, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

During the system boot up, we need to ensure that keymeta table regions are online before any of the encrypted stores are opened for assignment, if not we can have a race condition that can cause the assignments to fail. This change introduces a priority check for hbase:keymeta table on the lines of hbase:meta.

Addendum to PR #7421

@Apache-HBase

Apache-HBase commented Nov 3, 2025

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 39sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗buf0m 0sbuf was not available.
+0 🆗buf0m 0sbuf was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall4m 22sHBASE-29368-key-management-feature passed
+1 💚compile5m 33sHBASE-29368-key-management-feature passed
+1 💚checkstyle1m 11sHBASE-29368-key-management-feature passed
+1 💚spotbugs5m 8sHBASE-29368-key-management-feature passed
-1 ❌spotless0m 53sbranch has 22 errors when running spotless:check, run spotless:apply to fix.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 23sthe patch passed
+1 💚compile5m 27sthe patch passed
+1 💚cc5m 27sthe patch passed
+1 💚javac5m 27sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle1m 1sthe patch passed
+1 💚spotbugs5m 42sthe patch passed
+1 💚hadoopcheck18m 55sPatch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚hbaseprotoc1m 54sthe patch passed
+1 💚spotless0m 56spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 36sThe patch does not generate ASF License warnings.
68m 5s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7433
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
unameLinux 0493c21bcd35 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-29368-key-management-feature / 71e37da
Default JavaEclipse Adoptium-17.0.11+9
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/1/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-procedure hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 3, 2025

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 54sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall4m 32sHBASE-29368-key-management-feature passed
+1 💚compile2m 13sHBASE-29368-key-management-feature passed
+1 💚javadoc1m 0sHBASE-29368-key-management-feature passed
+1 💚shadedjars7m 19sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 27sthe patch passed
+1 💚compile2m 11sthe patch passed
+1 💚javac2m 11sthe patch passed
+1 💚javadoc1m 4sthe patch passed
+1 💚shadedjars7m 6spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 45shbase-protocol-shaded in the patch passed.
+1 💚unit1m 54shbase-procedure in the patch passed.
-1 ❌unit238m 22s/patch-unit-hbase-server.txthbase-server in the patch failed.
277m 53s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7433
Optional Testsjavac javadoc unit compile shadedjars
unameLinux fefb50ccd632 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-29368-key-management-feature / 71e37da
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/1/testReport/
Max. process+thread count4497 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-procedure hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 3, 2025

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 13sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗buf0m 0sbuf was not available.
+0 🆗buf0m 0sbuf was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall5m 15sHBASE-29368-key-management-feature passed
+1 💚compile9m 14sHBASE-29368-key-management-feature passed
+1 💚checkstyle2m 31sHBASE-29368-key-management-feature passed
+1 💚spotbugs11m 12sHBASE-29368-key-management-feature passed
-1 ❌spotless1m 21sbranch has 22 errors when running spotless:check, run spotless:apply to fix.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall7m 4sthe patch passed
+1 💚compile9m 20sthe patch passed
+1 💚cc9m 20sthe patch passed
+1 💚javac9m 20sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle2m 30sthe patch passed
+1 💚spotbugs12m 1sthe patch passed
+1 💚hadoopcheck18m 17sPatch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚hbaseprotoc3m 35sthe patch passed
+1 💚spotless1m 22spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense1m 8sThe patch does not generate ASF License warnings.
98m 12s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7433
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
unameLinux 79cd92708ba9 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-29368-key-management-feature / 6080077
Default JavaEclipse Adoptium-17.0.11+9
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/2/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count71 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-procedure hbase-server hbase-thrift U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/2/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 4, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 33sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall3m 34sHBASE-29368-key-management-feature passed
+1 💚compile2m 33sHBASE-29368-key-management-feature passed
+1 💚javadoc1m 38sHBASE-29368-key-management-feature passed
+1 💚shadedjars6m 18sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 8sthe patch passed
+1 💚compile2m 32sthe patch passed
+1 💚javac2m 32sthe patch passed
+1 💚javadoc1m 35sthe patch passed
+1 💚shadedjars6m 11spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 33shbase-protocol-shaded in the patch passed.
+1 💚unit1m 37shbase-client in the patch passed.
+1 💚unit1m 26shbase-procedure in the patch passed.
+1 💚unit243m 31shbase-server in the patch passed.
+1 💚unit7m 30shbase-thrift in the patch passed.
288m 34s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7433
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 586d270e6e99 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-29368-key-management-feature / 6080077
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/2/testReport/
Max. process+thread count3890 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-procedure hbase-server hbase-thrift U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7433/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani
virajjasani merged commit c22e111 into apache:HBASE-29368-key-management-featureNov 5, 2025
1 check failed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@virajjasanivirajjasanivirajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@haridsv@Apache-HBase@virajjasani