Skip to content

HBASE-28158 Decouple RIT list management from TRSP - #7447

Closed
Umeshkumar9414 wants to merge 9 commits into
apache:branch-3from
Umeshkumar9414:HBASE-28158_branch_3
Closed

HBASE-28158 Decouple RIT list management from TRSP#7447
Umeshkumar9414 wants to merge 9 commits into
apache:branch-3from
Umeshkumar9414:HBASE-28158_branch_3

Conversation

@Umeshkumar9414

Copy link
Copy Markdown
Contributor

PR for master - #7375

@Umeshkumar9414
Umeshkumar9414 marked this pull request as ready for review November 7, 2025 06:25
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Umeshkumar9414

Copy link
Copy Markdown
ContributorAuthor

I didn't understand what is javac subsystem is and why logfile is showing a different warning.
I tried to find the command to print all the warnings but unable to find. (mvn package -PerrorProne is not printing these warnings)

@Apache-HBase

This comment has been minimized.

@apurtell

apurtell commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

Latest precommit results look good.

The warning was from error prone regarding HbckChore.java

HbckChore.java:[245,37] [JdkObsolete] It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not.

Unless you added a use of a LinkedList this isn't your issue.

I don't know why the results may be unstable.

@Umeshkumar9414

Copy link
Copy Markdown
ContributorAuthor

Unless you added a use of a LinkedList this isn't your issue.

No, I didn't added it. We should be good.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 34sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-3 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 27sbranch-3 passed
+1 💚compile3m 46sbranch-3 passed
+1 💚checkstyle1m 11sbranch-3 passed
+1 💚spotbugs2m 3sbranch-3 passed
+1 💚spotless0m 51sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 6sthe patch passed
+1 💚compile3m 46sthe patch passed
+1 💚javac3m 46sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 59shbase-server: The patch generated 0 new + 45 unchanged - 2 fixed = 45 total (was 47)
+1 💚checkstyle0m 9sThe patch passed checkstyle in hbase-testing-util
+1 💚spotbugs2m 16sthe patch passed
+1 💚hadoopcheck12m 8sPatch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚spotless0m 45spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 18sThe patch does not generate ASF License warnings.
43m 41s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7447/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7447
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 344dde523ae6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / b13c5a3
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-server hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7447/4/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Umeshkumar9414

Copy link
Copy Markdown
ContributorAuthor

Cherry-picked new changes from #7375

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-3 Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall3m 22sbranch-3 passed
+1 💚compile1m 13sbranch-3 passed
+1 💚javadoc0m 41sbranch-3 passed
+1 💚shadedjars6m 6sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 56sthe patch passed
+1 💚compile1m 13sthe patch passed
+1 💚javac1m 13sthe patch passed
+1 💚javadoc0m 40sthe patch passed
+1 💚shadedjars5m 59spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit211m 25shbase-server in the patch passed.
+1 💚unit2m 16shbase-testing-util in the patch passed.
242m 17s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7447/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7447
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 209c6dc4e647 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / b13c5a3
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7447/4/testReport/
Max. process+thread count3850 (vs. ulimit of 30000)
modulesC: hbase-server hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7447/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9 pushed a commit that referenced this pull request Dec 1, 2025
Close#7447
Co-authored-by: ukumawat <ukumawat@salesforce.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 7d604d4)
@Apache9

Copy link
Copy Markdown
Contributor

Closed via 0f65e47.

@Apache9Apache9 closed this Dec 1, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Umeshkumar9414@Apache-HBase@apurtell@Apache9