Skip to content

HBASE-29666:Additional key management APIs - #7460

Merged
virajjasani merged 44 commits into
apache:HBASE-29368-key-management-featurefrom
haridsv:addl-keymgmt-apis
Nov 28, 2025
Merged

HBASE-29666:Additional key management APIs#7460
virajjasani merged 44 commits into
apache:HBASE-29368-key-management-featurefrom
haridsv:addl-keymgmt-apis

Conversation

@haridsv

Copy link
Copy Markdown
Contributor

This PR implements the rest of the planned key management APIs and adds full test coverage for these APIs. It also fixes a few bugs and other minor issues and also makes some generic code quality improvements on top of the open PR #7421.

HBASE-29666

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗buf0m 0sbuf was not available.
+0 🆗buf0m 0sbuf was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall3m 31sHBASE-29368-key-management-feature passed
+1 💚compile6m 50sHBASE-29368-key-management-feature passed
+1 💚checkstyle3m 3sHBASE-29368-key-management-feature passed
+1 💚spotbugs6m 44sHBASE-29368-key-management-feature passed
+1 💚spotless0m 48sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 2sthe patch passed
+1 💚compile6m 44sthe patch passed
+1 💚cc6m 44sthe patch passed
-0 ⚠️javac0m 43s/results-compile-javac-hbase-common.txthbase-common generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 9sThe patch passed checkstyle in hbase-protocol-shaded
+1 💚checkstyle0m 14sThe patch passed checkstyle in hbase-common
+1 💚checkstyle0m 19sThe patch passed checkstyle in hbase-client
+1 💚checkstyle1m 0shbase-server: The patch generated 0 new + 9 unchanged - 1 fixed = 9 total (was 10)
+1 💚checkstyle1m 11sThe patch passed checkstyle in hbase-thrift
+1 💚checkstyle0m 8sThe patch passed checkstyle in hbase-shell
-0 ⚠️rubocop0m 28s/results-rubocop.txtThe patch generated 15 new + 44 unchanged - 1 fixed = 59 total (was 45)
+1 💚spotbugs7m 3sthe patch passed
+1 💚hadoopcheck11m 57sPatch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚hbaseprotoc2m 48sthe patch passed
-1 ❌spotless0m 41spatch has 23 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 💚asflicense0m 59sThe patch does not generate ASF License warnings.
67m 50s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7460/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7460
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc rubocop
unameLinux f684051410a6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-29368-key-management-feature / 491035b
Default JavaEclipse Adoptium-17.0.11+9
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7460/9/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7460/9/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 33sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗mvndep0m 33sMaven dependency ordering for branch
+1 💚mvninstall3m 30sHBASE-29368-key-management-feature passed
+1 💚compile2m 55sHBASE-29368-key-management-feature passed
+1 💚javadoc1m 49sHBASE-29368-key-management-feature passed
+1 💚shadedjars6m 16sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 19sthe patch passed
+1 💚compile2m 55sthe patch passed
+1 💚javac2m 55sthe patch passed
+1 💚javadoc0m 10shbase-protocol-shaded in the patch passed.
-0 ⚠️javadoc0m 16s/results-javadoc-javadoc-hbase-common.txthbase-common generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)
+1 💚javadoc0m 16shbase-client in the patch passed.
+1 💚javadoc0m 27shbase-server generated 0 new + 63 unchanged - 2 fixed = 63 total (was 65)
+1 💚javadoc0m 31shbase-thrift in the patch passed.
+1 💚javadoc0m 10shbase-shell in the patch passed.
+1 💚shadedjars6m 14spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 34shbase-protocol-shaded in the patch passed.
+1 💚unit2m 57shbase-common in the patch passed.
+1 💚unit1m 29shbase-client in the patch passed.
-1 ❌unit231m 17s/patch-unit-hbase-server.txthbase-server in the patch failed.
+1 💚unit6m 48shbase-thrift in the patch passed.
+1 💚unit6m 53shbase-shell in the patch passed.
286m 28s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7460/9/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7460
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 3d85a6ebed63 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-29368-key-management-feature / 491035b
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7460/9/testReport/
Max. process+thread count4402 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7460/9/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@haridsv
haridsv marked this pull request as ready for review November 28, 2025 02:09
@virajjasani

Copy link
Copy Markdown
Contributor

There are few spotless warnings that can be taken care of later in the final PR

@virajjasani
virajjasani merged commit ffc1743 into apache:HBASE-29368-key-management-featureNov 28, 2025
1 check failed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@haridsv@Apache-HBase@virajjasani