HBASE-29223 Migrate Master Status Jamon page back to JSP (#6875) by PDavid · Pull Request #7479 · apache/hbase

PDavid · 2025-11-24T16:02:46Z

The JSP code is equivalent to the Jamon code, just changed the syntax back to JSP.
Request attributes are used to transfer data between JSP pages.
Tried to preserve the code as much as possible but did some changes:

Sub-templates were usually extracted to separate JSP file (and included with <jsp:include), in some case it was extracted as Java method.

Extracted some sections from master page to separate JSP pages:

Software Attributes
Warnings

Extracted the long JavaScript from the master page which executes on page load to separate JS file.

Extracted some frequently used static methods to a new util class: MasterStatusUtil. Also added unit tests for the static methods in MasterStatusUtil.

Changed the Master Status page back to /master.jsp again. Now made sure that /master-status redirects to /master.jsp.

Signed-off-by: Istvan Toth stoty@apache.org
(cherry picked from commit be40011)

The JSP code is equivalent to the Jamon code, just changed the syntax back to JSP. Request attributes are used to transfer data between JSP pages. Tried to preserve the code as much as possible but did some changes: Sub-templates were usually extracted to separate JSP file (and included with `<jsp:include`), in some case it was extracted as Java method. Extracted some sections from master page to separate JSP pages: - Software Attributes - Warnings Extracted the long JavaScript from the master page which executes on page load to separate JS file. Extracted some frequently used static methods to a new util class: `MasterStatusUtil`. Also added unit tests for the static methods in `MasterStatusUtil`. Changed the Master Status page back to `/master.jsp` again. Now made sure that `/master-status` redirects to `/master.jsp`. Signed-off-by: Istvan Toth <stoty@apache.org> (cherry picked from commit be40011)

TestMasterStatusUtil.testGetFragmentationInfoTurnedOn failed in master nightly build Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 8ef271f)

PDavid · 2025-11-24T16:04:37Z

This is a backport of #6875 to branch-2.6. Cherry-picked the branch-2 patch (#7478). The reason is that in branch-2 and in branch-2.6 there is no org.apache.hadoop.hbase.rsgroup.RSGroupUtil or RSGroupInfoManager and also there are some other minor differences.

Also includes the addendum which fixes a test (8ef271f)

Apache-HBase · 2025-11-24T16:55:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 44s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	jshint	0m 0s		jshint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2.6 Compile Tests _
+1 💚	mvninstall	3m 45s		branch-2.6 passed
+1 💚	compile	3m 10s		branch-2.6 passed
+1 💚	checkstyle	0m 40s		branch-2.6 passed
+1 💚	spotbugs	1m 40s		branch-2.6 passed
+1 💚	spotless	0m 50s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 9s		the patch passed
+1 💚	compile	3m 3s		the patch passed
+1 💚	javac	3m 3s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 39s		hbase-server: The patch generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3)
+1 💚	xmllint	0m 1s		No new issues.
+1 💚	spotbugs	1m 45s		the patch passed
+1 💚	hadoopcheck	17m 8s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 12s		The patch does not generate ASF License warnings.
		39m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7479/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7479
Optional Tests	dupname asflicense javac codespell detsecrets spotless spotbugs checkstyle compile hadoopcheck hbaseanti xmllint jshint
uname	Linux e3477d1da18c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `1c131c5`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7479/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-11-24T20:15:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+1 💚	mvninstall	3m 8s		branch-2.6 passed
+1 💚	compile	0m 51s		branch-2.6 passed
+1 💚	javadoc	0m 32s		branch-2.6 passed
+1 💚	shadedjars	5m 51s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 32s		the patch passed
+1 💚	compile	0m 44s		the patch passed
+1 💚	javac	0m 44s		the patch passed
+1 💚	javadoc	0m 25s		the patch passed
+1 💚	shadedjars	5m 42s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	213m 44s		hbase-server in the patch passed.
		239m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7479/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#7479
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux bab30458aa94 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `1c131c5`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7479/1/testReport/
Max. process+thread count	3153 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7479/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-11-24T20:21:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 48s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+1 💚	mvninstall	3m 39s		branch-2.6 passed
+1 💚	compile	0m 52s		branch-2.6 passed
+1 💚	javadoc	0m 28s		branch-2.6 passed
+1 💚	shadedjars	6m 48s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 10s		the patch passed
+1 💚	compile	0m 53s		the patch passed
+1 💚	javac	0m 53s		the patch passed
+1 💚	javadoc	0m 28s		the patch passed
+1 💚	shadedjars	6m 45s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	216m 38s		hbase-server in the patch passed.
		245m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7479/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#7479
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 3f65281de2fe 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `1c131c5`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7479/1/testReport/
Max. process+thread count	3194 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7479/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-11-24T20:46:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 13s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+1 💚	mvninstall	4m 49s		branch-2.6 passed
+1 💚	compile	1m 34s		branch-2.6 passed
+1 💚	javadoc	0m 47s		branch-2.6 passed
+1 💚	shadedjars	7m 28s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	4m 48s		the patch passed
+1 💚	compile	1m 17s		the patch passed
+1 💚	javac	1m 17s		the patch passed
+1 💚	javadoc	0m 37s		the patch passed
+1 💚	shadedjars	8m 11s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	234m 32s		hbase-server in the patch passed.
		270m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7479/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7479
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux f1d2147c8bb4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `1c131c5`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7479/1/testReport/
Max. process+thread count	3331 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7479/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

PDavid · 2025-11-26T09:13:56Z

Testing

Tested this the same way, as I did for the master version:

PDavidand others added 3 commits November 24, 2025 16:17

HBASE-29223 spotless fix
8307d6d

[ADDENDUM] HBASE-29223 Fix TestMasterStatusUtil (apache#7416)
1c131c5
TestMasterStatusUtil.testGetFragmentationInfoTurnedOn failed in master nightly build Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 8ef271f)

PDavid self-assigned this Nov 24, 2025

PDavid marked this pull request as ready for review November 25, 2025 11:36

PDavid merged commit b23f5b5 into apache:branch-2.6Nov 26, 2025
1 check passed

PDavid deleted the HBASE-29223-jamon-jsp-MasterStatus-branch-2.6 branch November 26, 2025 09:14

PDavid added the backport This PR is a back port of some issue or issues already committed to master label Dec 10, 2025

Navigation Menu

Uh oh!

HBASE-29223 Migrate Master Status Jamon page back to JSP (#6875) - #7479

HBASE-29223 Migrate Master Status Jamon page back to JSP (#6875)#7479
PDavid merged 3 commits into
apache:branch-2.6from
PDavid:HBASE-29223-jamon-jsp-MasterStatus-branch-2.6

PDavid commented Nov 24, 2025

Uh oh!

PDavid commented Nov 24, 2025

Uh oh!

Apache-HBase commented Nov 24, 2025

Uh oh!

Apache-HBase commented Nov 24, 2025

Uh oh!

Apache-HBase commented Nov 24, 2025

Uh oh!

Apache-HBase commented Nov 24, 2025

Uh oh!

PDavid commented Nov 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

PDavid commented Nov 24, 2025

Uh oh!

PDavid commented Nov 24, 2025

Uh oh!

Apache-HBase commented Nov 24, 2025

Uh oh!

Apache-HBase commented Nov 24, 2025

Uh oh!

Apache-HBase commented Nov 24, 2025

Uh oh!

Apache-HBase commented Nov 24, 2025

Uh oh!

PDavid commented Nov 26, 2025

Testing

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants