Skip to content

HBASE-29531 Migrate RegionServer Status Jamon page back to JSP - #7491

Merged
PDavid merged 2 commits into
branch-3from
HBASE-29531-jamon-jsp-rsstatus-branch-3
Dec 2, 2025
Merged

HBASE-29531 Migrate RegionServer Status Jamon page back to JSP#7491
PDavid merged 2 commits into
branch-3from
HBASE-29531-jamon-jsp-rsstatus-branch-3

Conversation

@PDavid

@PDavidPDavid commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

This is the 2/3 step of the Jamon to JSP migration: the Region Server Status page.

Did the migration the same way as for the Master Status page: #6875

Migrated the Jamon code to JSP as close as possible. Extracted the duplicated formatZKString method to new java class: ZKStringFormatter and added unit tests.

Changed the Region Server Status page back to /regionserver.jsp. Made sure that /rs-status redirects to /regionserver.jsp.

Extracted the BlockCache inline CSS styles to hbase.css file. Also extracted the large BlockCache Hit Ratio periods paging JavaScript code to separate .js file.

Introduced a src/main/resources/hbase-webapps/common directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit.

Extracted the inline tablesorter initialization JavaScript code to separate file.

Signed-off-by: Duo Zhang zhangduo@apache.org
(cherry picked from commit 7892207)

[ADDENDUM] HBASE-29223 Fix TestMasterStatusUtil (#7416)

TestMasterStatusUtil.testGetFragmentationInfoTurnedOn failed in master nightly build

Signed-off-by: Nihal Jain nihaljain@apache.org
Signed-off-by: Duo Zhang zhangduo@apache.org
(cherry picked from commit 8ef271f)

This is the 2/3 step of the Jamon to JSP migration: the Region Server Status page.
Did the migration the same way as for the Master Status page: #6875
Migrated the Jamon code to JSP as close as possible. Extracted the duplicated `formatZKString` method to new java class: ZKStringFormatter and added unit tests.
Changed the Region Server Status page back to `/regionserver.jsp`. Made sure that `/rs-status` redirects to `/regionserver.jsp`.
Extracted the BlockCache inline CSS styles to `hbase.css` file. Also extracted the large BlockCache Hit Ratio periods paging JavaScript code to separate .js file.
Introduced a `src/main/resources/hbase-webapps/common` directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit.
Extracted the inline tablesorter initialization JavaScript code to separate file.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 7892207)
@PDavidPDavid self-assigned this Dec 1, 2025
@PDavidPDavid added the backport This PR is a back port of some issue or issues already committed to master label Dec 1, 2025
@PDavid

PDavid commented Dec 1, 2025

Copy link
Copy Markdown
ContributorAuthor

This is a backport of #7371 to branch-3. I cherry-picked the 7892207 commit which applied cleanly.

Also cherry-picked #7416 to fix TestMasterStatusUtil.testGetFragmentationInfoTurnedOn.

@PDavid

Copy link
Copy Markdown
ContributorAuthor

Testing

Tested this locally the same way as described here: #7371 (comment)

Also configured HBase in pseudo-distributed mode and checked the RS Status page.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

TestMasterStatusUtil.testGetFragmentationInfoTurnedOn failed in master nightly build
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 8ef271f)
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 1scodespell was not available.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+0 🆗jshint0m 1sjshint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-3 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 4sbranch-3 passed
+1 💚compile3m 45sbranch-3 passed
+1 💚checkstyle1m 7sbranch-3 passed
+1 💚spotbugs1m 35sbranch-3 passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 6sthe patch passed
+1 💚compile3m 41sthe patch passed
+1 💚javac3m 41sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle1m 0shbase-server: The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
+1 💚checkstyle0m 7sThe patch passed checkstyle in hbase-shell
-0 ⚠️rubocop0m 3s/results-rubocop.txtThe patch generated 1 new + 84 unchanged - 1 fixed = 85 total (was 85)
+1 💚xmllint0m 0sNo new issues.
+1 💚spotbugs1m 42sthe patch passed
+1 💚hadoopcheck11m 50sPatch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚spotless0m 45spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 17sThe patch does not generate ASF License warnings.
41m 30s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7491/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7491
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti jshint rubocop
unameLinux 3de39e175df8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / 118049c
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-server hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7491/2/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 15sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-3 Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for branch
+1 💚mvninstall6m 20sbranch-3 passed
+1 💚compile2m 0sbranch-3 passed
+1 💚javadoc1m 1sbranch-3 passed
+1 💚shadedjars8m 44sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall5m 46sthe patch passed
+1 💚compile2m 11sthe patch passed
+1 💚javac2m 11sthe patch passed
+1 💚javadoc1m 3sthe patch passed
+1 💚shadedjars8m 21spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit545m 9s/patch-unit-hbase-server.txthbase-server in the patch failed.
+1 💚unit11m 5shbase-shell in the patch passed.
597m 4s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7491/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7491
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 210283deec04 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / 118049c
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7491/2/testReport/
Max. process+thread count2718 (vs. ulimit of 30000)
modulesC: hbase-server hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7491/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@PDavid

PDavid commented Dec 2, 2025

Copy link
Copy Markdown
ContributorAuthor

org.apache.hadoop.hbase.replication.TestNamespaceReplication failed in the PR build. I think it is unrelated to the changes and it run successfully locally for me.

@PDavid
PDavid marked this pull request as ready for review December 2, 2025 08:18
@PDavid
PDavid merged commit 7dd4e55 into branch-3Dec 2, 2025
1 check failed
@PDavid
PDavid deleted the HBASE-29531-jamon-jsp-rsstatus-branch-3 branch December 2, 2025 08:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@PDavid@Apache-HBase