HBASE-29531 Migrate RegionServer Status Jamon page back to JSP by PDavid · Pull Request #7492 · apache/hbase

PDavid · 2025-12-01T14:51:59Z

This is the 2/3 step of the Jamon to JSP migration: the Region Server Status page.

Did the migration the same way as for the Master Status page: #6875

Migrated the Jamon code to JSP as close as possible. Extracted the duplicated formatZKString method to new java class: ZKStringFormatter and added unit tests.

Changed the Region Server Status page back to /regionserver.jsp. Made sure that /rs-status redirects to /regionserver.jsp.

Extracted the BlockCache inline CSS styles to hbase.css file. Also extracted the large BlockCache Hit Ratio periods paging JavaScript code to separate .js file.

Introduced a src/main/resources/hbase-webapps/common directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit.

Extracted the inline tablesorter initialization JavaScript code to separate file.

Signed-off-by: Duo Zhang zhangduo@apache.org
(cherry picked from commit 7892207)

…e#7371) This is the 2/3 step of the Jamon to JSP migration: the Region Server Status page. Did the migration the same way as for the Master Status page: apache#6875 Migrated the Jamon code to JSP as close as possible. Extracted the duplicated `formatZKString` method to new java class: ZKStringFormatter and added unit tests. Changed the Region Server Status page back to `/regionserver.jsp`. Made sure that `/rs-status` redirects to `/regionserver.jsp`. Extracted the BlockCache inline CSS styles to `hbase.css` file. Also extracted the large BlockCache Hit Ratio periods paging JavaScript code to separate .js file. Introduced a `src/main/resources/hbase-webapps/common` directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit. Extracted the inline tablesorter initialization JavaScript code to separate file. Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 7892207)

PDavid · 2025-12-01T15:48:11Z

This is a backport of #7371 to branch-2. I cherry-picked the 7892207 commit which needed minor fix (HBaseTestingUtil -> HBaseTestingUtility).

Testing

Tested this locally the same way as described here: #7371 (comment)

Also configured HBase in pseudo-distributed mode and checked the RS Status page.

Assert content type `text/html;charset=utf-8` vs `text/html`.

Apache-HBase · 2025-12-02T14:28:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	jshint	0m 0s		jshint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 27s		branch-2 passed
+1 💚	compile	3m 25s		branch-2 passed
+1 💚	checkstyle	0m 48s		branch-2 passed
+1 💚	spotbugs	1m 36s		branch-2 passed
+1 💚	spotless	0m 49s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 9s		the patch passed
+1 💚	compile	3m 21s		the patch passed
+1 💚	javac	3m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 39s		hbase-server: The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
+1 💚	checkstyle	0m 8s		The patch passed checkstyle in hbase-shell
-0 ⚠️	rubocop	0m 13s	/results-rubocop.txt	The patch generated 1 new + 84 unchanged - 1 fixed = 85 total (was 85)
+1 💚	xmllint	0m 1s		No new issues.
+1 💚	spotbugs	1m 48s		the patch passed
+1 💚	hadoopcheck	17m 25s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚	spotless	0m 46s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 19s		The patch does not generate ASF License warnings.
		41m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7492/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7492
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti jshint rubocop
uname	Linux 89f6454c2ccf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `c446f21`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7492/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-12-02T17:58:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 35s		branch-2 passed
+1 💚	compile	1m 11s		branch-2 passed
+1 💚	javadoc	0m 38s		branch-2 passed
+1 💚	shadedjars	6m 41s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 5s		the patch passed
+1 💚	compile	1m 8s		the patch passed
+1 💚	javac	1m 8s		the patch passed
+1 💚	javadoc	0m 36s		the patch passed
+1 💚	shadedjars	6m 39s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	214m 18s		hbase-server in the patch passed.
+1 💚	unit	7m 36s		hbase-shell in the patch passed.
		251m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7492/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#7492
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 37c6a44fb19d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `c446f21`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7492/2/testReport/
Max. process+thread count	3236 (vs. ulimit of 30000)
modules	C: hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7492/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-12-02T19:06:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 38s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 14s		branch-2 passed
+1 💚	compile	1m 35s		branch-2 passed
+1 💚	javadoc	0m 47s		branch-2 passed
+1 💚	shadedjars	7m 27s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 50s		the patch passed
+1 💚	compile	1m 24s		the patch passed
+1 💚	javac	1m 24s		the patch passed
+1 💚	javadoc	0m 43s		the patch passed
+1 💚	shadedjars	8m 56s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	274m 22s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
+1 💚	unit	8m 17s		hbase-shell in the patch passed.
		320m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7492/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7492
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9a0fa6c125db 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `c446f21`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7492/2/testReport/
Max. process+thread count	3173 (vs. ulimit of 30000)
modules	C: hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7492/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-12-02T19:13:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 35s		branch-2 passed
+1 💚	compile	1m 27s		branch-2 passed
+1 💚	javadoc	0m 43s		branch-2 passed
+1 💚	shadedjars	6m 21s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 50s		the patch passed
+1 💚	compile	1m 17s		the patch passed
+1 💚	javac	1m 17s		the patch passed
+1 💚	javadoc	0m 59s		the patch passed
+1 💚	shadedjars	6m 28s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	288m 40s		hbase-server in the patch passed.
+1 💚	unit	7m 54s		hbase-shell in the patch passed.
		327m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7492/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#7492
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6ae2dbaf83be 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `c446f21`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7492/2/testReport/
Max. process+thread count	3125 (vs. ulimit of 30000)
modules	C: hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7492/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

PDavid · 2025-12-03T09:29:53Z

TestClientScannerTimeouts, TestStochasticLoadBalancerLargeCluster tests failed in the PR build but these are unrelated and they are running successfully locally.

PDavid self-assigned this Dec 1, 2025

PDavid added the backport This PR is a back port of some issue or issues already committed to master label Dec 1, 2025

This comment has been minimized.
Sign in to view

HBASE-29531 Fixed TestRSStatusPage
c446f21
Assert content type `text/html;charset=utf-8` vs `text/html`.

PDavid marked this pull request as ready for review December 3, 2025 09:29

PDavid merged commit e7be4f3 into apache:branch-2Dec 3, 2025
1 check failed

PDavid deleted the HBASE-29531-jamon-jsp-rsstatus-branch-2 branch December 3, 2025 09:38

Navigation Menu

Uh oh!

HBASE-29531 Migrate RegionServer Status Jamon page back to JSP - #7492

HBASE-29531 Migrate RegionServer Status Jamon page back to JSP#7492
PDavid merged 2 commits into
apache:branch-2from
PDavid:HBASE-29531-jamon-jsp-rsstatus-branch-2

PDavid commented Dec 1, 2025

Uh oh!

PDavid commented Dec 1, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Dec 2, 2025

Uh oh!

Apache-HBase commented Dec 2, 2025

Uh oh!

Apache-HBase commented Dec 2, 2025

Uh oh!

Apache-HBase commented Dec 2, 2025

Uh oh!

PDavid commented Dec 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

PDavid commented Dec 1, 2025

Uh oh!

PDavid commented Dec 1, 2025

Testing

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Dec 2, 2025

Uh oh!

Apache-HBase commented Dec 2, 2025

Uh oh!

Apache-HBase commented Dec 2, 2025

Uh oh!

Apache-HBase commented Dec 2, 2025

Uh oh!

PDavid commented Dec 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants