Skip to content

HBASE-29596 Migrate Canary Status Jamon page back to JSP - #7496

Merged
PDavid merged 1 commit into
apache:branch-3from
PDavid:HBASE-29596-jamon-jsp-canary-branch-3
Dec 3, 2025
Merged

HBASE-29596 Migrate Canary Status Jamon page back to JSP#7496
PDavid merged 1 commit into
apache:branch-3from
PDavid:HBASE-29596-jamon-jsp-canary-branch-3

Conversation

@PDavid

Copy link
Copy Markdown
Contributor

This is the last step of the Jamon to JSP migration: the Canary Status page.

Migrated the Jamon code to JSP as close as possible. Extracted some duplicated server link code to new java class: CanaryStatusUtil and added unit tests.

Changed the Canary Server Status page back to /canary.jsp. Made sure that /canary-status redirects to /canary.jsp.

Introduced a src/main/resources/hbase-webapps/common directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit.

Made sure to compile Canary JSP files the same way as we do for Master and Region server JSP pages.

Removed the Jamon Maven dependencies and references to Jamon code.

Signed-off-by: Istvan Toth stoty@apache.org
Signed-off-by: Nihal Jain nihaljain@apache.org
(cherry picked from commit 4ba9b46)

This is the last step of the Jamon to JSP migration: the Canary Status page.
Migrated the Jamon code to JSP as close as possible. Extracted some duplicated server link code to new java class: CanaryStatusUtil and added unit tests.
Changed the Canary Server Status page back to `/canary.jsp`. Made sure that `/canary-status` redirects to `/canary.jsp`.
Introduced a `src/main/resources/hbase-webapps/common` directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit.
Made sure to compile Canary JSP files the same way as we do for Master and Region server JSP pages.
Removed the Jamon Maven dependencies and references to Jamon code.
Signed-off-by: Istvan Toth <stoty@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
(cherry picked from commit 4ba9b46)
@PDavidPDavid self-assigned this Dec 2, 2025
@PDavidPDavid added the backport This PR is a back port of some issue or issues already committed to master label Dec 2, 2025
@PDavid

Copy link
Copy Markdown
ContributorAuthor

This is a backport of #7390 to branch-3.
The cherry-pick applied almost cleanly, the only difference is that the master patch had a 1 line change in src/main/asciidoc/_chapters/developer.adoc but this file is not present in this branch (because we only kept and maintain the RefGuide in master).

Testing

Tested the patch the same way as described here: #7390 (comment)

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec2m 23sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-3 Compile Tests _
+0 🆗mvndep0m 27sMaven dependency ordering for branch
+1 💚mvninstall4m 58sbranch-3 passed
+1 💚compile14m 4sbranch-3 passed
+1 💚checkstyle2m 47sbranch-3 passed
+1 💚spotbugs14m 58sbranch-3 passed
+1 💚spotless1m 6sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall4m 25sthe patch passed
+1 💚compile13m 51sthe patch passed
+1 💚javac13m 51sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle2m 39sthe patch passed
+1 💚xmllint0m 0sNo new issues.
+1 💚spotbugs15m 27sthe patch passed
+1 💚hadoopcheck13m 27sPatch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚spotless1m 12spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense1m 14sThe patch does not generate ASF License warnings.
104m 1s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7496/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7496
Optional Testsdupname asflicense checkstyle javac codespell detsecrets xmllint spotless hadoopcheck compile spotbugs hbaseanti
unameLinux c35c8898e627 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / e26d6ff
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count162 (vs. ulimit of 30000)
modulesC: hbase-checkstyle hbase-zookeeper hbase-resource-bundle hbase-server hbase-shaded . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7496/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-3 Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall3m 15sbranch-3 passed
+1 💚compile2m 7sbranch-3 passed
+1 💚javadoc3m 3sbranch-3 passed
+1 💚shadedjars6m 4sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall2m 55sthe patch passed
+1 💚compile2m 11sthe patch passed
+1 💚javac2m 11sthe patch passed
+1 💚javadoc3m 2sthe patch passed
+1 💚shadedjars5m 59spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit281m 44s/patch-unit-root.txtroot in the patch failed.
320m 55s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7496/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7496
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 26e0271e8a49 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / e26d6ff
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7496/1/testReport/
Max. process+thread count7853 (vs. ulimit of 30000)
modulesC: hbase-checkstyle hbase-zookeeper hbase-resource-bundle hbase-server hbase-shaded . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7496/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@PDavid

Copy link
Copy Markdown
ContributorAuthor

Some REST-related tests failed (TestGzipFilter, TestNamespacesInstanceResource, TestSchemaResource) but those are unrelated to the changes and they are locally successful.

@PDavid
PDavid marked this pull request as ready for review December 2, 2025 15:05
@PDavid
PDavid merged commit 3e5e131 into apache:branch-3Dec 3, 2025
1 check failed
@PDavid
PDavid deleted the HBASE-29596-jamon-jsp-canary-branch-3 branch December 3, 2025 08:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@PDavid@Apache-HBase