Skip to content

HBASE-29531 Migrate RegionServer Status Jamon page back to JSP - #7505

Merged
PDavid merged 1 commit into
apache:branch-2.6from
PDavid:HBASE-29531-jamon-jsp-rsstatus-branch-2.6
Dec 8, 2025
Merged

HBASE-29531 Migrate RegionServer Status Jamon page back to JSP#7505
PDavid merged 1 commit into
apache:branch-2.6from
PDavid:HBASE-29531-jamon-jsp-rsstatus-branch-2.6

Conversation

@PDavid

Copy link
Copy Markdown
Contributor

This is the 2/3 step of the Jamon to JSP migration: the Region Server Status page.

Did the migration the same way as for the Master Status page: #6875

Migrated the Jamon code to JSP as close as possible. Extracted the duplicated formatZKString method to new java class: ZKStringFormatter and added unit tests.

Changed the Region Server Status page back to /regionserver.jsp. Made sure that /rs-status redirects to /regionserver.jsp.

Extracted the BlockCache inline CSS styles to hbase.css file. Also extracted the large BlockCache Hit Ratio periods paging JavaScript code to separate .js file.

Introduced a src/main/resources/hbase-webapps/common directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit.

Extracted the inline tablesorter initialization JavaScript code to separate file.

Signed-off-by: Duo Zhang zhangduo@apache.org
(cherry picked from commit 7892207)

…e#7371)
This is the 2/3 step of the Jamon to JSP migration: the Region Server Status page.
Did the migration the same way as for the Master Status page: apache#6875
Migrated the Jamon code to JSP as close as possible. Extracted the duplicated `formatZKString` method to new java class: ZKStringFormatter and added unit tests.
Changed the Region Server Status page back to `/regionserver.jsp`. Made sure that `/rs-status` redirects to `/regionserver.jsp`.
Extracted the BlockCache inline CSS styles to `hbase.css` file. Also extracted the large BlockCache Hit Ratio periods paging JavaScript code to separate .js file.
Introduced a `src/main/resources/hbase-webapps/common` directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit.
Extracted the inline tablesorter initialization JavaScript code to separate file.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 7892207)
@PDavidPDavid self-assigned this Dec 3, 2025
@PDavidPDavid added the backport This PR is a back port of some issue or issues already committed to master label Dec 3, 2025
@PDavid

Copy link
Copy Markdown
ContributorAuthor

This is a backport of #7371 to branch-2.6. I cherry-picked the 7892207 commit which needed minor fix (HBaseTestingUtil -> HBaseTestingUtility).

Testing

Tested this locally the same way as described here: #7371 (comment)

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid
PDavid marked this pull request as ready for review December 5, 2025 13:50
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌docker0m 2sDocker failed to build run-specific yetus/hbase:tp-14858}.
SubsystemReport/Notes
GITHUB PR#7505
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7505/2/console
versionsgit=2.17.1
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 46sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall2m 50sbranch-2.6 passed
+1 💚compile0m 58sbranch-2.6 passed
+1 💚javadoc0m 35sbranch-2.6 passed
+1 💚shadedjars5m 35sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 27sthe patch passed
+1 💚compile0m 58sthe patch passed
+1 💚javac0m 58sthe patch passed
+1 💚javadoc0m 35sthe patch passed
+1 💚shadedjars5m 29spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit206m 14shbase-server in the patch passed.
+1 💚unit6m 59shbase-shell in the patch passed.
238m 21s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7505/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#7505
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9a6880e12bf8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / dd03630
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7505/2/testReport/
Max. process+thread count3094 (vs. ulimit of 30000)
modulesC: hbase-server hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7505/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 55sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 26sbranch-2.6 passed
+1 💚compile1m 12sbranch-2.6 passed
+1 💚javadoc0m 38sbranch-2.6 passed
+1 💚shadedjars6m 37sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for patch
+1 💚mvninstall4m 14sthe patch passed
+1 💚compile1m 36sthe patch passed
+1 💚javac1m 36sthe patch passed
+1 💚javadoc0m 49sthe patch passed
+1 💚shadedjars7m 24spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit281m 18shbase-server in the patch passed.
-1 ❌unit15m 7s/patch-unit-hbase-shell.txthbase-shell in the patch failed.
329m 43s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7505/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7505
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1781caf96339 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / dd03630
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7505/2/testReport/
Max. process+thread count3342 (vs. ulimit of 30000)
modulesC: hbase-server hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7505/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec2m 17sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall5m 27sbranch-2.6 passed
+1 💚compile1m 38sbranch-2.6 passed
+1 💚javadoc0m 53sbranch-2.6 passed
+1 💚shadedjars8m 13sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for patch
+1 💚mvninstall4m 53sthe patch passed
+1 💚compile1m 34sthe patch passed
+1 💚javac1m 34sthe patch passed
+1 💚javadoc0m 49sthe patch passed
+1 💚shadedjars8m 13spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit494m 54shbase-server in the patch passed.
+1 💚unit12m 10shbase-shell in the patch passed.
546m 36s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7505/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#7505
Optional Testsjavac javadoc unit shadedjars compile
unameLinux aa0b575c87f5 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / dd03630
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7505/2/testReport/
Max. process+thread count2321 (vs. ulimit of 30000)
modulesC: hbase-server hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7505/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@PDavid

Copy link
Copy Markdown
ContributorAuthor

org.apache.hadoop.hbase.client.TestShell test failed in the PR build but I think that is unrelated and it is successful locally.

@PDavid
PDavid merged commit 05a4e99 into apache:branch-2.6Dec 8, 2025
1 check failed
@PDavid
PDavid deleted the HBASE-29531-jamon-jsp-rsstatus-branch-2.6 branch December 8, 2025 12:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@PDavid@Apache-HBase