HBASE-29223 Migrate Master Status Jamon page back to JSP (#6875) by PDavid · Pull Request #7534 · apache/hbase

PDavid · 2025-12-10T09:18:06Z

Migrate Master Status Jamon page back to JSP (#6875)

The JSP code is equivalent to the Jamon code, just changed the syntax back to JSP. Request attributes are used to transfer data between JSP pages. Tried to preserve the code as much as possible but did some changes:

Sub-templates were usually extracted to separate JSP file (and included with <jsp:include), in some case it was extracted as Java method.

Extracted some sections from master page to separate JSP pages:

Software Attributes
Warnings

Extracted the long JavaScript from the master page which executes on page load to separate JS file.

Extracted some frequently used static methods to a new util class: MasterStatusUtil. Also added unit tests for the static methods in MasterStatusUtil.

Changed the Master Status page back to /master.jsp again. Now made sure that /master-status redirects to /master.jsp.

(cherry picked from commit be40011)

Fix TestMasterStatusUtil (#7416)

TestMasterStatusUtil.testGetFragmentationInfoTurnedOn failed in master nightly build

(cherry picked from commit 8ef271f) (cherry picked from commit d481a46)

apache#7478) * HBASE-29223 Migrate Master Status Jamon page back to JSP (apache#6875) The JSP code is equivalent to the Jamon code, just changed the syntax back to JSP. Request attributes are used to transfer data between JSP pages. Tried to preserve the code as much as possible but did some changes: Sub-templates were usually extracted to separate JSP file (and included with `<jsp:include`), in some case it was extracted as Java method. Extracted some sections from master page to separate JSP pages: - Software Attributes - Warnings Extracted the long JavaScript from the master page which executes on page load to separate JS file. Extracted some frequently used static methods to a new util class: `MasterStatusUtil`. Also added unit tests for the static methods in `MasterStatusUtil`. Changed the Master Status page back to `/master.jsp` again. Now made sure that `/master-status` redirects to `/master.jsp`. Signed-off-by: Istvan Toth <stoty@apache.org> (cherry picked from commit be40011) * HBASE-29223 spotless fix * [ADDENDUM] HBASE-29223 Fix TestMasterStatusUtil (apache#7416) TestMasterStatusUtil.testGetFragmentationInfoTurnedOn failed in master nightly build Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 8ef271f) (cherry picked from commit d481a46)

PDavid · 2025-12-10T09:21:33Z

This is a backport of #6875 to branch-2.5. Cherry-picked the branch-2 patch (#7478). The reason is that in branch-2, branch-2.6 and branch-2.5 there is no org.apache.hadoop.hbase.rsgroup.RSGroupUtil or RSGroupInfoManager and also there are some other minor differences.

Also includes the addendum which fixes a test I introduced in the patch: (8ef271f)

Some API methods are not available in this branch.

Apache-HBase · 2025-12-10T12:44:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 3s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	jshint	0m 0s		jshint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	4m 6s		branch-2.5 passed
+1 💚	compile	3m 20s		branch-2.5 passed
+1 💚	checkstyle	0m 44s		branch-2.5 passed
+1 💚	spotbugs	1m 47s		branch-2.5 passed
+1 💚	spotless	0m 52s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	4m 0s		the patch passed
+1 💚	compile	3m 35s		the patch passed
+1 💚	javac	3m 35s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 51s		hbase-server: The patch generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3)
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	2m 23s		the patch passed
+1 💚	hadoopcheck	27m 13s		Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.1.
+1 💚	spotless	0m 55s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 11s		The patch does not generate ASF License warnings.
		53m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7534/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7534
Optional Tests	dupname asflicense javac codespell detsecrets spotless spotbugs checkstyle compile hadoopcheck hbaseanti xmllint jshint
uname	Linux 1cb1ebe6fb69 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `c9a9470`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7534/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

PDavid · 2025-12-10T14:07:04Z

Testing

Tested this the same way, as I did for the master version:

Apache-HBase · 2025-12-10T15:24:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	3m 34s		branch-2.5 passed
+1 💚	compile	1m 3s		branch-2.5 passed
+1 💚	javadoc	0m 29s		branch-2.5 passed
+1 💚	shadedjars	6m 29s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 1s		the patch passed
+1 💚	compile	0m 55s		the patch passed
+1 💚	javac	0m 55s		the patch passed
+1 💚	javadoc	0m 26s		the patch passed
+1 💚	shadedjars	6m 18s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	185m 21s		hbase-server in the patch passed.
		213m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7534/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7534
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 6270cc863bb7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `c9a9470`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7534/2/testReport/
Max. process+thread count	3480 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7534/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-12-10T15:27:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 47s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 24s		branch-2.5 passed
+1 💚	compile	0m 46s		branch-2.5 passed
+1 💚	javadoc	0m 25s		branch-2.5 passed
+1 💚	shadedjars	5m 25s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 27s		the patch passed
+1 💚	compile	0m 41s		the patch passed
+1 💚	javac	0m 41s		the patch passed
+1 💚	javadoc	0m 24s		the patch passed
+1 💚	shadedjars	5m 24s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	193m 0s		hbase-server in the patch passed.
		216m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7534/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#7534
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux bb9a15b2779c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `c9a9470`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7534/2/testReport/
Max. process+thread count	3018 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7534/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-12-10T15:32:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 49s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	3m 35s		branch-2.5 passed
+1 💚	compile	0m 49s		branch-2.5 passed
+1 💚	javadoc	0m 27s		branch-2.5 passed
+1 💚	shadedjars	6m 34s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 59s		the patch passed
+1 💚	compile	0m 49s		the patch passed
+1 💚	javac	0m 49s		the patch passed
+1 💚	javadoc	0m 26s		the patch passed
+1 💚	shadedjars	6m 37s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	194m 9s		hbase-server in the patch passed.
		221m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7534/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#7534
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux a11d378cb224 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `c9a9470`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7534/2/testReport/
Max. process+thread count	3073 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7534/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

PDavid self-assigned this Dec 10, 2025

PDavid added the backport This PR is a back port of some issue or issues already committed to master label Dec 10, 2025

This comment has been minimized.
Sign in to view

HBASE-29223 Compilation fixes
c9a9470
Some API methods are not available in this branch.

PDavid marked this pull request as ready for review December 16, 2025 15:47

PDavid merged commit 94f9ff2 into apache:branch-2.5Dec 16, 2025
1 check passed

PDavid deleted the HBASE-29223-jamon-jsp-MasterStatus-branch-2.5 branch December 16, 2025 15:48

Navigation Menu

Uh oh!

HBASE-29223 Migrate Master Status Jamon page back to JSP (#6875) - #7534

HBASE-29223 Migrate Master Status Jamon page back to JSP (#6875)#7534
PDavid merged 2 commits into
apache:branch-2.5from
PDavid:HBASE-29223-jamon-jsp-MasterStatus-branch-2.5

PDavid commented Dec 10, 2025

Uh oh!

PDavid commented Dec 10, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Dec 10, 2025

Uh oh!

PDavid commented Dec 10, 2025•
edited
Loading

Uh oh!

Apache-HBase commented Dec 10, 2025

Uh oh!

Apache-HBase commented Dec 10, 2025

Uh oh!

Apache-HBase commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

PDavid commented Dec 10, 2025

Migrate Master Status Jamon page back to JSP (#6875)

Fix TestMasterStatusUtil (#7416)

Uh oh!

PDavid commented Dec 10, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Dec 10, 2025

Uh oh!

PDavid commented Dec 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Uh oh!

Apache-HBase commented Dec 10, 2025

Uh oh!

Apache-HBase commented Dec 10, 2025

Uh oh!

Apache-HBase commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PDavid commented Dec 10, 2025•
edited
Loading