HBASE-29782 Expose public Admin API to reopen table regions without moving by ajkh88 · Pull Request #7563 · apache/hbase

ajkh88 · 2025-12-17T17:52:51Z

This change adds fail-fast validation that throws UnknownRegionException when callers attempt to reopen regions that don't belong to the specified table, preventing silent failures and configuration errors in production. The implementation removes unused batch parameters from the API in favor of configuration-based throttling (via table descriptor or global config), ensuring consistent behavior between reopening all regions and specific subsets. Exception handling now properly fails procedures for DoNotRetry errors rather than infinitely retrying validation failures.

JIRA: https://issues.apache.org/jira/browse/HBASE-29782

ajkh88 · 2026-01-06T14:26:36Z

Added TestReopenTableRegionsIntegration to verify the entire lazy modify, hash comparison, and reopen regions flow

Apache-HBase · 2026-01-06T15:59:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 50s		Maven dependency ordering for branch
+1 💚	mvninstall	5m 31s		master passed
+1 💚	compile	8m 59s		master passed
+1 💚	checkstyle	4m 12s		master passed
+1 💚	spotbugs	8m 6s		master passed
+1 💚	spotless	1m 7s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 43s		the patch passed
+1 💚	compile	8m 4s		the patch passed
+1 💚	cc	8m 4s		the patch passed
+1 💚	javac	8m 4s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	4m 8s		the patch passed
+1 💚	spotbugs	9m 52s		the patch passed
+1 💚	hadoopcheck	16m 25s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	hbaseprotoc	2m 23s		the patch passed
+1 💚	spotless	1m 13s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 56s		The patch does not generate ASF License warnings.
		87m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7563/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7563
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname	Linux 2c9876e3caae 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4a27471`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7563/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

charlesconnell

LGTM, will approve when the test run passes

Apache-HBase · 2026-01-06T19:46:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 11s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 30s		master passed
+1 💚	compile	3m 3s		master passed
+1 💚	javadoc	1m 38s		master passed
+1 💚	shadedjars	6m 16s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 26s		the patch passed
+1 💚	compile	2m 18s		the patch passed
+1 💚	javac	2m 18s		the patch passed
-0 ⚠️	javadoc	0m 30s	/results-javadoc-javadoc-hbase-server.txt	hbase-server generated 2 new + 63 unchanged - 0 fixed = 65 total (was 63)
+1 💚	shadedjars	5m 41s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 30s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 40s		hbase-client in the patch passed.
-1 ❌	unit	273m 5s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
+1 💚	unit	6m 18s		hbase-thrift in the patch passed.
		315m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7563/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7563
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 56dd8329852d 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4a27471`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7563/3/testReport/
Max. process+thread count	6587 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7563/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

…oving (#7563) * HBASE-29782 Add reopen regions functionality to admin * Add integration tests * HBASE-29782 Remove unnecessary comment * HBASE-29782 Spotless * HBASE-29782 Add integration test * HBASE-29782 Add comment about testing constructors * HBASE-29782 Spotless --------- Co-authored-by: Alex Hughes <ahughes@hubspot.com>

…oving (#7563) (#7611) Co-authored-by: Alex Hughes <ahughes@hubspot.com> Signed-off-by: Ray Mattingly <rmattingly@apache.org>

…oving (apache#7563) (apache#7611) Co-authored-by: Alex Hughes <ahughes@hubspot.com> Signed-off-by: Ray Mattingly <rmattingly@apache.org>

… regions without moving (apache#7563) (apache#7611) (will be in 2.7) Co-authored-by: Alex Hughes <ahughes@hubspot.com> Signed-off-by: Ray Mattingly <rmattingly@apache.org>

… regions without moving (apache#7563) (apache#7611) (#232) (will be in 2.7) Signed-off-by: Ray Mattingly <rmattingly@apache.org> Co-authored-by: Alex Hughes <ajkh88@users.noreply.github.com> Co-authored-by: Alex Hughes <ahughes@hubspot.com>

Alex Hughes added 4 commits December 17, 2025 14:04

HBASE-29782 Add reopen regions functionality to admin
1f2f063

Add integration tests
25576a3

Merge branch 'master' into HBASE-29782-reopen-regions-api
2b3910f

HBASE-29782 Remove unnecessary comment
43ae148

rmdmattingly requested review from charlesconnell, ndimiduk and rmdmattingly December 17, 2025 17:57

This comment has been minimized.
Sign in to view

HBASE-29782 Spotless
57dc513

This comment has been minimized.
Sign in to view

charlesconnell approved these changes Dec 18, 2025
View reviewed changes

ndimiduk reviewed Dec 18, 2025
View reviewed changes

Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
Comment thread...rver/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java

Alex Hughes added 3 commits January 6, 2026 14:07

HBASE-29782 Add integration test
bb6980f

HBASE-29782 Add comment about testing constructors
d51068d

HBASE-29782 Spotless
4a27471

charlesconnell reviewed Jan 6, 2026
View reviewed changes

charlesconnell approved these changes Jan 6, 2026
View reviewed changes

charlesconnell merged commit 6e14c22 into apache:masterJan 6, 2026
1 check failed

charlesconnell deleted the HBASE-29782-reopen-regions-api branch January 6, 2026 21:13

ajkh88 mentioned this pull request Jan 9, 2026
Backport "HBASE-29782 Expose public Admin API to reopen table regions without moving" to branch-2 #7611
Merged

rmdmattingly pushed a commit that referenced this pull request Jan 11, 2026
HBASE-29782Expose public Admin API to reopen table regions without m…
2dcc6e2
…oving (#7563) (#7611) Co-authored-by: Alex Hughes <ahughes@hubspot.com> Signed-off-by: Ray Mattingly <rmattingly@apache.org>

rmdmattingly mentioned this pull request Jan 11, 2026
HBASE-29782 Expose public Admin API to reopen table regions without m… HubSpot/hbase#232
Merged

Navigation Menu

Uh oh!

HBASE-29782 Expose public Admin API to reopen table regions without moving - #7563

HBASE-29782 Expose public Admin API to reopen table regions without moving#7563
charlesconnell merged 8 commits into
apache:masterfrom
HubSpot:HBASE-29782-reopen-regions-api

ajkh88 commented Dec 17, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

ajkh88 commented Jan 6, 2026

Uh oh!

Apache-HBase commented Jan 6, 2026

Uh oh!

charlesconnell left a comment

Uh oh!

Apache-HBase commented Jan 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ajkh88 commented Dec 17, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

ajkh88 commented Jan 6, 2026

Uh oh!

Apache-HBase commented Jan 6, 2026

Uh oh!

charlesconnell left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jan 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants