Skip to content

HBASE-23196 The IndexChunkPool’s percentage is hard code to 0.1 - #757

Closed
chenxu14 wants to merge 1 commit into
apache:masterfrom
chenxu14:HBASE-23196
Closed

HBASE-23196 The IndexChunkPool’s percentage is hard code to 0.1#757
chenxu14 wants to merge 1 commit into
apache:masterfrom
chenxu14:HBASE-23196

Conversation

@chenxu14

@chenxu14chenxu14 commented Oct 25, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@chenxu14

chenxu14 commented Oct 25, 2019

Copy link
Copy Markdown
ContributorAuthor

Can you help to review this? @anoopsjohn@openinx@ramkrish86

ramkrish86
ramkrish86 reviewed Oct 25, 2019
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ChunkCreator.java
Optional<MemStoreChunkPool> pool =
size == this.indexChunkSize ? indexChunksPool : dataChunksPool;
Chunk chunk = pool.map(MemStoreChunkPool::getChunk).orElseGet(
new Supplier<Chunk>() {

@ramkrish86ramkrish86Oct 25, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@Apache-HBase

Apache-HBase commented Oct 25, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec1m 13sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
💚mvninstall5m 38smaster passed
💚compile0m 54smaster passed
💚checkstyle1m 19smaster passed
💚shadedjars4m 34sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 43smaster passed
💙spotbugs4m 13sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 11smaster passed
_ Patch Compile Tests _
💚mvninstall4m 57sthe patch passed
💚compile0m 56sthe patch passed
💚javac0m 56sthe patch passed
💚checkstyle1m 18shbase-server: The patch generated 0 new + 64 unchanged - 2 fixed = 64 total (was 66)
💔whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
💚shadedjars4m 35spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck15m 44sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 35sthe patch passed
💚findbugs4m 12sthe patch passed
_ Other Tests _
💔unit281m 39shbase-server in the patch failed.
💚asflicense0m 36sThe patch does not generate ASF License warnings.
339m 37s
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestCompactingToCellFlatMapMemStore
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestFromClientSideWithCoprocessor
SubsystemReport/Notes
DockerClient=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/artifact/out/Dockerfile
GITHUB PR#757
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux df27552a7a66 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-757/out/precommit/personality/provided.sh
git revisionmaster / 8f92a14
Default Java1.8.0_181
whitespacehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/artifact/out/whitespace-eol.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/testReport/
Max. process+thread count4807 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@chenxu14

chenxu14 commented Oct 25, 2019

Copy link
Copy Markdown
ContributorAuthor

Let me fix TestCompactingToCellFlatMapMemStore, other failed UT seems unrelated

@Apache-HBase

Apache-HBase commented Oct 25, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec1m 13sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
💚mvninstall6m 24smaster passed
💚compile0m 55smaster passed
💚checkstyle1m 20smaster passed
💚shadedjars4m 34sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 37smaster passed
💙spotbugs4m 5sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 2smaster passed
_ Patch Compile Tests _
💚mvninstall4m 58sthe patch passed
💚compile0m 57sthe patch passed
💚javac0m 57sthe patch passed
💚checkstyle1m 19shbase-server: The patch generated 0 new + 66 unchanged - 2 fixed = 66 total (was 68)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 33spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck15m 41sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 37sthe patch passed
💚findbugs4m 13sthe patch passed
_ Other Tests _
💔unit282m 49shbase-server in the patch failed.
💚asflicense0m 35sThe patch does not generate ASF License warnings.
341m 18s
ReasonTests
Failed junit testshadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.client.TestFromClientSideWithCoprocessor
SubsystemReport/Notes
DockerClient=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/2/artifact/out/Dockerfile
GITHUB PR#757
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 4d3d04ce7fb5 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-757/out/precommit/personality/provided.sh
git revisionmaster / d7b90b3
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/2/testReport/
Max. process+thread count4798 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 8, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 12sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall5m 29smaster passed
+1 💚compile0m 55smaster passed
+1 💚checkstyle1m 21smaster passed
+1 💚shadedjars4m 39sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37smaster passed
+0 🆗spotbugs4m 6sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 3smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 4sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚checkstyle1m 18shbase-server: The patch generated 0 new + 47 unchanged - 2 fixed = 47 total (was 49)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars4m 38spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck15m 44sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 34sthe patch passed
+1 💚findbugs4m 14sthe patch passed
_ Other Tests _
-1 ❌unit331m 32shbase-server in the patch failed.
+1 💚asflicense0m 37sThe patch does not generate ASF License warnings.
389m 17s
ReasonTests
Failed junit testshadoop.hbase.client.TestFromClientSide3
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.client.TestFromClientSideWithCoprocessor
SubsystemReport/Notes
DockerClient=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/3/artifact/out/Dockerfile
GITHUB PR#757
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 4db8ae2a74e0 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-757/out/precommit/personality/provided.sh
git revisionmaster / 3466105
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/3/testReport/
Max. process+thread count4928 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 22, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 3s#757 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/console
versionsgit=2.17.1
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

1 similar comment
@Apache-HBase

Apache-HBase commented May 22, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 3s#757 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/console
versionsgit=2.17.1
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 22, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 59smaster passed
+1 💚checkstyle1m 4smaster passed
+1 💚spotbugs2m 3smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 26sthe patch passed
+1 💚checkstyle1m 0shbase-server: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 9sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 11sthe patch passed
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
32m 44s
SubsystemReport/Notes
DockerClient=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#757
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 0a295a67e87c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e1d7dc8
Max. process+thread count94 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 22, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 16sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall5m 13smaster passed
+1 💚checkstyle1m 30smaster passed
+1 💚spotbugs2m 50smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 24sthe patch passed
+1 💚checkstyle1m 16shbase-server: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck15m 14sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 37sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
44m 12s
SubsystemReport/Notes
DockerClient=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#757
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 69169726c9e3 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0ce85fe
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 23, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 17smaster passed
+1 💚compile1m 3smaster passed
+1 💚shadedjars5m 42sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 41shbase-server in master failed.
_ Patch Compile Tests _
+1 💚mvninstall4m 1sthe patch passed
+1 💚compile1m 4sthe patch passed
+1 💚javac1m 4sthe patch passed
+1 💚shadedjars5m 45spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 39shbase-server in the patch failed.
_ Other Tests _
+1 💚unit125m 13shbase-server in the patch passed.
150m 51s
SubsystemReport/Notes
DockerClient=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#757
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b195dfa24274 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0ce85fe
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/testReport/
Max. process+thread count4088 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 23, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 46smaster passed
+1 💚compile0m 54smaster passed
+1 💚shadedjars5m 37sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 30sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚shadedjars5m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35sthe patch passed
_ Other Tests _
-1 ❌unit144m 58shbase-server in the patch failed.
168m 43s
SubsystemReport/Notes
DockerClient=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#757
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 56db4a33fb21 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0ce85fe
Default Java1.8.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/testReport/
Max. process+thread count3908 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Mar 4, 2021

Copy link
Copy Markdown
Contributor

Any updates here?

@saintstack

saintstack commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

Closing. No updates.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramkrish86ramkrish86ramkrish86 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chenxu14@Apache-HBase@Apache9@saintstack@ramkrish86