Skip to content

HBASE-29144 Client request fails for KERBEROS with RpcConnectionRegistry - #7588

Merged
Apache9 merged 2 commits into
apache:masterfrom
Apache9:HBASE-29144
Jan 14, 2026
Merged

HBASE-29144 Client request fails for KERBEROS with RpcConnectionRegistry#7588
Apache9 merged 2 commits into
apache:masterfrom
Apache9:HBASE-29144

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@junegunnjunegunn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the comment here to drop the phrase "exactly once per implementation" to avoid future confusion:

/**
* Initializes the implementation with configuration and a set of providers available. This method
* should be called exactly once per implementation prior to calling
* {@link #selectProvider(String, User)}.
*/

@Apache-HBase

This comment has been minimized.

@Apache9

Copy link
Copy Markdown
ContributorAuthor

The failed UTs have some problem and maybe the PR here changed something and cause them to fail...

After digging, the problem is that, we want to hack InetAddress for the testing, but for hostname like localhost, we will always return the same InetAddress instance, so the hack in one method may affect other method and cause trouble...

Plan to rewrite the failed two methods to make them more stable.

Thanks.

@Apache-HBase

This comment has been minimized.

@Apache9

Copy link
Copy Markdown
ContributorAuthor

We should update the comment here to drop the phrase "exactly once per implementation" to avoid future confusion:

/**
* Initializes the implementation with configuration and a set of providers available. This method
* should be called exactly once per implementation prior to calling
* {@link #selectProvider(String, User)}.
*/

I modified the comment, PTAL.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@junegunnjunegunn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Apache9Apache9 self-assigned this Jan 7, 2026
@Apache9
Apache9 requested a review from NihalJainJanuary 7, 2026 11:00
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall3m 9smaster passed
+1 💚compile5m 54smaster passed
+1 💚checkstyle1m 47smaster passed
+1 💚spotbugs3m 23smaster passed
+1 💚spotless0m 48sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 6sthe patch passed
+1 💚compile5m 45sthe patch passed
-0 ⚠️javac0m 50s/results-compile-javac-hbase-client.txthbase-client generated 2 new + 125 unchanged - 3 fixed = 127 total (was 128)
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle1m 47sthe patch passed
+1 💚spotbugs3m 54sthe patch passed
+1 💚hadoopcheck12m 17sPatch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚spotless0m 47spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 35sThe patch does not generate ASF License warnings.
52m 43s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7588/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7588
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 14eedbe4e32a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 8a6816c
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server hbase-mapreduce U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7588/7/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 25smaster passed
+1 💚compile2m 3smaster passed
+1 💚javadoc1m 19smaster passed
+1 💚shadedjars6m 2sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 10sthe patch passed
+1 💚compile2m 3sthe patch passed
+1 💚javac2m 3sthe patch passed
+1 💚javadoc1m 15sthe patch passed
+1 💚shadedjars5m 58spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit2m 22shbase-common in the patch passed.
+1 💚unit1m 31shbase-client in the patch passed.
-1 ❌unit236m 53s/patch-unit-hbase-server.txthbase-server in the patch failed.
+1 💚unit19m 27shbase-mapreduce in the patch passed.
293m 0s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7588/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7588
Optional Testsjavac javadoc unit compile shadedjars
unameLinux bf1f61fea52e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 8a6816c
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7588/7/testReport/
Max. process+thread count4447 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server hbase-mapreduce U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7588/7/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
ContributorAuthor

The failed UTs are not related.

Let me merge.

@Apache9
Apache9 merged commit 19c9d33 into apache:masterJan 14, 2026
1 check failed
Apache9 added a commit that referenced this pull request Jan 14, 2026
…try (#7588)
Signed-off-by: Junegunn Choi <junegunn@apache.org>
(cherry picked from commit 19c9d33)
Apache9 added a commit to Apache9/hbase that referenced this pull request Jan 14, 2026
…try (apache#7588)
Signed-off-by: Junegunn Choi <junegunn@apache.org>
(cherry picked from commit 19c9d33)
Apache9 added a commit that referenced this pull request Jan 15, 2026
…try (#7588) (#7624)
(cherry picked from commit 19c9d33)
Signed-off-by: Junegunn Choi <junegunn@apache.org>
Apache9 added a commit that referenced this pull request Jan 15, 2026
…try (#7588) (#7624)
(cherry picked from commit 19c9d33)
Signed-off-by: Junegunn Choi <junegunn@apache.org>
(cherry picked from commit 7bb620d)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@junegunn