HBASE-29807 Depend on jcip-annotations explicitly by xavifeds8 · Pull Request #7592 · apache/hbase

xavifeds8 · 2026-01-05T20:52:34Z

Issue : HBase build fails with latest Hadoop versions due to missing net.jcip.annotations package.
Earlier hadoop was dependent on com.nimbusds:nimbus-jose-jwt:jar:9.37.2 (which brought in com.github.stephenc.jcip:jcip-annotations:jar:1.0-1).

With latest hadoop: it has moved to com.nimbusds:nimbus-jose-jwt:jar:10.0.2 (which does not bring in the dependency), refer commit apache/hadoop@3baa288#diff-635a9ebcc70f58d8ca1c55b0d78cc90064a5081d189162a432271778da3cf018.

Copilot

Pull request overview

This PR adds the jcip-annotations dependency to HBase to maintain compatibility with Hadoop 3.4+, where the dependency is no longer transitively provided through nimbus-jose-jwt.

Key Changes:

Added jcip-annotations to the root pom's dependencyManagement section
Added jcip-annotations as a compile-scoped optional dependency to hbase-client module

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
pom.xml	Adds jcip-annotations to dependencyManagement with version 1.0-1 using groupId com.github.stephenc.jcip
hbase-client/pom.xml	Declares jcip-annotations as a compile-scoped optional dependency for the hbase-client module where it's used

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Apache-HBase · 2026-01-06T12:11:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
+0 🆗	mvndep	0m 28s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 40s		master passed
+1 💚	compile	13m 52s		master passed
+1 💚	spotless	1m 17s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 23s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 48s		the patch passed
+1 💚	compile	13m 22s		the patch passed
+1 💚	javac	13m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	xmllint	0m 1s		No new issues.
+1 💚	hadoopcheck	16m 48s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	1m 13s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 27s		The patch does not generate ASF License warnings.
		68m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7592/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7592
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
uname	Linux fe6486b418e1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7d5a9e3`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	187 (vs. ulimit of 30000)
modules	C: hbase-client . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7592/3/console
versions	git=2.34.1 maven=3.9.8 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-06T15:59:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 12s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 24s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 34s		master passed
+1 💚	compile	2m 22s		master passed
+1 💚	javadoc	2m 40s		master passed
+1 💚	shadedjars	5m 20s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 19s		the patch passed
+1 💚	compile	1m 40s		the patch passed
+1 💚	javac	1m 40s		the patch passed
+1 💚	javadoc	1m 42s		the patch passed
+1 💚	shadedjars	4m 31s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	265m 22s	/patch-unit-root.txt	root in the patch failed.
		296m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7592/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7592
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d16a61eabf36 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7d5a9e3`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7592/3/testReport/
Max. process+thread count	5247 (vs. ulimit of 30000)
modules	C: hbase-client . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7592/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

xavifeds8 · 2026-03-03T09:50:23Z

@Apache9 Since Hadoop has moved to com.nimbusds:nimbus-jose-jwt:jar:10.0.2 (which no longer brings jcip-annotations as a transitive dependency), Hadoop now explicitly depends on com.github.stephenc.jcip to provide jcip-annotations.
However, in HBase, we currently have net.jcip specified in the supplemental-models.xml file, which also brings in jcip-annotations.
Should we align with Hadoop and move to com.github.stephenc.jcip, or should we continue using net.jcip?

Apache9 · 2026-03-03T13:46:54Z

@Apache9 Since Hadoop has moved to com.nimbusds:nimbus-jose-jwt:jar:10.0.2 (which no longer brings jcip-annotations as a transitive dependency), Hadoop now explicitly depends on com.github.stephenc.jcip to provide jcip-annotations. However, in HBase, we currently have net.jcip specified in the supplemental-models.xml file, which also brings in jcip-annotations. Should we align with Hadoop and move to com.github.stephenc.jcip, or should we continue using net.jcip?

The supplemental-models.xml file does not introduce dependencies, we use this file to tell some checks in the release stage(I can not recall the name) that these dependencies have incorrect license information but their licenses are compatibible.

So if we do not need to depend on some libraries any more, we could just remove the related section in supplemental-models.xml, and there is also no problem to leave it as is.

Since hadoop now depends on com.github.stephenc.jcip directly, why do we not pull the dependency in?

Apache9 · 2026-03-05T09:46:53Z

I mean why we need to add it in our pom explicitly? We can not pull it in automatically when depending on hadoop? Hadoop also declares it as an optional dependency?

xavifeds8 · 2026-03-05T13:26:27Z

I mean why we need to add it in our pom explicitly? We can not pull it in automatically when depending on hadoop? Hadoop also declares it as an optional dependency?

I was thinking it would be much safer if we declare it ourself so in the future If Hadoop later marks it optional or removes it. Hbase wont be affected. Since we directly use them in some classes, seems safer to just declare it ourselves rather than hoping it stays available transitively.
Adding to this, Hadoop adds the jcip dependency in the test scope. Hence we wont be getting that depedency transitively. hence the explicit depedency would be necessary.
What do you think? Any concerns with this approach?

Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org> Reviewed-by: Liu Xiao <liuxiao2103@qq.com> (cherry picked from commit 832e68e)

…he#7893) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org> Reviewed-by: Liu Xiao <liuxiao2103@qq.com> (cherry picked from commit 832e68e)

This comment has been minimized.
Sign in to view

NihalJain changed the title ~~Add jcip-annotations dependency to hbase for Hadoop 3.4+ compatibility~~HBASE-29807 Add jcip-annotations dependency to hbase for Hadoop 3.4+ compatibilityJan 6, 2026

NihalJain reviewed Jan 6, 2026
View reviewed changes

Comment threadpom.xml Outdated

NihalJain requested a review from Copilot January 6, 2026 05:00

Copilotstarted reviewing on behalf of NihalJain January 6, 2026 05:00 View session

CopilotAI reviewed Jan 6, 2026
View reviewed changes

Comment threadpom.xml Outdated
Comment threadhbase-client/pom.xml

xavifeds8 changed the title ~~HBASE-29807 Add jcip-annotations dependency to hbase for Hadoop 3.4+ compatibility~~HBASE-29807 Depend on jcip-annotations explicitlyJan 6, 2026

xavifeds8 force-pushed the add_jcip/HBASE-29807 branch 3 times, most recently from c80c665 to 7d5a9e3Compare January 6, 2026 05:26

This comment has been minimized.
Sign in to view

NihalJain mentioned this pull request Mar 3, 2026
HBASE-29921 Bump default hadoop 3 version to 3.4.3 #7803
Merged

xavifeds8 force-pushed the add_jcip/HBASE-29807 branch from db6fc19 to 188a66dCompare March 3, 2026 09:35

xavifeds8 force-pushed the add_jcip/HBASE-29807 branch from 71b6b4b to baa13d6Compare March 4, 2026 20:59

xavifeds8 force-pushed the add_jcip/HBASE-29807 branch from baa13d6 to 3be672dCompare March 8, 2026 17:45

xavifeds8 added 2 commits March 9, 2026 15:04

HBASE-29807 Depend on jcip-annotations explicitly
639239d

Add jcip-annotations to hbase-server pom for successful build
d6c7466

xavifeds8 force-pushed the add_jcip/HBASE-29807 branch from 3be672d to d6c7466Compare March 9, 2026 15:05

Apache9 approved these changes Mar 9, 2026
View reviewed changes

liuxiaocs7 approved these changes Mar 9, 2026
View reviewed changes

xavifeds8 mentioned this pull request Mar 10, 2026
HBASE-29807 Depend on jcip-annotations explicitly #7892
Merged

NihalJain approved these changes Mar 10, 2026
View reviewed changes

NihalJain merged commit 832e68e into apache:masterMar 10, 2026
10 of 13 checks passed

Navigation Menu

Uh oh!

HBASE-29807 Depend on jcip-annotations explicitly - #7592

HBASE-29807 Depend on jcip-annotations explicitly#7592
NihalJain merged 2 commits into
apache:masterfrom
xavifeds8:add_jcip/HBASE-29807

xavifeds8 commented Jan 5, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Jan 6, 2026

Uh oh!

Apache-HBase commented Jan 6, 2026

Uh oh!

xavifeds8 commented Mar 3, 2026

Uh oh!

Apache9 commented Mar 3, 2026

Uh oh!

Apache9 commented Mar 5, 2026

Uh oh!

xavifeds8 commented Mar 5, 2026•
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

xavifeds8 commented Jan 5, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Jan 6, 2026

Uh oh!

Apache-HBase commented Jan 6, 2026

Uh oh!

xavifeds8 commented Mar 3, 2026

Uh oh!

Apache9 commented Mar 3, 2026

Uh oh!

Apache9 commented Mar 5, 2026

Uh oh!

xavifeds8 commented Mar 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

xavifeds8 commented Mar 5, 2026•
edited
Loading